Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp612330yba; Fri, 3 May 2019 07:42:06 -0700 (PDT) X-Google-Smtp-Source: APXvYqz+ecN3EexH0zAfVrdAc7ybZ7UkLkcN09/bSgLmO9rYdjPsxvh39ni4exG9pjFpwE54FJfQ X-Received: by 2002:a17:902:b481:: with SMTP id y1mr10873216plr.161.1556894526066; Fri, 03 May 2019 07:42:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556894526; cv=none; d=google.com; s=arc-20160816; b=N38uVU9ZSHDqsdMo863e4dCEX5eXE4UQjZ2JCug511ud0fkmlc3M/+WnZFyG66ghfw nn/EhMlhKKtHfMc9PUfRuSeeMgh6tqQOu+SNfbpjJLXnb21MAHBGdZfFMvaPLCNbT13N TMTNQQBj6tmiQ9Vcb/uIVOrGyFb3s41b6Dywfz8ddYAZaqGEgClCh33Zu8OIBWDkKxjk +xeTsdCHzbMxVMIqxTYzBMVZkrncMjBQ+rPo4i0pJYW2q20R7YeF6vHsaSB0Y3A+X8a6 05Q1JTRkFq1q4He9aBfk/2t/FbuyEANuj0hU9NpSgT3H7R0VVerl/Y0K5cO6C5AGIZa7 OT4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :content-language:accept-language:in-reply-to:references:message-id :date:thread-index:thread-topic:subject:cc:to:from; bh=cafRse5v9j40Cpf1EbBYzXNGg3fwbNucBHe3dikoN9A=; b=CvUPRPU//O7S0JKdNMoO3HB/kOYwbS8skq8VahIVrP85w7X4qkopYO6kwTtWA4eT7o V7w707AirpVRDx+01cL5MFNouhlY4YA8ApN45FV00xuoVnarl4mwt6BtMNYaTcTZaMnD zxh3mGhUso5jnXASJ8FgVt7ZEMB8Z8DYR//Twcoclr/ZTStQsklCBYdT+fivMoYWok4O q95y48KXfg0ch/KJuZPYfNpy3fOK+8OgES82u+W4jwQcypvZliFRrSWNo61DHvVu2LSV tTs+bb0V3rOlNlD+sHZku/eERYW37w/TTZvaLWz44jb4mOQlRpV++Z4oT0oHTyuE0Uop dFpQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j12si2535419pgg.6.2019.05.03.07.41.49; Fri, 03 May 2019 07:42:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726969AbfECOjj convert rfc822-to-8bit (ORCPT + 99 others); Fri, 3 May 2019 10:39:39 -0400 Received: from eu-smtp-delivery-151.mimecast.com ([146.101.78.151]:30301 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726377AbfECOji (ORCPT ); Fri, 3 May 2019 10:39:38 -0400 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-113-LyrG2MGFMYeVaRNCuyPBFw-1; Fri, 03 May 2019 15:39:35 +0100 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b::d117) by AcuMS.aculab.com (fd9f:af1c:a25b::d117) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Fri, 3 May 2019 15:39:32 +0100 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Fri, 3 May 2019 15:39:32 +0100 From: David Laight To: 'Philippe Schenker' , "linux-iio@vger.kernel.org" , Jonathan Cameron , "Stefan Agner" , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler CC: Philippe Schenker , Max Krummenacher , Alexandre Torgue , "linux-kernel@vger.kernel.org" , Lee Jones , Maxime Coquelin , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH 2/3] iio: stmpe-adc: Make wait_completion non interruptible Thread-Topic: [PATCH 2/3] iio: stmpe-adc: Make wait_completion non interruptible Thread-Index: AQHVAbg3A7HWDrzd+kO5dj2pSSFp8qZZeDWw Date: Fri, 3 May 2019 14:39:32 +0000 Message-ID: <0aab3e91bb9644acb430a8beba927b5a@AcuMS.aculab.com> References: <20190503135725.9959-1-dev@pschenker.ch> <20190503135725.9959-2-dev@pschenker.ch> In-Reply-To: <20190503135725.9959-2-dev@pschenker.ch> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 X-MC-Unique: LyrG2MGFMYeVaRNCuyPBFw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Philippe Schenker > Sent: 03 May 2019 14:57 > In some cases, the wait_completion got interrupted. This caused the > error-handling to mutex_unlock the function. The before turned on > interrupt then got called anyway. In the ISR then completion() > was called causing problems. > > Making this wait_completion non interruptible solves the problem. Won't the same thing happen if the interrupt occurs just after the timeout? David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)