Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp701151yba; Fri, 3 May 2019 09:05:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqyWIJSJPWcfZ/+6iGzVIfBs6WWdDwAksUQZIaNESQih8cyNUD5lx1lBodxalSjKwrdSHyOz X-Received: by 2002:a65:60d0:: with SMTP id r16mr10960659pgv.229.1556899545328; Fri, 03 May 2019 09:05:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556899545; cv=none; d=google.com; s=arc-20160816; b=A32KpIZL6YrnXFJM7MHPj4oFcPpwBJgQPgzxC9H7RQq+KPXoHzUV0UrIV1Qg3NFfPB /2IbOyYo+XXrx7LqAR1HGKLt5tJzz8n7+QHpa0Lbh4rpCQ48jiyYfjSSnT1lofs+v8yc K3W69rXijHVt8lyZXhKHkySdZUG/cZ5iGUeU/cVlpG4aILzD53/3Y/704qDJLA+tMbze sZMwQLvcTF7WBaJ7mmBPj/OWkbnz1YNpsWh5O5OSEUPYRAzGxtDxjLvjJc9n6ni8GmeC Bfm3gE9SQVTHX/2vJLae94rTvEDvA8OBdOr4DGcxxXPJwPEXt0VdVtNHB/Uki84hY3vW JJ9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ma9CwmMisa5gdOaUE9jkymf+L6NBoDL+oHtc1+vmYP8=; b=LhsJvB78qGYQ9xlCAxFWmpmhJ6X9ZT4jROXkd8D+7LzqwhEWRH34lsM3pPvtx42Mer cHVSg8VkYuiBtQz+B2IyW0gZVCavfKREgCmKwdzVYc1IX0TOpQU8wGpzLTexGtHOaWpz iHsBfWxqZkGrIk45i0OlDXmLn93FEtn+EEHesz6ug9Uji+7ELbm5qgNWuudajaHXbUmp JRAGVdn/6vE+b2YWdCJNw/nQGFXs53sbIkA7ZSczxT6zrcVyR0iFnO/M5oYfjBbQE8+F SOBoQA9wXu2g/+9cxVh28uII+fDD+NfYFOaqSBcl7CLs2PcZ0+OGBbW9y3zQCyxw4/bv 37dw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r185si2761709pgr.10.2019.05.03.09.05.29; Fri, 03 May 2019 09:05:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727466AbfECPjN (ORCPT + 99 others); Fri, 3 May 2019 11:39:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56996 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726476AbfECPjM (ORCPT ); Fri, 3 May 2019 11:39:12 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 966AC3092649; Fri, 3 May 2019 15:39:12 +0000 (UTC) Received: from redhat.com (dhcp-17-208.bos.redhat.com [10.18.17.208]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9FDB35C8BC; Fri, 3 May 2019 15:39:11 +0000 (UTC) Date: Fri, 3 May 2019 11:39:09 -0400 From: Joe Lawrence To: Petr Mladek Cc: Jiri Kosina , Josh Poimboeuf , Miroslav Benes , Kamalesh Babulal , "Tobin C . Harding" , Greg Kroah-Hartman , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] livepatch: Remove custom kobject state handling and duplicated code Message-ID: <20190503153909.GD24094@redhat.com> References: <20190503132625.23442-1-pmladek@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190503132625.23442-1-pmladek@suse.com> User-Agent: Mutt/1.11.3 (2019-02-01) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Fri, 03 May 2019 15:39:12 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 03, 2019 at 03:26:23PM +0200, Petr Mladek wrote: > Tobin's patch[1] uncovered that the livepatching code handles kobjects > a too complicated way. > > The first patch removes the unnecessary custom kobject state handling. > > The second patch is an optional code deduplication. I did something > similar already when introducing the atomic replace. But it was > not considered worth it. There are more duplicated things now... > > [1] https://lkml.kernel.org/r/20190430001534.26246-1-tobin@kernel.org > > > Petr Mladek (2): > livepatch: Remove custom kobject state handling > livepatch: Remove duplicated code for early initialization > > include/linux/livepatch.h | 3 -- > kernel/livepatch/core.c | 86 ++++++++++++++++++++--------------------------- > 2 files changed, 37 insertions(+), 52 deletions(-) > > -- > 2.16.4 > For the series, Acked-by: Joe Lawrence -- Joe