Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp717766yba; Fri, 3 May 2019 09:19:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqzL/fwUH6nVGyaMo2i2ZRI2N93Mjqu0B6uN0tKO6HfVymgEIJtZ6tFAo0jrJi+11JNYTV1D X-Received: by 2002:a17:902:2927:: with SMTP id g36mr11026780plb.6.1556900349824; Fri, 03 May 2019 09:19:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556900349; cv=none; d=google.com; s=arc-20160816; b=cOLv1Jk/uEgVSEOsGiEYyLKVRqRSa/pM8H1JTEN8hQ5urqv+qQlQRcP8wF50InZdKP tkI4mxfMt3hncJDmp+yYhzV+ujjFfcfR2PdiaIto9rkAtG+GYEoDO1d5bX7bPGG3vUB4 TBH/SESVfAfAmg4qWxxqd66cqeUedPr4TnSFJ1uC+ojvejmKV6h5XNLaxc1VqpCbh0uF biQVA92o1xOI3v0abNU9ks/CK0k42UzHKitYCokKXh70or2UH2bQ1RdiHQTm/f4DmJ1J wYjQUbJLF94tT6XZya9I4fVd+pD/4Dqmur3guPht0NNH62TKTgkbtQrw+Fn575g3+Xla TNiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :dlp-reaction:dlp-version:dlp-product:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=LlIGEt3bARIWMAARNz7cxY9S8TNkfdMs5crPDq0NLMM=; b=eUp9Fg/HWvH0l8zK+ulsTTjFm2KGw7/KyBEU0QtkuMZuqVnsxNpuKLPUMGuMsaGuai aFPlHCVniS5F3SI9MaN9iGCADA0Bp9+lIk963TA77gaHg9mxcu4esleX6lPuT4PSLMec Tg84AOW3HkxY7tRavUhLhLOi1OuYOwVvlINELmWw1vnb6tXR8e9p8J2oh4Cq8nB6gUSK OBVjxWWsE96jzU5Vr9Fzb3fRZ8rn1CmKnXs5pjbM0sHkeS9yRsu+YgF0MGBy0sNFrSnW 3FZKJF1AnWykweQELTzk7VBK62RgmvtmD76VCDDPW9ORq0C0Ul/q+cDetzQi4NzM5Ez5 7Rtg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i3si2996358pld.129.2019.05.03.09.18.53; Fri, 03 May 2019 09:19:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727910AbfECQRe convert rfc822-to-8bit (ORCPT + 99 others); Fri, 3 May 2019 12:17:34 -0400 Received: from mga17.intel.com ([192.55.52.151]:14340 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727641AbfECQRd (ORCPT ); Fri, 3 May 2019 12:17:33 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 May 2019 09:17:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,426,1549958400"; d="scan'208";a="154484372" Received: from irsmsx106.ger.corp.intel.com ([163.33.3.31]) by FMSMGA003.fm.intel.com with ESMTP; 03 May 2019 09:17:29 -0700 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.21]) by IRSMSX106.ger.corp.intel.com ([169.254.8.235]) with mapi id 14.03.0415.000; Fri, 3 May 2019 17:17:28 +0100 From: "Reshetova, Elena" To: Ingo Molnar , David Laight CC: Andy Lutomirski , Theodore Ts'o , "Eric Biggers" , "ebiggers@google.com" , "herbert@gondor.apana.org.au" , Peter Zijlstra , "keescook@chromium.org" , Daniel Borkmann , "linux-kernel@vger.kernel.org" , "jpoimboe@redhat.com" , "jannh@google.com" , "Perla, Enrico" , "mingo@redhat.com" , "bp@alien8.de" , "tglx@linutronix.de" , "gregkh@linuxfoundation.org" , "Edgecombe, Rick P" , Linus Torvalds , Peter Zijlstra Subject: RE: [PATCH] x86/entry/64: randomize kernel stack offset upon syscall Thread-Topic: [PATCH] x86/entry/64: randomize kernel stack offset upon syscall Thread-Index: AQHU81HQwzT9MH4dM0y/JZXnSwiYT6Y8wW2AgAAdM1CAAXexAIAANZ3ggAAW1gCAAApRgIAAMeKAgAAd+PCAAQuGgIAAYQuAgAAKhwCACsPi4IADJTwAgAAcagCAAExngIAEBbGAgACIbACAAbyQ8IAA626AgAGZfXCAAARpgIAAWpuAgAAF74CAABf/AIAAAvkAgAGZnrA= Date: Fri, 3 May 2019 16:17:28 +0000 Message-ID: <2236FBA76BA1254E88B949DDB74E612BA4C6F523@IRSMSX102.ger.corp.intel.com> References: <57357E35-3D9B-4CA7-BAB9-0BE89E0094D2@amacapital.net> <2236FBA76BA1254E88B949DDB74E612BA4C66A8A@IRSMSX102.ger.corp.intel.com> <6860856C-6A92-4569-9CD8-FF6C5C441F30@amacapital.net> <2236FBA76BA1254E88B949DDB74E612BA4C6A4D7@IRSMSX102.ger.corp.intel.com> <303fc4ee5ac04e4fac104df1188952e8@AcuMS.aculab.com> <2236FBA76BA1254E88B949DDB74E612BA4C6C2C3@IRSMSX102.ger.corp.intel.com> <2e55aeb3b39440c0bebf47f0f9522dd8@AcuMS.aculab.com> <20190502150853.GA16779@gmail.com> <20190502164524.GB115950@gmail.com> In-Reply-To: <20190502164524.GB115950@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGFlNGZlY2EtYjdhNi00OTZhLWI0Y2UtNWQxZWY2OWNhYmJkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiZ1VTTmFFSVlLYnl1dVFnOTZwRUM0eXN2c2RpcWVXanpCZ0Nwc0MrWUxmSGtsMlVcL1ZKaFZSTTloSUxRWm9UMEgifQ== x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > * David Laight wrote: > > > It has already been measured - it is far too slow. > > I don't think proper buffering was tested, was it? Only a per syscall > RDRAND overhead which I can imagine being not too good. > Well, I have some numbers, but I am struggling to understand one aspect there. So, this is how it looks when PAGE_TABLE_ISOLATION is off: base: Simple syscall: 0.0516 microseconds rdrand (calling every 8 syscalls): Simple syscall: 0.0795 microseconds get_random_bytes (4096 bytes buffer): Simple syscall: 0.0597 microseconds But then it looks like this with PAGE_TABLE_ISOLATION is on: base: Simple syscall: 0.1761 microseconds get_random_bytes (4096 bytes buffer): Simple syscall: 0.1793 microseconds get_random_bytes (64 bytes buffer): Simple syscall: 0.1866 microseconds rdrand (calling every 8 syscalls): Simple syscall: 0.3131 microseconds So, suddenly calling rdrand is much more pricey... Either smth is really weird going on when PAGE_TABLE is enabled, or I managed to do smth wrongly (no idea what although). I will continue Investigating. Best Regards, Elena.