Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp765104yba; Fri, 3 May 2019 10:05:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqztvFNqbSnU5StHcSh6wzjkSa9yqiuXknndzDE3bBC5Rhag/NVuq8WUyjX/Ct3IorpUXoNA X-Received: by 2002:a65:64c9:: with SMTP id t9mr11631664pgv.221.1556903117411; Fri, 03 May 2019 10:05:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556903117; cv=none; d=google.com; s=arc-20160816; b=TaZlH0aRJZ2RfZ69w/27SsVhBKfDSnZsjKlgJUHezhsEoFE0gK4KF/ZjSZxYYySIz6 8DPCu3SzFcC7kceqsG4kYT3+W6u7feeiI9ZdLM5JYJ2XRag4TUrTu11ycZxmCIBKLUoX uXKL2jkF5hJpysVbklsQzsg6vt0qtL0t5JkLzETjzif1w8+hieaM8LNM+DFkw5F+LAjr MqbOx2j8z36DodydxX2l5evfpIAEvApZgqaIzGREF9COf86K2cvrcGUgByN7i+CkJUkJ kf4giwIEPQipr/82cZ6cz5xqrbdwUXQ6AaBGaBAgCbwfRt6sEXYrqzgUXfChg4R5GTl7 vIdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:user-agent:message-id:subject:from :cc:to:references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=wQFeqtk0b9+Acg78B6JbyuJJJmhtUePDvdDbBS6/xGI=; b=XlSooNXeTs0I0Mj2xizGMocjANc6F0qUISy77PjRpf6HhyUnep4xjWdShkqYapUugP UB9BDBJwdmsZ3iFNAV96HpU3pANjbEZso5ZFeqDJYgy+5/QrPfEkMZ+in6RPSzffMHlK MoyUSqWBkCZfVDYKpNxjOB0tSke9lG9SbjhYHXlIbCAcWO88q8TRG/GS1xvAXiFFLRgB QgaE29MOQK2nWVyPL0QdlRGrx69VP6ju9cPL0Oa0cUCkkdCAakO67MkqE+oSxKuhB0A5 fIyxart7VWskIY4IsZelh+CDJlovxf2eaCeoiIKhaBUuJcW7Bz2T2oVRyR7WkIESZbc2 Ry7A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=h4PYxc9P; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q8si3042973pgf.3.2019.05.03.10.05.01; Fri, 03 May 2019 10:05:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=h4PYxc9P; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728414AbfECQcH (ORCPT + 99 others); Fri, 3 May 2019 12:32:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:33392 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726633AbfECQcG (ORCPT ); Fri, 3 May 2019 12:32:06 -0400 Received: from localhost (unknown [104.132.0.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 27E9420651; Fri, 3 May 2019 16:32:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556901126; bh=wQFeqtk0b9+Acg78B6JbyuJJJmhtUePDvdDbBS6/xGI=; h=In-Reply-To:References:To:Cc:From:Subject:Date:From; b=h4PYxc9P1Ie5o284Z8zsDfHtKG9GDmLEOeEsJjwej4HBoKUNKMNdN1ncb5lBseNjL QmlwzGHRBl+800lmeWXaPBd+IuQXIZukP8Y8HSFqe2l7u3rGGzvvAoLkizMWBKQum9 qHrjr8LotBalA0mWxps+/UDVn/o6+AMxCF2xg808= Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1556261303-6360-1-git-send-email-Anson.Huang@nxp.com> References: <1556261303-6360-1-git-send-email-Anson.Huang@nxp.com> To: "festevam@gmail.com" , "kernel@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "mturquette@baylibre.com" , "s.hauer@pengutronix.de" , "shawnguo@kernel.org" , Aisheng Dong , Anson Huang Cc: dl-linux-imx From: Stephen Boyd Subject: Re: [PATCH] clk: imx: correct pfdv2 gate_bit/vld_bit operations Message-ID: <155690112534.200842.9362435431679500492@swboyd.mtv.corp.google.com> User-Agent: alot/0.8 Date: Fri, 03 May 2019 09:32:05 -0700 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Anson Huang (2019-04-25 23:53:14) > The operations of pfdv2 gate_bit/valid_bit are incorrect, > they are defined as u8 for bit offset, but gate_bit is > actually assigned as mask which could be 32 bit long and > it causes overflow, and vld_bit is assigned as bit offset > based on incorrect gate_bit value, it causes incorrect > pfd clock gate status in clock tree, this patch fixes the > issue by assigning them as correct bit offset. >=20 > Fixes: 9fcb6be3b6c9 ("clk: imx: add pfdv2 support") > Signed-off-by: Anson Huang > --- Applied to clk-next