Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <c1d3fd4db13d999a3ba57f5bbc1924862d824f61.1556881728.git.leonard.crestez@nxp.com>
References: <cover.1556881728.git.leonard.crestez@nxp.com> <c1d3fd4db13d999a3ba57f5bbc1924862d824f61.1556881728.git.leonard.crestez@nxp.com>
To:     Jan Kiszka <jan.kiszka@siemens.com>,
        Kieran Bingham <kbingham@kernel.org>,
        Leonard Crestez <leonard.crestez@nxp.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Michael Turquette <mturquette@baylibre.com>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
From:   Stephen Boyd <sboyd@kernel.org>
Subject: Re: [PATCH 1/2] scripts/gdb: Cleanup error handling in list helpers
Message-ID: <155690120115.200842.4461891246222331678@swboyd.mtv.corp.google.com>
User-Agent: alot/0.8
Date:   Fri, 03 May 2019 09:33:21 -0700
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Leonard Crestez (2019-05-03 04:19:31)
> An incorrect argument to list_for_each is an internal error in gdb
> scripts so a TypeError should be raised. The gdb.GdbError exception type
> is intended for user errors such as incorrect invocation.
>=20
> Drop the type assertion in list_for_each_entry because list_for_each isn't
> going to suddenly yield something else.
>=20
> Applies to both list and hlist

This should be done to other "type errors" in the gdb scripts too.

>=20
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> ---

Either way,

Reviewed-by: Stephen Boyd <sboyd@kernel.org>