Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp919940yba; Fri, 3 May 2019 12:42:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqyKoeNX7DCqZa4J80YRhz//9+xbf05A+E6EaUFxjpgFFUd6YvSTwPiPxNOQ2J1VET5x+D1b X-Received: by 2002:a65:60d7:: with SMTP id r23mr12279577pgv.223.1556912523669; Fri, 03 May 2019 12:42:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556912523; cv=none; d=google.com; s=arc-20160816; b=y46/9Oa3sMg53DJHpqy4LKphZU9toA2CFck09XMTqYwjggMcxJ4nhYPxiyyJh2RNOg xikpbD2JK1zkmMfZ9ewA2v+hbdMTf87RpTTE3BZguqUXHWJ3uyNMxysPNog7rzgN3T+a diOcnXXPKGt7bectQe+CXRGfEvku2BLOZiXfHMCmBm8bwxMpLtbm5V/ccNN3a0+k/kNE Wggk+15Hfix2reIdw2uSUA0jSqskkbO/faspL6OgF+iluE6E0G3GAQQ4P/3TJckUwFix Kp7+TIsok5mpMi+55Qbip9dVFSiJXvPFhv9Hr6nuetol0fUCfDF4OgdRTET33+tA8nA/ UzsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=XutbePJmEyY+rMx/pqoWxifl49Lqa5PJBKT9Bib1YJQ=; b=DAjvhAoqtEA5OjdAfQphVyhOrvcyh/GCWkAX4Qrzwxowcsv9XYnGeUItV97URAu66a JGW8puc9tLVW7hBfICJusN4c1o1HZqHF9Xpo06L0GMAscJ7MrNtv3GaS7ocWMN2j9+GM z5qVgu96feJah38aWWlZEFiRPfgWpyQdP9lV7a+p7wVYbkpx6dwPZFdOZ7ohlMOEHK8h My9wZ9cXEyJb8vlW4pKuVede31wfCfET2bpgEYd4/5oZMdVUJCZs6MclAJtcVgUQ/zO4 N0uT4ylLILZSyeKhXczSFllRAhZEjqQiRmqLGlcJxPfU7ECKpKNkd3IEKmZMNAYa8Okn cAig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=grk3ComR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t2si3372371pgp.473.2019.05.03.12.41.48; Fri, 03 May 2019 12:42:03 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=grk3ComR; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727044AbfECTIA (ORCPT + 99 others); Fri, 3 May 2019 15:08:00 -0400 Received: from mail.skyhub.de ([5.9.137.197]:53526 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726769AbfECTH7 (ORCPT ); Fri, 3 May 2019 15:07:59 -0400 Received: from zn.tnic (p200300EC2F0CA900690D0772EBB26CCB.dip0.t-ipconnect.de [IPv6:2003:ec:2f0c:a900:690d:772:ebb2:6ccb]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 9E1451EC0229; Fri, 3 May 2019 21:07:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1556910477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XutbePJmEyY+rMx/pqoWxifl49Lqa5PJBKT9Bib1YJQ=; b=grk3ComRhG06ysNX2boEsej/IIRU/G5eipWbS5KucHxukGY4bGeH4C6uSedqZzbiTB/SZ1 HcId82fWyDgKEATRDkt2WGHQJ+RJXsgHXm12JCTUlLhQ5fTu4dXEm+9MP+rYhbHrq5rkKV YBRqK1FmEWC85tyrILCuwHafLHVX1Ls= Date: Fri, 3 May 2019 21:07:51 +0200 From: Borislav Petkov To: Andy Lutomirski Cc: Paolo Bonzini , Andy Lutomirski , Sebastian Andrzej Siewior , Greg KH , LKML , Rik van Riel , "H. Peter Anvin" , "Jason A. Donenfeld" , Ard Biesheuvel , Dave Hansen , Ingo Molnar , Nicolai Stange , Radim =?utf-8?B?S3LEjW3DocWZ?= , Thomas Gleixner , X86 ML , stable Subject: Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export Message-ID: <20190503190751.GG5020@zn.tnic> References: <761345df6285930339aced868ebf8ec459091383.1556807897.git.luto@kernel.org> <20190502154043.gfv4iplcvzjz3mc6@linutronix.de> <20190502165520.GC6565@zn.tnic> <20190503180739.GF5020@zn.tnic> <5BD87ACE-1200-4612-AA83-1590DA9E45E5@amacapital.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5BD87ACE-1200-4612-AA83-1590DA9E45E5@amacapital.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 03, 2019 at 11:54:54AM -0700, Andy Lutomirski wrote: > I don’t think I or has said we should try to make these interfaces > immutable. How else would you have a stable interface for OOT modules? If at all, that is. > What I’m saying is that, since we’re exporting the symbol anyway > and it’s not particularly Linuxy, that we shouldn’t say that only > *GPL* out-of-tree modules may use it. It seems like anyone who wants > to put the effort into tracking which kernel has which symbols and is > willing to accept the utter instability of the interface may use it. This is just silly: when we change it next time, it'll be the same crying again. No, we don't want to do that. This keeps happening with all kinds of symbols being exported and unexported. > So if we ever unexport the symbol entirely, I won’t object. Yah, and you'll break them again. That's just unnecesary pain each time. > I object to what I consider to be the inappropriate claim that it’s > a *GPL* export. Yes, that is the problem. Jiri alluded to it too - I don't think it is clear to people involved - me included - what exports should be done and how. And what assurances - if any - we're giving. > (I actually hope we unexport it once simd_get() and friends land — > they’re a much better API, and we should migrate over to it.) Same problem as above with those. That's why we need some sort of an explicit ruling all sides will adhere to. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.