Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp936674yba; Fri, 3 May 2019 13:00:57 -0700 (PDT) X-Google-Smtp-Source: APXvYqzdsPXbXkpnB/ntAzpjhyN7e2kWpbgsXU/5OBZSpF8Uq2HH3ehgwOh6nIX+5frLK7beqlxC X-Received: by 2002:a17:902:e683:: with SMTP id cn3mr12984515plb.115.1556913657292; Fri, 03 May 2019 13:00:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556913657; cv=none; d=google.com; s=arc-20160816; b=fv9zObHXIccCUbirsoBf7zBgofwtNT2G8aWNMPlaQslKEQmbQSB8xX4rioyuAnimu6 fuQ96HphL2NHsF3yr7JSO369MIdYzKKPnEHrmKhmMyIk7L1uQnTcb1moDJcKy0+WGoBZ J7n/M6T6CNxkX7ZjXwwx58veiaKAezMDtDuy65lTqrdN3mP6BdXHVAYxvVuDFd5U9HMe AyvX4lmM7Qicjk+1t2GhGuaeSp4VcCXhWH8CWFkItYSVmtLBE4u6HaDDe2GTHrdM0cbX 5DUb530kVMM5O6tHTfqT+YgT9Ck3jpPZgUU7GpyxHVx8ffBGytY9LD9ZiH3N07IjSJyQ WT+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=WB6WukALIt5LPSFOLetrqCfdn6458xhXun4VAeBfku8=; b=TDKasMKb0fI6OLy7FMeQYOspXMGMHcnQRSm5cQAFC8WCc6TOkhsmBEIh3y8oj8g4B9 pHlDDSx/DDvdsKQ6tiITv0r2CuEeSaHAb7xTkXYPQ5+zt3Hv9Manse7V5a0ISFdcAmiC dMBgtsy6ykHNV7mIyYgP0N6PQK9wnZFCt2+3U/AySUa8kHNZHL+Y/wa1iMDrqrMDpYy7 YRD+YQz8r+pvmUkAgZ9ZumN/UPmDvpNlig5hIfL8nxqebvtIQMu6Ah2tcu3KdHUI0zNi mQmQ+qO/liBpOaPPnWFSxN0vQ1xGuiGusQ5iXN2RpoNKFrQUHbVDv3qBMIa6mQfmG10N Ofsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AHZqjeYB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l71si2424207pfb.250.2019.05.03.13.00.39; Fri, 03 May 2019 13:00:57 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=AHZqjeYB; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726913AbfECT6Z (ORCPT + 99 others); Fri, 3 May 2019 15:58:25 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:32999 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725793AbfECT6Y (ORCPT ); Fri, 3 May 2019 15:58:24 -0400 Received: by mail-pf1-f193.google.com with SMTP id z28so3404872pfk.0 for ; Fri, 03 May 2019 12:58:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=WB6WukALIt5LPSFOLetrqCfdn6458xhXun4VAeBfku8=; b=AHZqjeYBooF34dvlJEEYqeS5a/OwB/N3wk8oRUX3xMNSZkJpPj2xUUUhnfeja/ANyO tLcv8IyusQA50EJQjTWkpWqIyRR/dEIwxDFO38PsT9Yr/CGqyAmXM0zi/CYIKU/Tpdzs R4tXGXyS977mH72o1FZgcd3NrHQ4BhL4DfLfyNDG3TvWlrO7QMvI2+13BEABMzrV9zd3 Wu4t6R2/qCSX4OIx24AO7VADifBn7OP2NwFxU7vTCga6cc0iM6EblGTAsERoUhKpvbSm 0soVKjoHaKXoMJZbuEM6ie18l9NrzilF1wzJWAIFdQoBCxxpogrzCe6g3QHS4vuShJz1 UlOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=WB6WukALIt5LPSFOLetrqCfdn6458xhXun4VAeBfku8=; b=hNAcK8+cpvjADVmEm3ad0UO5khW/gdYOK9msU7I2tds8WF91VeLB+eZ/ZdcjKUjkMI tZXJR4IFga4uwZMrRgu7hf6R4vnUXSjtEEIynLrgjHlbAonL06ovWsTVQfkWhTFgMbXR wfF/KgMMS9wkgpr45+gJ9D9Ygs1d5m9JdH7gQYGztwnbeifHUBcYE4qK6Ta865Oy2hW4 omqBJs625/NX/Wi+Ho8DDUNiTN8RvII+SkaG2By43uxTMhKtkTgwg7f8SxICEcXJPCBO 0+vkBYhtIy/bLt+kKUrLZhQ9wyeqLT+SBkKfTsYtoQwVBZaDgx5h7iMtI5clIXZ4Vmnt /Dpw== X-Gm-Message-State: APjAAAW9hiOHnkfc2HQuDTlL1yJKdJznwybgcwwUusTWd4couwPttmqY Y/A4COr9GV0Z49pn8zFNLc8= X-Received: by 2002:a63:d347:: with SMTP id u7mr13073160pgi.254.1556913503804; Fri, 03 May 2019 12:58:23 -0700 (PDT) Received: from Asurada-Nvidia.nvidia.com (thunderhill.nvidia.com. [216.228.112.22]) by smtp.gmail.com with ESMTPSA id i15sm4868020pfr.8.2019.05.03.12.58.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 03 May 2019 12:58:22 -0700 (PDT) Date: Fri, 3 May 2019 12:56:49 -0700 From: Nicolin Chen To: Mark Brown Cc: "S.j. Wang" , "timur@kernel.org" , "Xiubo.Lee@gmail.com" , "festevam@gmail.com" , "alsa-devel@alsa-project.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Subject: Re: [EXT] Re: [PATCH V4] ASoC: fsl_esai: Add pm runtime function Message-ID: <20190503195648.GA30289@Asurada-Nvidia.nvidia.com> References: <20190502023945.GA19532@sirena.org.uk> <20190503042731.GX14916@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190503042731.GX14916@sirena.org.uk> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On Fri, May 03, 2019 at 01:27:31PM +0900, Mark Brown wrote: > On Thu, May 02, 2019 at 09:13:58AM +0000, S.j. Wang wrote: > > > I am checking, but I don't know why this patch failed in your side. I > > Tried to apply this patch on for-5.1, for 5.2, for-linus and for-next, all are > > Successful. The git is git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git. > > > I can't reproduce your problem. Is there any my operation wrong? > > The error message I got was: > > Applying: ASoC: fsl_esai: Add pm runtime function > error: patch failed: sound/soc/fsl/fsl_esai.c:9 > error: sound/soc/fsl/fsl_esai.c: patch does not apply > Patch failed at 0001 ASoC: fsl_esai: Add pm runtime function > > which is the header addition. I can't spot any obvious issues visually > looking at the patch, only thing I can think is some kind of whitespace > damage somewhere. I downloaded this v4 from patchwork and resubmitted a v5 for a test. Would you please try to apply that one? If my v5 works vs. having merge conflict at v4, maybe something wrong with Git version of Shengjiu's? I compared my v5 and his v4 using vimdiff, there is no much difference of whitespace. Thanks Nicolin