Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp990554yba; Fri, 3 May 2019 14:00:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqwidRgINwzh5aP0fr7jneulcpmaKewB9ClbcKqt9yPwdKX4SA4bWPoXOcZ/0hQwv/69mPb4 X-Received: by 2002:a62:a219:: with SMTP id m25mr14081104pff.197.1556917227600; Fri, 03 May 2019 14:00:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556917227; cv=none; d=google.com; s=arc-20160816; b=mkQpU8qDmvJK1DszdFkjzbtrAs3ctB88g+J+TMyqzeG+8m8ZtVAQtofW74GcC6AvGw 7O+DICKxBCMP6w0YMP8OTa8oHUUp4jXLOfGcaT3fDaDformweWpBhdnk/6UoWlAZ3c2s 6MZ1OrBbIcZFlateCYD3JQVdpCx9UDuDF6CJJaRNXSoH+2c09Yhh/EbW9aWUCsH3/Z0F S7ZD+iL6yvDlTW8P9DBjMYLI3r2gk4556e69jH/3DmthVfRqD9O5nyMR49GoUePzIAlL r+7LDfvKkNG3sbWtX08kz+g1zVArvZqroA86Vl5v+OQfMJ+E510t22zp6TziO1nhTG1C a9UQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date:dkim-signature; bh=Mjp0oqT0roJS2k7IeIVc7mHleUFaLaElRkdBXERU2kI=; b=XiemMC/G0H5cCYaSOplUMyjt6s2gDJoK5yd5Wz7P+wLSb9ObdyGYDUxEhqViv2JN48 6QaEkLaa9cOAmXpaAfZfF4i13pwZPzBHfUo/z24B7bF+5AwVuPDmUURCDCSCfwyLkdm2 Y+oHGaqNT1jne7gsYqc2a+RXSngnryWwNXHF330rT2mBYIn+4q3c70o2rX3gonPG6p3v QbYARCdJ/T/N6RlyhyWAde/p609Fq30lYD2nxMcinSStG+6+nbp+x0MzgirlD+u/jzLI 6R6yIrX7iPSwcjB+tpfk++cYZ8cNMbiPkpXvUxkoAZrJ1sTaVNCr6NNct2cPXAzTUK/7 0EOA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ddqiTnXU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r7si4061445pfd.256.2019.05.03.14.00.12; Fri, 03 May 2019 14:00:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=ddqiTnXU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726435AbfECTQg (ORCPT + 99 others); Fri, 3 May 2019 15:16:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:33028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725793AbfECTQg (ORCPT ); Fri, 3 May 2019 15:16:36 -0400 Received: from pobox.suse.cz (prg-ext-pat.suse.com [213.151.95.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 78514206BB; Fri, 3 May 2019 19:16:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556910996; bh=GHcI7jy30ZlqmwJKk9SIWWZDOjhGvPfCm1ybawF8u2U=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=ddqiTnXUJ29CIXlf6JMuYmrs/LVfE6vGNy8Wo6HVbBEaH4GZXIfBXpAeiZHL+dI5v ReDpLRQlB2Ksy4U51OnbvdunQUGnMcF6XjzpiIuCAujQg5m4cUOiNJgrYiKyPxWJAx s3P/4GLtKoDVCinVxKwXKAMtodjKG91uyR87B+sw= Date: Fri, 3 May 2019 21:16:32 +0200 (CEST) From: Jiri Kosina To: Petr Mladek cc: Josh Poimboeuf , Miroslav Benes , Joe Lawrence , Kamalesh Babulal , "Tobin C . Harding" , Greg Kroah-Hartman , live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] livepatch: Remove custom kobject state handling and duplicated code In-Reply-To: <20190503132625.23442-1-pmladek@suse.com> Message-ID: References: <20190503132625.23442-1-pmladek@suse.com> User-Agent: Alpine 2.21 (LSU 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 3 May 2019, Petr Mladek wrote: > Tobin's patch[1] uncovered that the livepatching code handles kobjects > a too complicated way. > > The first patch removes the unnecessary custom kobject state handling. > > The second patch is an optional code deduplication. I did something > similar already when introducing the atomic replace. But it was > not considered worth it. There are more duplicated things now... > > [1] https://lkml.kernel.org/r/20190430001534.26246-1-tobin@kernel.org > > > Petr Mladek (2): > livepatch: Remove custom kobject state handling > livepatch: Remove duplicated code for early initialization I've applied this to for-5.2/core. Thanks, -- Jiri Kosina SUSE Labs