Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965150AbVKIBgk (ORCPT ); Tue, 8 Nov 2005 20:36:40 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932444AbVKIBgk (ORCPT ); Tue, 8 Nov 2005 20:36:40 -0500 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:9896 "EHLO fgwmail5.fujitsu.co.jp") by vger.kernel.org with ESMTP id S932431AbVKIBgj (ORCPT ); Tue, 8 Nov 2005 20:36:39 -0500 Message-ID: <43715266.5080900@jp.fujitsu.com> Date: Wed, 09 Nov 2005 10:35:34 +0900 From: KAMEZAWA Hiroyuki User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) X-Accept-Language: ja, en-us, en MIME-Version: 1.0 To: Christoph Lameter CC: akpm@osdl.org, Mike Kravetz , linux-kernel@vger.kernel.org, Marcelo Tosatti , Nick Piggin , linux-mm@kvack.org, torvalds@osdl.org, Hirokazu Takahashi , Andi Kleen , Magnus Damm , Paul Jackson , Dave Hansen Subject: Re: [PATCH 5/8] Direct Migration V2: upgrade MPOL_MF_MOVE and sys_migrate_pages() References: <20051108210246.31330.61756.sendpatchset@schroedinger.engr.sgi.com> <20051108210402.31330.19167.sendpatchset@schroedinger.engr.sgi.com> In-Reply-To: <20051108210402.31330.19167.sendpatchset@schroedinger.engr.sgi.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 612 Lines: 20 Christoph Lameter wrote: > + err = migrate_pages(pagelist, &newlist, &moved, &failed); > + > + putback_lru_pages(&moved); /* Call release pages instead ?? */ > + > + if (err >= 0 && list_empty(&newlist) && !list_empty(pagelist)) > + goto redo; Here, list_empty(&newlist) is needed ? For checking permanent failure case, list_empty(&failed) looks better. -- Kame - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/