Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp130177yba; Fri, 3 May 2019 22:32:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqz3TQ0JzwaRGGKka4WxOGdYaMaZ5wNF0n28H+BlELO8fa6FzASNlbEj3aauIhLs5fAW8Aaa X-Received: by 2002:a17:902:e20c:: with SMTP id ce12mr15855043plb.247.1556947920138; Fri, 03 May 2019 22:32:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556947920; cv=none; d=google.com; s=arc-20160816; b=SQM8ERDny6arSO2FIEIBfvKQ7pIXeSBOI/7q4w+cRz105UjU/WJOhDEVMrqbYMuuza yQOWv3MaStIIf1W9Nf943I2Wqj/ni2QYHisIoaW2Y+gOj4J1BxUn2SFJnC3rNdfY3Hmt ebxRqAQqPcQF/GL6zU8bumrue3FcHKYXft/nVGTHg6pCgF4AnEYBkWhbLWO07r9avgmd nYFk1B4QfW5BoDNvZQHhfJH9OfnzLnzzvSvMBIMmNqd8j9a4Kum6Q6i9oGFrjCre6uQ7 vUR/Y+RzfIq49U+LfHLWYmQcMmjnQO2XjEQERSZPf3ErGIYmQ1gV843tjbvP9s3u9LLw Jjkg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=4fYZn3BbrJjLHgcLC3rXSgKiNZOdSg/ozHikNDXU+fc=; b=JBNbStNyT0mvOixqvyL3StfDPVMX1gHA16PuE1O3TiN14frwrZ1PI9wwkpzMSwFpV8 egtXRrTj5Jik8WIWAbp05st2qsP9/65gW+959E1y+W4aAenLs+n1sdXfH6RQTV6QCLsH NUWhTojBrMegiZBLvpEyInqXLO9+b2ZjoVEWRP1airH/sn0zYJ4SElOtLDzeWYZtsFS2 1j+/KMUFYtnO/jxLCRENN1aa815CJe74L3Mb6ZGEfd3OPWV0g44RwfpiuomWdreZ2e1L nQNmDfptnH4JRmiZ0SMhWarNzSYCki6ayXy3fOVWhDvBCuk3Nku2gD1YjdcpDrHkxxwx V+Eg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e26si5264474pfi.54.2019.05.03.22.31.14; Fri, 03 May 2019 22:32:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726277AbfEDF2I (ORCPT + 99 others); Sat, 4 May 2019 01:28:08 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:56810 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725801AbfEDF2H (ORCPT ); Sat, 4 May 2019 01:28:07 -0400 Received: from localhost (unknown [75.104.87.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 9A9A114DA0325; Fri, 3 May 2019 22:28:00 -0700 (PDT) Date: Sat, 04 May 2019 01:27:56 -0400 (EDT) Message-Id: <20190504.012756.510495833576060196.davem@davemloft.net> To: mkubecek@suse.cz Cc: netdev@vger.kernel.org, johannes@sipsolutions.net, dsahern@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 0/3] netlink: strict attribute checking follow-up From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 03 May 2019 22:28:06 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Michal Kubecek Date: Thu, 2 May 2019 16:15:10 +0200 (CEST) > Three follow-up patches for recent strict netlink validation series. > > Patch 1 fixes dump handling for genetlink families which validate and parse > messages themselves (e.g. because they need different policies for diferent > commands). > > Patch 2 sets bad_attr in extack in one place where this was omitted. > > Patch 3 adds new NL_VALIDATE_NESTED flags for strict validation to enable > checking that NLA_F_NESTED value in received messages matches expectations > and includes this flag in NL_VALIDATE_STRICT. This would change userspace > visible behavior but the previous switching to NL_VALIDATE_STRICT for new > code is still only in net-next at the moment. > > v2: change error messages to mention NLA_F_NESTED explicitly Series applied.