Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp174188yba; Fri, 3 May 2019 23:36:09 -0700 (PDT) X-Google-Smtp-Source: APXvYqyNImXOkInBRuSz7p8HgMXy+WQIIv2jj54j7AFZ7BQkkASVmDCw2L9gMpViR4eABxW9qng2 X-Received: by 2002:a63:188:: with SMTP id 130mr16410567pgb.391.1556951769775; Fri, 03 May 2019 23:36:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556951769; cv=none; d=google.com; s=arc-20160816; b=tOcGBGWlk5mWTV+uQNsuSZDD4U7VgvmXKS8fqHaq8t1OTZslbmBInQJZIYPNkLKKfi HbvgrDK9cIlZJ1RdL33ZVrsqfm7aSHMCQkeGfuP1Du/opjQ72K1I88D7JKaxhBX3Bora NZkZ4n0HYM6lwpKvih75FmyCj/vJZTR3MSEJB5HFuqhGcqsDsEKIETaCZOhDUfTUjQqi 8uJp64guRfedrQobyyxSZkz85uyGbzmndkEvdS3BJzKqdNvPbN01PemTawD6cI3ZWn16 3L+BGG9sK14N6HLmlsZ93OKCxei7e+ZW9C6C618LuxgOWcLf84OtkkdU41EtZ9B8/aYb yoXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=4FOS/ztXeDD+s2686KAIAGhVdn6k3aZRiN+bl38/w8w=; b=hiwKlFEDiS5eTHVDZa9+t+mGFBO/yKW9uZX/PbhWQRKXIMqbDr06N+ri0z2cka0av8 MEsLYaBo14qY7HhR4DS6p6vGbsmxobpTQVJHaz0RaApHyRx4AYoF/W7YxZr5fcqP/tam 98npQehGdy7OSP4hp7G9fP6sQwUtUHdRcYvSzmKM95uO8kVeEbbVT4/Oe2RYMbM4E4ET Y459kj5O/gEd714g7uJPiH82v9VlzWE2cH25FPhLBFUu4rcsOvfANMC4VdYMT26dKge4 8940uPv3MBOSStM8pg97N6VjD85AoKvp3QMJo6Jk49vGSi5bTiSJGqMD1iklYBewWNTK Mc1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BXJGMfyl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f11si6004932plb.234.2019.05.03.23.35.29; Fri, 03 May 2019 23:36:09 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BXJGMfyl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726258AbfEDGdo (ORCPT + 99 others); Sat, 4 May 2019 02:33:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:45238 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725808AbfEDGdo (ORCPT ); Sat, 4 May 2019 02:33:44 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D23CB206DF; Sat, 4 May 2019 06:33:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1556951623; bh=84mKmofQ1I0p0ojHmcWzw7M3BuEpFKyAKsoEA/IlW5g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BXJGMfyllchGZ/ImhgWiTIVtvq8a84Rs+uoCs5UAPoes8jbBZ4efgHSvmI5lkzQCq GzfxzuURe4t1gtaNj41Tx0+cJCJQTmY+EeQpZLe/DdWaknhPFwqefc+PLrUEyEuYAq iRAoEJcz2gGYVQf7yO20V01JF66M23pztyCk2O54= Date: Sat, 4 May 2019 08:33:40 +0200 From: Greg KH To: Jia-Ju Bai Cc: mathias.nyman@intel.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb: host: xhci_debugfs: Fix a null pointer dereference in xhci_debugfs_create_endpoint() Message-ID: <20190504063340.GA26311@kroah.com> References: <20190504033748.17964-1-baijiaju1990@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190504033748.17964-1-baijiaju1990@gmail.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 04, 2019 at 11:37:48AM +0800, Jia-Ju Bai wrote: > In xhci_debugfs_create_slot(), kzalloc() can fail and > dev->debugfs_private will be NULL. > In xhci_debugfs_create_endpoint(), dev->debugfs_private is used without > any null-pointer check, and can cause a null pointer dereference. > > To fix this bug, a null-pointer check is added in > xhci_debugfs_create_endpoint(). > > This bug is found by a runtime fuzzing tool named FIZZER written by us. > > Signed-off-by: Jia-Ju Bai Very rare case, but nice fix. You should put "potential" in your subject line as this is something that no one should ever hit :) Anyway: Reviewed-by: Greg Kroah-Hartman