Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030240AbVKIEAj (ORCPT ); Tue, 8 Nov 2005 23:00:39 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030455AbVKIEAj (ORCPT ); Tue, 8 Nov 2005 23:00:39 -0500 Received: from fgwmail6.fujitsu.co.jp ([192.51.44.36]:27608 "EHLO fgwmail6.fujitsu.co.jp") by vger.kernel.org with ESMTP id S1030240AbVKIEAi (ORCPT ); Tue, 8 Nov 2005 23:00:38 -0500 Message-ID: <43717426.3050002@jp.fujitsu.com> Date: Wed, 09 Nov 2005 12:59:34 +0900 From: KAMEZAWA Hiroyuki User-Agent: Mozilla Thunderbird 1.0.7 (Windows/20050923) X-Accept-Language: ja, en-us, en MIME-Version: 1.0 To: Christoph Lameter CC: akpm@osdl.org, Mike Kravetz , linux-kernel@vger.kernel.org, Marcelo Tosatti , Nick Piggin , linux-mm@kvack.org, torvalds@osdl.org, Hirokazu Takahashi , Andi Kleen , Magnus Damm , Paul Jackson , Dave Hansen Subject: Re: [PATCH 5/8] Direct Migration V2: upgrade MPOL_MF_MOVE and sys_migrate_pages() References: <20051108210246.31330.61756.sendpatchset@schroedinger.engr.sgi.com> <20051108210402.31330.19167.sendpatchset@schroedinger.engr.sgi.com> <43715266.5080900@jp.fujitsu.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1296 Lines: 43 Christoph Lameter wrote: > On Wed, 9 Nov 2005, KAMEZAWA Hiroyuki wrote: > > >>Christoph Lameter wrote: >> >>>+ err = migrate_pages(pagelist, &newlist, &moved, &failed); >>>+ >>>+ putback_lru_pages(&moved); /* Call release pages instead ?? */ >>>+ >>>+ if (err >= 0 && list_empty(&newlist) && !list_empty(pagelist)) >>>+ goto redo; >> >> >>Here, list_empty(&newlist) is needed ? >>For checking permanent failure case, list_empty(&failed) looks better. > > > We only allocate 256 pages which are on the newlist. If the newlist is > empty but there are still pages that could be migrated > (!list_empty(pagelist)) then we need to allocate more pages and call > migrate_pages() again. > > Ah, Okay. confirmation: 1. Because mm->sem is held, there is no page-is-truncated/freed case. 2. Because pages in pagelist are removed from zone's lru, kswapd and others will not find and unmap them. There is no page-is-swapedout-by-others case. So if all target pages are successfuly remvoed from pagelist, newlist must be empty. Right ? -- Kame - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/