Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp237210yba; Sat, 4 May 2019 01:08:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqybAMwjGuT3hwAftYqoydwmpXUpzSSoHoZjW+QMq/vS0A7R5dIZW864zMCT/KaY+jBq473i X-Received: by 2002:a17:902:29ab:: with SMTP id h40mr16979457plb.269.1556957294763; Sat, 04 May 2019 01:08:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556957294; cv=none; d=google.com; s=arc-20160816; b=w0ZwpLq5raOEexO9PevUMgzPEmsC5hAOysUBBV+g7dPzj1B4YGOq9VVGSMnnsIQFR6 7yeEa5wgKa0dy+Y1LWyCK8cIJp7oYNGy7nKKyU9KI6oFUbEIaascrZLBaTjB06JlJcuD P0AnpB9nK7PyckcbkJbFAX6gyMR0A+et8mRVDTK5oivvqwSJ9EC+cpKAwJgw31O+ronr MtsIggK2YT3EDef/aAkahd37xu7zcVo0c8N0zUBJGMQ6W2hZp7sHJ7VNunWTNgfBSG4q IgGzYfPQaiNCZJO+8VuznVTVlPk/c2kz7TtC3TXww0JrFgqo8JfB+s0zqfnVq/2SYier 9pKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=gqyA9w6RcMTkaC1wlrGYiIZtj1uy6ZoYFIu5t9JyriA=; b=ZOJIKI9V61RbY3soIreZQ1o6nq7ijSWPyxvB6FVoIHPDy/pRNpZiifHnNc0e+NFgvs HwJ4hG6lYQeTytW6FxXC7p3zaFKQTz6So5c0IA+D+R60AmjPmkGaydlzkDcZgS8Zp4Lv Jcza/iQEqI8O2j6zMC6l1KBwNv3AElobLsnsM+11gtqCPxiaIdKzDWUueI75+9zgTAFo ojtuI0LvdTdlmrA2kGoaHUoKYF92AW47gzt4TaNQ+uIS8N4OgdRMPcmKfFA58siQ26T/ pNUK8NH8orVOTupfhGGgKQc6lT4SI5zhSunpQbULq5zYusXFRs/KrtrcAqcVmfZy4P92 EdAw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=jPezRXAE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b2si6071734pgk.89.2019.05.04.01.07.58; Sat, 04 May 2019 01:08:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@netronome-com.20150623.gappssmtp.com header.s=20150623 header.b=jPezRXAE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726946AbfEDGyK (ORCPT + 99 others); Sat, 4 May 2019 02:54:10 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:43227 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726622AbfEDGyJ (ORCPT ); Sat, 4 May 2019 02:54:09 -0400 Received: by mail-pg1-f195.google.com with SMTP id t22so3802603pgi.10 for ; Fri, 03 May 2019 23:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=gqyA9w6RcMTkaC1wlrGYiIZtj1uy6ZoYFIu5t9JyriA=; b=jPezRXAEY669SQbZu/6bAvGUuYDGTH/MEjwYqbzwbVaAG/LALvOho6XqI9/tKuCg5k 97jvuYYHpxQPkb70kyY6+qdqEtzAjEuQYcTOC42IK2C9x4WepVk4XosPjIO7ltRo8XOM b6RZ5LuXsuLItHlqWK29Nk8bzZB+86OgAj+kE04Sk+XqwobHNUYQwdlOTPIRDNuSpEYc W9aIzubh2IsmMqbAC+toy0jGJ6XUgDUJnajqX4s6lGljxFDmvGm/PltFnkQJNeHj/d+v hTlrMbcn1l49qeJrjY0P2/urLIJ99auo+MI8B0BWmgqUu7Eb3EbvfXpf18tYYMwWDXqT kU5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=gqyA9w6RcMTkaC1wlrGYiIZtj1uy6ZoYFIu5t9JyriA=; b=uNTkFxOht8q7GRfDqhiL8acLNNhlJ8D5dJIvU6OkPYq/tpHQViv8SOMb0jr6A7/wiC zVZIWkxERLnySqMp/9ShpPL304Q3HSfK6n8+ZByogRiUtCOnn6W+WV/0ug1NJIQ5UGrP pvkjp7+6YgQG1VSqU4/D52dF7nF+GWJiYqJcNg+OcNq/66coumdytY4Yzw0UrXTOPTZ3 gn2sJiTBU0YgpMtpfojQn3qG1Wqnfxm09jINIzBiS7vd4eSpAbF9yENK9CUCV5MIN5aG 58M4CNK1AJ41k3pAudxp/89awa+knRgQpzJ0/++sOFwow91s6SSxHmuA8rtCNcNdbwGx sUcg== X-Gm-Message-State: APjAAAWdbps6iZDpZE+LFaPdgsmX7ahzDAgX5HVJAxL+EySj3fXuKMUA g9I0S3MZayF1oeNhqNnm1KbTmA== X-Received: by 2002:a62:3501:: with SMTP id c1mr17569232pfa.184.1556952849325; Fri, 03 May 2019 23:54:09 -0700 (PDT) Received: from cakuba.netronome.com (ip-184-212-224-194.bympra.spcsdns.net. [184.212.224.194]) by smtp.gmail.com with ESMTPSA id s20sm5434573pgs.39.2019.05.03.23.54.05 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 03 May 2019 23:54:09 -0700 (PDT) Date: Sat, 4 May 2019 02:53:53 -0400 From: Jakub Kicinski To: Maxime Chevallier Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Antoine Tenart , thomas.petazzoni@bootlin.com, gregory.clement@bootlin.com, miquel.raynal@bootlin.com, nadavh@marvell.com, stefanc@marvell.com, mw@semihalf.com, Russell King , linux-arm-kernel@lists.infradead.org, Saeed Mahameed Subject: Re: [PATCH net-next 0/4] net: mvpp2: cls: Add classification Message-ID: <20190504025353.74acbb6d@cakuba.netronome.com> In-Reply-To: <20190430131429.19361-1-maxime.chevallier@bootlin.com> References: <20190430131429.19361-1-maxime.chevallier@bootlin.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Apr 2019 15:14:25 +0200, Maxime Chevallier wrote: > Compared to the first submissions, the NETIF_F_NTUPLE flag was also > removed, following Saeed's comment. You should probably add it back, even though the stack only uses NETIF_F_NTUPLE for aRFS the ethtool APIs historically depend on the drivers doing a lot of the validation. The flag was added by: 15682bc488d4 ("ethtool: Introduce n-tuple filter programming support") your initial use of the flag was correct.