Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp339814yba; Sat, 4 May 2019 03:33:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqxTTJlTTvQvGxU6zCNMnyZairML468qQMmhft3+jALvDyyJJmb9xAcaEm1sURM84+bc3wQo X-Received: by 2002:a17:902:9a07:: with SMTP id v7mr17982467plp.291.1556966031283; Sat, 04 May 2019 03:33:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556966031; cv=none; d=google.com; s=arc-20160816; b=N/CBd8E2gTFmm08b25bwhg06BDOtsnnPsuad6QppE9i3amMcfUDAl7NjSmrbxMQ3yC Oa4tq3G0VOts1yygcqtV/DQ9ih2V+dGV+l8lPd6Y00WylMZtXoMT3DEXr4q1MkVV/8EO K8h5jAqTk1aKyoKBjkqMqPIBKhmd14zhavAs0hlzUs9rQrOL+/k5qse9V/joECxvfc59 /RgxEgzqG2enpop3hdu4RCwW9gXUjNDd90TkIiMnkWISlLrXWHZPzS6XOJut6tV78Vet /r43vdB4GQQlT0sZWsD9nrktoaZAcqqkuGisoXcBpjkF3OJqtgXxKzHlihb0IPhcLsDA Otcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:cc:subject:date:to :from; bh=1qpGwUHf+6l0dP3fvnD06gHj0S3TWsfULPQAPteBkU0=; b=dPT4ZIaejX2busW4j1WJjH/OZAbB8RrJ3M2i3Niip2N1VWPUSZYtYa1xuXoCEh3+60 s/Zy6xXSTYpA8tyTQ3hfLvPyynHjAEhmSKtzwlVLN6qmg5LVuRhGwCfwDwec2B1cvmL0 ORcBxLWAQ45/VfksggdWq8RD2YpWhBeeJav0loKnqQiXtZnJPSss3tfeOgzTF86QtIUW NdkrvBwVgQNbh2sXBTgsI2qEh7Vatq0LR17p2oZ336Cbk7/JoBLx/7Z8iXROy77Cbw6O NSI0V7gyDNjS0fmzyUEIMc5+Icsf7oSk7vo9yGhGDAno/FhcDvimmeFGWtDS3GkkNv9z zulA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cd3si7479825plb.98.2019.05.04.03.33.36; Sat, 04 May 2019 03:33:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727321AbfEDKZy (ORCPT + 99 others); Sat, 4 May 2019 06:25:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:48376 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727415AbfEDKZu (ORCPT ); Sat, 4 May 2019 06:25:50 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1ADD9ACC4; Sat, 4 May 2019 10:25:49 +0000 (UTC) From: NeilBrown To: Ulf Hansson , Chaotian Jing Date: Sat, 04 May 2019 20:24:56 +1000 Subject: [PATCH 1/4] mmc: mtk-sd: don't hard-code interrupt trigger type Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, thirtythreeforty@gmail.com Message-ID: <155696549653.8632.3279283591868841381.stgit@noble.brown> In-Reply-To: <155696540998.8632.5242582397805128125.stgit@noble.brown> References: <155696540998.8632.5242582397805128125.stgit@noble.brown> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When using devicetree for configuration, interrupt trigger type should be described in the dts file, not hard-coded in the C code. The mtk-sd silicon in the mt7621 soc uses an active-high interrupt and so cannot be used with the current code. So replace IRQF_TRIGGER_LOW with IRQF_TRIGGER_NONE. Also IRQF_ONESHOT is not needed - it is used for threaded interrupt handlers, and this driver does not used a threaded interrupt handler. So remove that setting. Signed-off-by: NeilBrown --- drivers/mmc/host/mtk-sd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c index 0798f0ba6d34..469d4a717175 100644 --- a/drivers/mmc/host/mtk-sd.c +++ b/drivers/mmc/host/mtk-sd.c @@ -2240,7 +2240,7 @@ static int msdc_drv_probe(struct platform_device *pdev) msdc_init_hw(host); ret = devm_request_irq(&pdev->dev, host->irq, msdc_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, pdev->name, host); + IRQF_TRIGGER_NONE, pdev->name, host); if (ret) goto release;