Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 4 May 2019 17:48:41 +0530
From:   Bharath Vedartham <linux.bhar@gmail.com>
To:     Michal Hocko <mhocko@kernel.org>
Cc:     akpm@linux-foundation.org, kirill.shutemov@linux.intel.com,
        vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm/huge_memory.c: Make __thp_get_unmapped_area static
Message-ID: <20190504121841.GA8142@bharath12345-Inspiron-5559>
References: <20190504102353.GA22525@bharath12345-Inspiron-5559>
 <20190504115446.GP29835@dhcp22.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190504115446.GP29835@dhcp22.suse.cz>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, May 04, 2019 at 07:54:46AM -0400, Michal Hocko wrote:
Hi Michal,

Thanks for having a look at the patch. 
> On Sat 04-05-19 15:53:54, Bharath Vedartham wrote:
> > __thp_get_unmapped_area is only used in mm/huge_memory.c. Make it
> > static.
> 
> Makes sense. Looks like an omission.
> 
> > Tested by building and booting the kernel.
> 
> Testing by git grep __thp_get_unmapped_area would give you a better
> picture. Build test migh not hit paths that are config specific and
> static aspect of a functions should not have any functionality related
> side effects AFAICS.
>  
I have made sure CONFIG_TRANSPARENT_HUGEPAGE was enabled before building
and booting the kernel. I have also grepped the entire kernel source for
__thp_get_unmapped_area to be very sure.
> > Signed-off-by: Bharath Vedartham <linux.bhar@gmail.com>
> 
> Acked-by: Michal Hocko <mhocko@suse.com>
> 
> > ---
> >  mm/huge_memory.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/mm/huge_memory.c b/mm/huge_memory.c
> > index 165ea46..75fe2b7 100644
> > --- a/mm/huge_memory.c
> > +++ b/mm/huge_memory.c
> > @@ -509,7 +509,7 @@ void prep_transhuge_page(struct page *page)
> >  	set_compound_page_dtor(page, TRANSHUGE_PAGE_DTOR);
> >  }
> >  
> > -unsigned long __thp_get_unmapped_area(struct file *filp, unsigned long len,
> > +static unsigned long __thp_get_unmapped_area(struct file *filp, unsigned long len,
> >  		loff_t off, unsigned long flags, unsigned long size)
> >  {
> >  	unsigned long addr;
> > -- 
> > 2.7.4
> > 
> 
> -- 
> Michal Hocko
> SUSE Labs

Thanks
Bharath