Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp740754yba; Sat, 4 May 2019 11:43:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqzzSmn1zJeVIsmEKm7Vzge/cAXFboCUoYi8HGuIYbz2H++uJPDMvPxJ952GW8VIt+Dc7gjJ X-Received: by 2002:a65:4006:: with SMTP id f6mr3982257pgp.47.1556995391269; Sat, 04 May 2019 11:43:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556995391; cv=none; d=google.com; s=arc-20160816; b=EPZh5Q192P2gGlFR/nzE3de98aZNKN6XKGyR7u2PevuteOVyRusiIXxP/WB3/naMZc eViVHNQlRPNL31CTbs4X9AuGMAeZtd4F6VXqTEwZ16ANCNuqkDC5qBFCh+OjoDdwGQYs +mbtwBN25xmFXoEZrEkyXXeq4qgg3PmyOc8/HO+8q/bnjyszQ+EuPrvxFGUkX4cK5aPr PdL2IL1qhI97iwVad6eIARKHYdIH9Z9mlFNH4uEy44Au/ZaC532eqHoeiO08WhzU1xmZ 6rVP/gyZKREftlb04TapAY2L/oADbw+iFlbbgFpmuYKMyFTE/rQqU1dDdHGbGGZMD9yA riNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=4sMfKD6BWHHY2w0leCFH8ILHNGcbbmFVkVvKPdVieNc=; b=TgOH1+wcwHh4OkfEJ6Xwh+zRAaEk6dPD+T4/bmzg1iEZ/Rgd0bmB9cADyHJnBlIghh 5fFc9tJhyLV1kMApGONlENqRgInYC7mpjybXWFOjmKhE7RFIuqejC99UNJMn3ThYAy0I K9UxFEP6Q10kHDgkA/e+zu/+uUT2BWKXSQEjG4CAACOXUt/JUIKWXKnSiyICvG0v2wwj VCj6Avk1icT0D18E2ol1m9hhjaIdAtTEfn4/5Mf0e7VPE7m5I4+SFgR5dXfHYYr9/Rj8 JMJPrJkcDIU9E2iY0gia9HGwjYwb81SjE5qypfva6nBONEBZphWtInPveXr9BG0c+f++ VPUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b=hxarlySS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 14si8694545pfy.57.2019.05.04.11.42.56; Sat, 04 May 2019 11:43:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lightnvm-io.20150623.gappssmtp.com header.s=20150623 header.b=hxarlySS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727874AbfEDSkL (ORCPT + 99 others); Sat, 4 May 2019 14:40:11 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:36511 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727413AbfEDSij (ORCPT ); Sat, 4 May 2019 14:38:39 -0400 Received: by mail-lj1-f196.google.com with SMTP id y8so7634159ljd.3 for ; Sat, 04 May 2019 11:38:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lightnvm-io.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4sMfKD6BWHHY2w0leCFH8ILHNGcbbmFVkVvKPdVieNc=; b=hxarlySSKrvW9s7uG9u1fIU9cGNTvxWsqqv5ikXOvS3MO579hnmYEU/umNLoGeFlyl 3b1iwcDzIFAP3Jl/owreGfLhII+TA99CUWyvLxIy+qEtnklNfvtxIF9D7Njdv+Zzcbjo l/3RVycxqsyLrrWfwwccNMkhZJ27/SNVUwFmdPdZ8E5ixWDdu/aXjl4UYR1ywEGw7bAP 0pNrQ9dWpNvVt+2WjOsORXL1uuYrbpMZ49Q/lnz+ObKGW2cYV/4d7OrN3Vrw/1ogTmFr Nl+daEBaPqcL3gaWtAPqYqdgS6eGSQR/ORnzr8zbPNe2zZOCWgc9q1s2yZ3mI+T26CVI oNow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4sMfKD6BWHHY2w0leCFH8ILHNGcbbmFVkVvKPdVieNc=; b=egZVyXKdQLZv2i1MDPRXzkisiO8RCTMGRgE/xqsjtJJCGyHP5BQ085BivTscrUBxy2 vanCwFyxecCetpGu+yNniRX9u+FzUt5VseT0Mge3/QKdynX7tN6z0DFxOoFFvAnATY/E IVtZ7UBoxK3kpX7ZNlHNtqVjMf718tnKY5Sis08hz1heQctVvrHjaHiJ80SygnfY4AYJ BDYEcy9dfm9XqTkjbas+c+ekDee+5KRJpY+yUWp6sq6/nu5tRGWJT3WYCvOXzaWLINv5 ME0IAJizeHkn59ItExWPCwIVIVNgpKaRmBQ1HVDRqse/P+kSpEx2NSr6qMyUj1/dTl4j sIxw== X-Gm-Message-State: APjAAAUPUSeZLdKGNSzf+MU9KNiYAEJIh+t58ZcXHOp84OpjBKjM6VYl sSgupvzIh8ZNnSxYRaNv1nQ9hw== X-Received: by 2002:a2e:7611:: with SMTP id r17mr2332585ljc.95.1556995117501; Sat, 04 May 2019 11:38:37 -0700 (PDT) Received: from skyninja.webspeed.dk (2-111-91-225-cable.dk.customer.tdc.net. [2.111.91.225]) by smtp.gmail.com with ESMTPSA id q21sm1050260lfa.84.2019.05.04.11.38.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 04 May 2019 11:38:36 -0700 (PDT) From: =?UTF-8?q?Matias=20Bj=C3=B8rling?= To: axboe@fb.com Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Marcin Dziegielewski , =?UTF-8?q?Matias=20Bj=C3=B8rling?= Subject: [GIT PULL 12/26] lightnvm: pblk: set propper line as data_line after gc Date: Sat, 4 May 2019 20:37:57 +0200 Message-Id: <20190504183811.18725-13-mb@lightnvm.io> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190504183811.18725-1-mb@lightnvm.io> References: <20190504183811.18725-1-mb@lightnvm.io> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Marcin Dziegielewski In current implementation of l2p recovery, when we are after gc and we have open line, we are not setting current data line properly (we set last line from the device instead of last line ordered by seq_nr) and in consequence, kernel panic and data corruption. Signed-off-by: Marcin Dziegielewski Reviewed-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-recovery.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/lightnvm/pblk-recovery.c b/drivers/lightnvm/pblk-recovery.c index 83b467b5edc7..017874e03253 100644 --- a/drivers/lightnvm/pblk-recovery.c +++ b/drivers/lightnvm/pblk-recovery.c @@ -844,6 +844,7 @@ struct pblk_line *pblk_recov_l2p(struct pblk *pblk) spin_unlock(&l_mg->free_lock); } else { spin_lock(&l_mg->free_lock); + l_mg->data_line = data_line; /* Allocate next line for preparation */ l_mg->data_next = pblk_line_get(pblk); if (l_mg->data_next) { -- 2.19.1