Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp783364yba; Sat, 4 May 2019 12:46:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqwqaTzky1QR+AnXZul94VkhVOtx0j4x0bHVyVzyT5GBRT1DxlJClZjapdlmWxIFT37Seq6y X-Received: by 2002:a63:a1a:: with SMTP id 26mr20331802pgk.11.1556999208238; Sat, 04 May 2019 12:46:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1556999208; cv=none; d=google.com; s=arc-20160816; b=plTa4godDD3gJXv1fbD4riDK/LUVDApkwed6U/YvhttE3cWegZ93EymQ2WMQ/OoEBA tJQdVcEol07RV+nyUfTXgHlS7M5sCuVNcwgy5M56euaS21HTvSb9pZqU5tPGhrvHtzC0 VzjddcvLl5ZGfpWI8hKA9kjZCfsJgBY3C7fWCu1ASj2lsZp+Xp3MO7oXaiBcBrVBa6F8 TpFV/Iw4/+MwMbdGGbs4r8jPbOGh9jQADDJwvUCh6Qlw9sP1ictutn+Vo3IPtQBKCRg0 jShCMO0oNcoku/6UROQDxa4YUWJiSUT1gi1VydM5Ga1JJ31eGsbouqtubvUFRQCOblwA lWxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=h/yx3uFbVDEUZuot1MMgvf7JBplzjfs1+Z2TlHwBvNc=; b=Q2HsGZXk5H456TFOW9gFv+Vk3f5ehqPB7epy1RvvVgFwWFeNEPyc3Y7am5L3Dl5v5G RbbeC/rmCxirNd46UDg/WVBq28XBR4PujID6+S+Qix21KAmRI4LtXsByQldZNEfZ2Kfk wvuCmITSEYtNIUNO+jb5VRaaWrCVz5QV6+q0nWNbc0Jls8ojdZvLH91/K390XB14o/BY 2sjGjoP58dNLNqSBLfQYdcwArcJCDLmWxMvRNA+Z9pVvM+24UYVgWim+r61+jgg+nbKX OFHTWr3/jx11/w6/Ooq+V2dR6yZtGI9cGuMnd7G51n1pPlk5I8Zbl5Vaw4IkPM9jHM4u LFKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b8si8207514pfd.55.2019.05.04.12.46.33; Sat, 04 May 2019 12:46:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727446AbfEDTZM (ORCPT + 99 others); Sat, 4 May 2019 15:25:12 -0400 Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:7749 "EHLO mail2-relais-roc.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726596AbfEDTZM (ORCPT ); Sat, 4 May 2019 15:25:12 -0400 X-IronPort-AV: E=Sophos;i="5.60,430,1549926000"; d="scan'208";a="381667713" Received: from abo-60-75-68.mrs.modulonet.fr (HELO hadrien) ([85.68.75.60]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 May 2019 21:25:10 +0200 Date: Sat, 4 May 2019 21:25:10 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Vatsala Narang cc: gregkh@linuxfoundation.org, hadess@hadess.net, hdegoede@redhat.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/7] staging: rtl8723bs: core: Remove return in void function. In-Reply-To: <20190504184358.25632-1-vatsalanarang@gmail.com> Message-ID: References: <20190504184358.25632-1-vatsalanarang@gmail.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -5828,8 +5822,6 @@ void survey_timer_hdl(struct timer_list *t) > > > exit_survey_timer_hdl: > - > - return; > } Are you sure that you compiled this code? I'm not sure that it is possible to have a label without a subsequent statement. julia