Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1158930yba; Sat, 4 May 2019 23:33:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqx8DXRh0yoX1omiq03IHfbojIJLA129amjxx1L2WMz7rhxxKxTEgAQ0Zs3A3vVFoXEQaCCH X-Received: by 2002:a17:902:1003:: with SMTP id b3mr23339197pla.306.1557037981245; Sat, 04 May 2019 23:33:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557037981; cv=none; d=google.com; s=arc-20160816; b=vW0hrFhtOp8reTZXC6zeg7aLHSl5X5FlJW2k0mNM8QoLA/hwOR5NCcjgNtOZcs2WnX hCLV4Q4O/JMlbnEsrDN35tjdYcDqZM7fyBImSdMcuIpRVePu1sCp3dXz0ho3VLCbM52b 0FNEE+6wgrL9Rph3Y6ZgQ+m7Ub9WJsUMJj0SGEtvFAWPXOwvKeQ+Oi9vPg999fPayS6X HcZaqKP0kAWAoDqHGmaYr1+Hc34pBSwRPgidAhriDqQPsuuQh0yF6nDhQ7WhNtpWF9Tj wGkgwqk2o0U1cYGyAMtIikX4cC5bb+EfPyPNl6FFo19ZGqjMQYm9M1owAL2jVmIJRPRZ 45gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:user-agent:in-reply-to :content-disposition:mime-version:references:subject:cc:to:from:date; bh=8EwNFv34fWSLggsHnjqFQBguFBJ5jdHzgfVuz88NR6M=; b=YJFehxI6lwdJENohBjxsGEfEdB+yAeGySZmWX5Q1W6PwuNaSOO12FGOZ2JnKx2HSTN vUU8ZLAmzXU9lWsiZ0NCmY5fkFr6lLh6Ob3TOWVPp3NYCCHxGII5lWeukHmMUB4wtT2I ttxzQgTFzwDTAtD4ycqLAtpPAQxT2Y8kvlYGrvUMjxUqYx2isO7lSvWu8Zx8DQjgOlji vgnzyzvqMqSWiraWuy3R0ryyPAzkcjrmibbI314EJGqI7MavtXSvDvE82Q7/F8yR22pQ R8AHSJ0LlYSSWKRTfQPFaEnZk/TBD+c43f1zVVJ9VuH9o6mdMdmVbeCY2Hiq9YukHbUI HynA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c15si1579607pgg.357.2019.05.04.23.32.45; Sat, 04 May 2019 23:33:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727312AbfEEGPo (ORCPT + 99 others); Sun, 5 May 2019 02:15:44 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:42232 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726237AbfEEGPm (ORCPT ); Sun, 5 May 2019 02:15:42 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x45670ic019407 for ; Sun, 5 May 2019 02:15:40 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2s9qttcb7n-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 05 May 2019 02:15:40 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 5 May 2019 07:15:38 +0100 Received: from b06cxnps3074.portsmouth.uk.ibm.com (9.149.109.194) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sun, 5 May 2019 07:15:31 +0100 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x456FUUd61079648 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 5 May 2019 06:15:30 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EB15F42042; Sun, 5 May 2019 06:15:29 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BE8ED42047; Sun, 5 May 2019 06:15:27 +0000 (GMT) Received: from rapoport-lnx (unknown [9.148.8.112]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Sun, 5 May 2019 06:15:27 +0000 (GMT) Date: Sun, 5 May 2019 09:15:26 +0300 From: Mike Rapoport To: Paul Burton Cc: Andrew Morton , Arnd Bergmann , Catalin Marinas , Geert Uytterhoeven , Greentime Hu , Guan Xuetao , Guo Ren , Helge Deller , Ley Foon Tan , Matthew Wilcox , Matt Turner , Michael Ellerman , Michal Hocko , Palmer Dabbelt , Richard Kuo , Richard Weinberger , Russell King , Sam Creasey , "x86@kernel.org" , "linux-alpha@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-hexagon@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-m68k@lists.linux-m68k.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-um@lists.infradead.org" , "nios2-dev@lists.rocketboards.org" Subject: Re: [PATCH 01/15] asm-generic, x86: introduce generic pte_{alloc,free}_one[_kernel] References: <1556810922-20248-1-git-send-email-rppt@linux.ibm.com> <1556810922-20248-2-git-send-email-rppt@linux.ibm.com> <20190502190310.voenw3pwgpelmdgw@pburton-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190502190310.voenw3pwgpelmdgw@pburton-laptop> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 19050506-0028-0000-0000-0000036A7624 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19050506-0029-0000-0000-00002429E811 Message-Id: <20190505061525.GC15755@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-05_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=831 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905050056 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 02, 2019 at 07:03:11PM +0000, Paul Burton wrote: > Hi Mike, > > On Thu, May 02, 2019 at 06:28:28PM +0300, Mike Rapoport wrote: > > +/** > > + * pte_free_kernel - free PTE-level user page table page > > + * @mm: the mm_struct of the current context > > + * @pte_page: the `struct page` representing the page table > > + */ > > +static inline void pte_free(struct mm_struct *mm, struct page *pte_page) > > +{ > > + pgtable_page_dtor(pte_page); > > + __free_page(pte_page); > > +} > > Nit: the comment names the wrong function (s/pte_free_kernel/pte_free/). Argh, evil copy-paste :) Thanks! > Thanks, > Paul > -- Sincerely yours, Mike.