Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1167646yba; Sat, 4 May 2019 23:48:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqwxPFQT9Hxp7Wo0z+IMVt6LO8bOGmKEoChCD9v0MokrCi5a8xDoJkc3LbBKps3jMyhl23Cv X-Received: by 2002:a62:1690:: with SMTP id 138mr23428174pfw.28.1557038922306; Sat, 04 May 2019 23:48:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557038922; cv=none; d=google.com; s=arc-20160816; b=b9yNTEjFKbv1NdEvVJZ/i4ibBFBAx2AFh7L72pyEVDdQX8cXX/9S+tOGXxMI041Gpf vbkds97Wt8iemV4lPktBHaZ2uu6hyV3hpj+NAmr6mpf0CvEO4HluBENCcOrpLntPC6Kg cnirB2H3w8qqp7OOccHhEIK/lhMpBjjTb03JkfVXxf+yOLhtolZfo6hI5qINW+9d4Juy sgm95ivssciqTObXz//BgvtDVPLawES4mYE/4iTjqin0j6oACcgKNPtXslRwmPTYlOy4 62WgHFUZg5IxKCwOWHQYAgn7QEfJCiVf33GAxHNjbPd0Qy4Jvpfm6n+oa0I3O7KZoNRU euYQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:user-agent:in-reply-to :content-disposition:mime-version:references:subject:cc:to:from:date; bh=Xgf9c/VM5+e8jUXWmaxOHQdyH47T5h91P8YCMZuKQ80=; b=pH9OG13lGLjZMKWpAgR5e78pyYktouPQypfidlZ44N68VL4C97CDB3/p78p2pbZUj+ /YddcdGiVC4tk68Q9vsYfva+wZwW3NDW7vVxEcJMIrHHck6l0HrKhl3EmZHgqNv72q7h k7ISVHxBZVuz8TRS1+6yV+Q4wJe9xAJ/7vVmJt28Bg3M1jUjsaIzfbym+Lesq88KSXuB t9k4ztmV45oUdAPm4XhTvGbSgQd3J+F7GnjWX5f1pxDErXJc6V05cCdWt7eC4t8EpXIq Cy4ofZgO9YaKVREDoTLDhUqVLNY4F49ThzKMpUFm6bTW0UaYyVqStrUWJsI6nNAWmUHV PSQg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i3si9989479pld.129.2019.05.04.23.48.27; Sat, 04 May 2019 23:48:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727367AbfEEGRy (ORCPT + 99 others); Sun, 5 May 2019 02:17:54 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:51556 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725873AbfEEGRx (ORCPT ); Sun, 5 May 2019 02:17:53 -0400 Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x4566wK6019261 for ; Sun, 5 May 2019 02:17:52 -0400 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2s9qttcd6t-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 05 May 2019 02:17:52 -0400 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 5 May 2019 07:17:50 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sun, 5 May 2019 07:17:42 +0100 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x456Hf6G48759002 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 5 May 2019 06:17:41 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 59F9EA405F; Sun, 5 May 2019 06:17:41 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2D3E4A4054; Sun, 5 May 2019 06:17:39 +0000 (GMT) Received: from rapoport-lnx (unknown [9.148.8.112]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Sun, 5 May 2019 06:17:39 +0000 (GMT) Date: Sun, 5 May 2019 09:17:37 +0300 From: Mike Rapoport To: Paul Burton Cc: Andrew Morton , Arnd Bergmann , Catalin Marinas , Geert Uytterhoeven , Greentime Hu , Guan Xuetao , Guo Ren , Helge Deller , Ley Foon Tan , Matthew Wilcox , Matt Turner , Michael Ellerman , Michal Hocko , Palmer Dabbelt , Richard Kuo , Richard Weinberger , Russell King , Sam Creasey , "x86@kernel.org" , "linux-alpha@vger.kernel.org" , "linux-arch@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-hexagon@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-m68k@lists.linux-m68k.org" , "linux-mips@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-um@lists.infradead.org" , "nios2-dev@lists.rocketboards.org" Subject: Re: [PATCH 08/15] mips: switch to generic version of pte allocation References: <1556810922-20248-1-git-send-email-rppt@linux.ibm.com> <1556810922-20248-9-git-send-email-rppt@linux.ibm.com> <20190502190945.rrrxfxo3rbhgc3cx@pburton-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190502190945.rrrxfxo3rbhgc3cx@pburton-laptop> User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 19050506-0028-0000-0000-0000036A763C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19050506-0029-0000-0000-00002429E828 Message-Id: <20190505061737.GD15755@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-05-05_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=2 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=812 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905050056 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 02, 2019 at 07:09:47PM +0000, Paul Burton wrote: > Hi Mike, > > On Thu, May 02, 2019 at 06:28:35PM +0300, Mike Rapoport wrote: > > MIPS allocates kernel PTE pages with > > > > __get_free_pages(GFP_KERNEL | __GFP_ZERO, PTE_ORDER) > > > > and user PTE pages with > > > > alloc_pages(GFP_KERNEL | __GFP_ZERO, PTE_ORDER) > > That bit isn't quite true - we don't use __GFP_ZERO in pte_alloc_one() & > instead call clear_highpage() on the allocated page. Not that I have a > problem with using __GFP_ZERO - it seems like the more optimal choice. > It just might be worth mentioning the change & expected equivalent > behavior. You are right, I'll fix the changelog. > Otherwise: > > Acked-by: Paul Burton Thanks. > Thanks, > Paul > -- Sincerely yours, Mike.