Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1203816yba; Sun, 5 May 2019 00:50:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqx/AiXGPEnHCrurM2qPNn6Uijk+jkrPcMNAF5Z3fkx//KH663+9NzAm5e5vEsXB4MqpoxyC X-Received: by 2002:a62:4e86:: with SMTP id c128mr23879834pfb.39.1557042644937; Sun, 05 May 2019 00:50:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557042644; cv=none; d=google.com; s=arc-20160816; b=nNKjsox6puLDUeW2+hJ2wqQtidkI9r3x9a7nECFJjKq9nfF3otmudQ9h2NR8kEHDzT xtOBv7IJVulLkfhFX1MNPJc1vuywh9Bf+3CrYCWqow52RNkODfnHlm3+ndyIpX98MIBl 9qDvsq+gYVHq4VQCmVGeMYNgtVOStDoGgTQSO7ro+fVJAP7o4Dl1FaOi0dmXQ+2oEqTC gqf7pzRsiYaJlHSKYTer3PKJjwNSjFmvRiyBxH/tgln8ydn2qzSwkHOP6HIMdQ9myipQ JPPDRUAXPXyX9noDLsFgWVRCQgw/qN2sycq3+JT6nG/q7B+UEMCqhT3xynUEWLO8By2m Q91w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :references:in-reply-to:date:cc:to:from:subject:message-id; bh=z+9YOB/uDXzAeUq23FqNYUcaOs+wVHMkATFvbVAJsK4=; b=MlIlKu1up4XWZ3j/5Q5LOqd12hEH+wurKJuOXaZtt5L9nHSmqJ/LIoLBaDveP+pzMi l13jA0Vnw4Qfs1hoFrgO5M6S4mNSp3I5gN5MshRB0BSxYUpVD0/TZgMZs9c+pxdxMLJw R0zs/WB8WK1sogTjOAP8/CUTJ7/n54ayqOmwEi4RXZ0ABYzYB449T+Reg30nEMK7smiT gjKUg3XHLM5fQkzUbAHKsOIYILELXabaQKuJYs8Z9f5Ps/Xmz1+AtwJAw4hui5QyJy9X LUtQBRqhg867HnjVUV6XIn0SP4Ci4P0f6JHqhEJc0CvutECurZAIgg4OxuImrIb8lF+q cgUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c10si10532173pgk.312.2019.05.05.00.50.28; Sun, 05 May 2019 00:50:44 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727472AbfEEHoY (ORCPT + 99 others); Sun, 5 May 2019 03:44:24 -0400 Received: from Mailgw01.mediatek.com ([1.203.163.78]:16973 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726524AbfEEHoY (ORCPT ); Sun, 5 May 2019 03:44:24 -0400 X-UUID: bca66897c5a5492c9a238fe0951bb677-20190505 X-UUID: bca66897c5a5492c9a238fe0951bb677-20190505 Received: from mtkcas35.mediatek.inc [(172.27.4.253)] by mailgw01.mediatek.com (envelope-from ) (mailgw01.mediatek.com ESMTP with TLS) with ESMTP id 720570531; Sun, 05 May 2019 15:43:55 +0800 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS33N1.mediatek.inc (172.27.4.75) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Sun, 5 May 2019 15:43:54 +0800 Received: from [10.17.3.153] (172.27.4.253) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Sun, 5 May 2019 15:43:53 +0800 Message-ID: <1557042233.18628.33.camel@mhfsdcap03> Subject: Re: [PATCH 1/4] mmc: mtk-sd: don't hard-code interrupt trigger type From: Chaotian Jing To: NeilBrown CC: Ulf Hansson , , , Date: Sun, 5 May 2019 15:43:53 +0800 In-Reply-To: <155696549653.8632.3279283591868841381.stgit@noble.brown> References: <155696540998.8632.5242582397805128125.stgit@noble.brown> <155696549653.8632.3279283591868841381.stgit@noble.brown> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-MTK: N Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2019-05-04 at 20:24 +1000, NeilBrown wrote: > When using devicetree for configuration, interrupt trigger type > should be described in the dts file, not hard-coded in the C code. > > The mtk-sd silicon in the mt7621 soc uses an active-high interrupt > and so cannot be used with the current code. > > So replace IRQF_TRIGGER_LOW with IRQF_TRIGGER_NONE. > > Also IRQF_ONESHOT is not needed - it is used for threaded interrupt > handlers, and this driver does not used a threaded interrupt handler. > So remove that setting. > > Signed-off-by: NeilBrown Reviewed-by:Chaotian Jing > --- > drivers/mmc/host/mtk-sd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c > index 0798f0ba6d34..469d4a717175 100644 > --- a/drivers/mmc/host/mtk-sd.c > +++ b/drivers/mmc/host/mtk-sd.c > @@ -2240,7 +2240,7 @@ static int msdc_drv_probe(struct platform_device *pdev) > msdc_init_hw(host); > > ret = devm_request_irq(&pdev->dev, host->irq, msdc_irq, > - IRQF_TRIGGER_LOW | IRQF_ONESHOT, pdev->name, host); > + IRQF_TRIGGER_NONE, pdev->name, host); > if (ret) > goto release; > > >