Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp1640641yba; Sun, 5 May 2019 10:35:30 -0700 (PDT) X-Google-Smtp-Source: APXvYqzdDuJUzEomidNqi7fiygr5u0OoG83yGm8alEYZzNPnCmj62On2/QA9U2iT5Pb2QhRlFzbf X-Received: by 2002:a63:6116:: with SMTP id v22mr26213551pgb.272.1557077730259; Sun, 05 May 2019 10:35:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557077730; cv=none; d=google.com; s=arc-20160816; b=lDNk09OcKef06wDzHlCS20AKi/GI8ol00MeVmBn5nOD4TsEZkt6chL/Sv9wXKye0JQ IRTKgCHm703ecFXOo5MMM2UFDaJU3VTtuzqpm5uXvlJ4kT4aRCg+iBR9nMUTzJjKtTKC esrruO8ueX4WdX0wxruDNY7qYAaNlyKQe78OTn+4RvlrMUTn6P6lU9Y64UnHNzi7ON2U upjESc3lWOZiG1wL/8aKpw48hvyDNRl0hfkePFs0Nb5Aab1sHkac9MqX70tzvubWoEp+ pKCs8QkqyTshUEEPGkuyacWE8MJe9/mGgt6swhmD5AwMBOJromoD4RqdynsYHj8h6rsx wk8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=2lDiKnesFW67vxdU/vRK6BfRH6ZdPU7ujNhehPyCDCs=; b=rF3yloIc11j4S0fzid6CnjQFC6SGyCWr6w0tV0Cvbt+3/PrJqmbUXuRhvo0RngOmWT nDu4CHGO7/idS3sEZjrgbhl6nPkC9cnfVLSNAXZkYjadq3L0MLsKoEsmV0+4UTiMyijI dARd7YfUE5hWPk1XdFxoIwLoDMeb2uux66mUuXqa3sD7UDyEHCcSb2EBPLM4AGQ6aQiG Opt+5h97mds3V1rE5V6pdqafy6W7abVss6LKY/YMMgMGlE6Tgt0Cl5m6ijXrlvNlq0kL m1XRVLGWamV5Kftzp7qBO03EJV46YA08+RwgQPr0P0SCliJNn3h9cNybN5veLE6lHpDE xSTw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 33si11372541pld.265.2019.05.05.10.35.14; Sun, 05 May 2019 10:35:30 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728058AbfEERdy (ORCPT + 99 others); Sun, 5 May 2019 13:33:54 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:52994 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726905AbfEERdx (ORCPT ); Sun, 5 May 2019 13:33:53 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d8]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 58E2014DA6480; Sun, 5 May 2019 10:33:53 -0700 (PDT) Date: Sun, 05 May 2019 10:33:52 -0700 (PDT) Message-Id: <20190505.103352.552893412554706513.davem@davemloft.net> To: christophe.leroy@c-s.fr Cc: leoyang.li@nxp.com, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org Subject: Re: [PATCH] net: ucc_geth - fix Oops when changing number of buffers in the ring From: David Miller In-Reply-To: References: X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 05 May 2019 10:33:53 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Christophe Leroy Date: Fri, 3 May 2019 13:33:23 +0000 (UTC) > When changing the number of buffers in the RX ring while the interface > is running, the following Oops is encountered due to the new number > of buffers being taken into account immediately while their allocation > is done when opening the device only. ... > This patch forbids the modification of the number of buffers in the > ring while the interface is running. > > Fixes: ac421852b3a0 ("ucc_geth: add ethtool support") > Cc: stable@vger.kernel.org > Signed-off-by: Christophe Leroy Applied and queued up for -stable.