Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v2 1/4] ftrace: Implement fs notification for
 preempt/irqsoff tracers
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Joel Fernandes <joel@joelfernandes.org>,
        Ingo Molnar <mingo@redhat.com>, linux-kernel@vger.kernel.org
References: <20190504164710.GA55790@google.com>
 <20190505223915.4569-1-viktor.rosendahl@gmail.com>
 <20190505190133.49b5ea46@oasis.local.home>
From:   Viktor Rosendahl <viktor.rosendahl@gmail.com>
Message-ID: <b415ea04-e078-a73c-3609-56fb195841c3@gmail.com>
Date:   Mon, 6 May 2019 01:54:04 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190505190133.49b5ea46@oasis.local.home>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 5/6/19 1:01 AM, Steven Rostedt wrote:
 > On Mon,  6 May 2019 00:39:15 +0200
 > Viktor Rosendahl <viktor.rosendahl@gmail.com> wrote:
 >
 >> Can you explain more precisely what you agree with?
 >>
 >> The general idea of being able to trace bursts of latencies?
 >
 > One thing I have an issue with the current approach is the use of the
 > trace file for this.

You mean that using fsnotify is kind of okayish but that it's confusing 
for the
user because only a subset of tracers would send the fsnotify event when the
trace file is updated?

 >
 > Hmm, what about adding a notifier to tracing_max_latency instead? And
 > do it not as a config option, but have it always enabled. It would send a
 > notification when it changes, and that only happens when there's a new
 > max latency. Would that work for you?


Yes, it seems to be OK since the tracing_max_latency is updated also
with the latest latency that exceeds the threshold when we are using
tracing_thresh. I will try to send a new version of the patch series
soon, with the modifications that have been discussed so far.

best regards,

Viktor