Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2203739yba; Mon, 6 May 2019 01:25:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqwegBsTJ8UAqms+kglT8jAhlh3F1PwQBDz/4q36GGV1D3HD2lGin2psCZd1w/MB2jB/82wi X-Received: by 2002:a17:902:7e04:: with SMTP id b4mr30693278plm.211.1557131148478; Mon, 06 May 2019 01:25:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557131148; cv=none; d=google.com; s=arc-20160816; b=zfg3XundmW0erH3Mg7kMYwtKMlE3RLTAz9u84I0PEAX/ZE2ETcQQTPYS2D8K/MLlaU VALFpOmozHTE0YEZ6LTommcZAcEOkBJdr8rtA7Eg4Jt3+4SDL4ssc4UrYiwfsGxjezyW w8wm5fHb23aDoCiO8Kyg42VhzBaqf0GrVbWAv5mxHNQWWjdd78J7jX/Sgrnq/2aX13CN 3ulit9eNqY9XHgmu8045ejVdp8Y3ldTQLbKmHsOYXDjlMvrBnJ50mpCj5t/whohEBc/c p8MXw5HlFk0x26LZrSD8zgjKo3T2zfVWxSK8MLs49OnoirahHKecrN/PXTbOO1jLqiRa kU5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=vjoumqlBjwKObxsJ7gZXvrd7BbdJ917YtB4r7plNY7Q=; b=tDDFJlmprHMvWz+jD0E2SkKAum/JJUuaS+KkJf68bn4vF4UZRvkIr1DSHgVCWe5Q+7 3EmiNCedMAcyYEDR7XhgtBXXwOel1q41MILO/4g/wZdwK+LAEz3cJTke6oD502KGyBl3 HcS6V20wD4Clqp84Dk3sggOJ7KatFyV5XeNcghR0gbnHn/vPjLxarOoyfieZCyQGzm2f 6ud2a5P+ornt4DX3oiu7RnAC3rTPR2rGgXq54Z0JEcPnSRbEc4Cz+r88kL4gjmVk5Fxe Nqpky7sGv1gQCV2HuUf9Lo7dECrx0y0h92QyC6z2f8njuzKVy82m5JICXMGMqJVU1XtQ y4Yg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a25si13475659pff.119.2019.05.06.01.25.33; Mon, 06 May 2019 01:25:48 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726542AbfEFIWm (ORCPT + 99 others); Mon, 6 May 2019 04:22:42 -0400 Received: from mga18.intel.com ([134.134.136.126]:16902 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725861AbfEFIWm (ORCPT ); Mon, 6 May 2019 04:22:42 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 May 2019 01:22:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,437,1549958400"; d="scan'208";a="137280310" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga007.jf.intel.com with ESMTP; 06 May 2019 01:22:38 -0700 Received: from andy by smile with local (Exim 4.92) (envelope-from ) id 1hNYtR-0007wx-FR; Mon, 06 May 2019 11:22:37 +0300 Date: Mon, 6 May 2019 11:22:37 +0300 From: Andy Shevchenko To: Frederick Lawler Cc: bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, mika.westerberg@linux.intel.com, lukas@wunner.de, keith.busch@intel.com, mr.nuke.me@gmail.com, liudongdong3@huawei.com, thesven73@gmail.com Subject: Re: [PATCH v2 1/9] PCI/AER: Cleanup dmesg logs Message-ID: <20190506082237.GH9224@smile.fi.intel.com> References: <20190503035946.23608-1-fred@fredlawl.com> <20190503035946.23608-2-fred@fredlawl.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190503035946.23608-2-fred@fredlawl.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 02, 2019 at 10:59:38PM -0500, Frederick Lawler wrote: > Cleanup dmesg logs. > @@ -1380,7 +1380,6 @@ static int aer_probe(struct pcie_device *dev) > > rpc = devm_kzalloc(device, sizeof(struct aer_rpc), GFP_KERNEL); > if (!rpc) { > - dev_printk(KERN_DEBUG, device, "alloc AER rpc failed\n"); > return -ENOMEM; > } When you will do a next version consider to drop no needed {} above. -- With Best Regards, Andy Shevchenko