Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2241841yba; Mon, 6 May 2019 02:21:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqwrOVOOskP8f7OPTj1p2EayiTPrpX1nr87fcOhvh4PStgAyytXppa5BeLDsAjR6uKUPUcCQ X-Received: by 2002:a65:5248:: with SMTP id q8mr14387508pgp.92.1557134483714; Mon, 06 May 2019 02:21:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557134483; cv=none; d=google.com; s=arc-20160816; b=YYj2MubLF0pAVmTLu/+3JiW0Pj8lrqQZd1UjlKwc+MVbAm9ugDtthCHFdiDx/g+mjv VAYmW7b7d8wrL7c0TWA+z5acOyZe/HEcuaxD/0X7uyd+y9Ki6XhMgYAcL1lwVmFVCj82 1oiXUw0KjFzPlaRYdVu4fS3qeYbICmR/BaCwdk/Yb53vxGwhllMbs/v2rgbW2nzWpsfE Gf99T88gvK5PRixe6najk3PZ5nyqspzMKUBvKwcmQ4rGEvg9tFk+xcny7I08rt3m9sAK Cges8LOmEn8nXQT/Ywiqah9SRtHDHWFy9g1usyivpypPQ9lQeRTA1h6qkqCEJRdr6eHm rRpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=/N7SUDa/gI8AZnczIXgTCi121TwWRxcH95NFsebJoxY=; b=DZRS4oHM+y0T8mzMH3QwEl7Q9bAr2E/t+oc1G24xbTlFADoZ0N0DVuarnLHu2C+cO2 wfZVme9j6YzlaxJZjfIG8CXypZwGUhVZubtQ+N6y3rbEdcKkumIQ4gcqu92aOJFIJfI+ L2Yu8YR1/ptWyV9m2Ez9DXqIhjE2bEwwc2GqYeD+Y3B+en7/B/WPbrgfotX/pQ+llTyb piHM717phfyoh6R8ZASsZnTBNrNPSlBZLNiaMapyMIcK1QhIrTk3YMZ0L/hDduvKJSLU FNw/3Tbf7aoaX25cbwjc/w4ypV/bXKZUs4k9PP0x0Rvqs765XlMghQtF2aWtKt+39CWB 5EHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=TJIaPdzn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 142si14955867pfu.129.2019.05.06.02.21.08; Mon, 06 May 2019 02:21:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=TJIaPdzn; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726544AbfEFJSd (ORCPT + 99 others); Mon, 6 May 2019 05:18:33 -0400 Received: from merlin.infradead.org ([205.233.59.134]:52806 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726533AbfEFJSc (ORCPT ); Mon, 6 May 2019 05:18:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=/N7SUDa/gI8AZnczIXgTCi121TwWRxcH95NFsebJoxY=; b=TJIaPdzn44sjScjIcJmc8VaFr G3iKS7JTjEmIu+R4wWpV2pQtT3CC6QjHGXOU5Hob2owR89vp6rVblnZLixvO/VGp5PYkpzcDPtEhJ M+JSC0Smbujz1NNzjz3vTEqHrIhv3eTsoEv7Vx1Y8B9jw9o4MEj8qCLr5oUZJ/95iBdODko18l+vg ahWcJkIzMjehXLdll2kW+tmpOiL4yqpfc6RvpG4iL4VogkoLgfbf4LptX4NO/zZEFjLDOprg8Ypee 1seJISgG0qjh9ftcZAwuwBNXVO7n0/H3RepxYxlSz2fuJSVjhFzinMpGyJ5T1QjATRL1KrmxFyTXr mR1iXhAEA==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNZlR-0006jg-0W; Mon, 06 May 2019 09:18:25 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id A45A0286AB2AC; Mon, 6 May 2019 11:18:23 +0200 (CEST) Date: Mon, 6 May 2019 11:18:23 +0200 From: Peter Zijlstra To: Qais Yousef Cc: Ingo Molnar , Steven Rostedt , linux-kernel@vger.kernel.org, Pavankumar Kondeti , Sebastian Andrzej Siewior , Uwe Kleine-Konig Subject: Re: [PATCH 4/7] sched: Add sched_load_rq tracepoint Message-ID: <20190506091823.GF2650@hirez.programming.kicks-ass.net> References: <20190505115732.9844-1-qais.yousef@arm.com> <20190505115732.9844-5-qais.yousef@arm.com> <20190506090859.GK2606@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190506090859.GK2606@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 06, 2019 at 11:08:59AM +0200, Peter Zijlstra wrote: > Also; I _really_ hate how fat they are. Why can't we do simple straight > forward things like: > > trace_pelt_cfq(cfq); > trace_pelt_rq(rq); > trace_pelt_se(se); > > And then have the thing attached to the event do the fat bits like > extract the path and whatnot. ARGH, because we don't export any of those data structures (for good reason).. bah I hate all this.