Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2255956yba; Mon, 6 May 2019 02:41:26 -0700 (PDT) X-Google-Smtp-Source: APXvYqxW/pf2ffMKV4JXWHRlNpFlXSdaxHceB/NOHeSsjWoj0JStEqlgUTXNaZVlsiUI/iusJyeE X-Received: by 2002:a63:6b49:: with SMTP id g70mr31116736pgc.340.1557135685923; Mon, 06 May 2019 02:41:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557135685; cv=none; d=google.com; s=arc-20160816; b=SE15n6s4DaF53JcOVesKbIpauet44ManNeJ0DNIA22OutDXUr3F0DXXNouN3/1n6MM zGVwDSkJgDEor1S7pJA6O36eKhMU1RBkk38MdX2+xyvd7pHYv6lTWlxoXvicV2PTD6vs pUrZyg8iG33cqxjbKRRRfS0/B/E+n0x3spVjdrUq7v+Wl46iY+ntB7buK6cWYvA6cNMZ B5h0C5vtVUAn1MAA5YfXMIKIbxjcErE5VCeREKLaNHSV2DPZbXudGktXeH3vBRCKT+Vf awBWGjLHUECqFXU1t4TVfbIvwYidkeIEzIebBNNO+iWthm/ezUqOOoTsqdpif0yRc5dW 2MuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=t+Uksr38qEQdnUktzf7iuzjMvop9CtHdm9Gzd+jY0qU=; b=RWFTXgC6e0te4Uq8ii5RPFU+usjNQS8lu3h26J+CKwcJozC/oXM10I7gyBPdOqfDZZ FGy6NpZ3yokJvbYXpLu0Oy5PvNVymAJzowlRw+HdALyrlZ3dandAXJZvg6aJv2sx/j3t rFd7fuab2F3YHle+MUmI40GSxByvKCrnKIqZ3CwWhQBL4EQg0jqaLlai1XzhEpbVYgeY recUb6tUlJ1+Y84Mj0S8XS1xfzT+viFZG9C7Mh8D9IXRP08u7mH19fk52oxuqdCkFeCY VTSwjIJD3YUQkoUCupxGCVNgN72+oCOIr0PhCcUpcmtPFJRdWvHDjhxermPfFkK9Pxs/ tHNg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GqPYYZv8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f2si15477294pln.360.2019.05.06.02.41.10; Mon, 06 May 2019 02:41:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=GqPYYZv8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726162AbfEFJkP (ORCPT + 99 others); Mon, 6 May 2019 05:40:15 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:45909 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725855AbfEFJkP (ORCPT ); Mon, 6 May 2019 05:40:15 -0400 Received: by mail-pg1-f196.google.com with SMTP id i21so6175685pgi.12; Mon, 06 May 2019 02:40:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t+Uksr38qEQdnUktzf7iuzjMvop9CtHdm9Gzd+jY0qU=; b=GqPYYZv8MSqHpuM/ukI6DRu1X76foSsRd3AxPs3L4Sw6YWhiMXWpcu5UokMWuCWCti /zJ+MrI+hHTR1Q6kcdZL4F9lAm3PC4SwtiC6a/Rsl09GnQVsBsFallrXRRqMhh3NxC2n R7Sw3Rhx5ikIxhjtkLYaSAwhmsWyJt7bj1TkHKaQP/Tip1KjbXK0jKI8g/lQEMMfP0Wk j5fTYEKfzaLMjP9UY9oaUAdmHP7/aVIiWihTrU4bGakR5EMv3WOo2A8xn+r9N1yFDF43 6qYrGGW+9uAakR70U6pkrbQdltWa4qavdVB4qAgJfLRTDoP7PRelHTs/prAXvQ2b/2zc FVyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t+Uksr38qEQdnUktzf7iuzjMvop9CtHdm9Gzd+jY0qU=; b=f81P6H1ebHo3Pu0XYYad9fYaezIj45fl/c7ijm5U/MJXUp9WS6QMrS9YlQUH+vsEkY j5VkExNA0JbjCiDrKROZdrR8TcPBv2ymCEQuAWTbpIDc2kN+dOMzmUy0XNs4sm0L/PZ+ fotpjkyed2IPwJjBG1i5ZhCyZLKcUHdETIdr+L6dphx1+2UPANv3a0jzrAdfWrXZKKwM of5SY7ToEDMePcjsuea4sSN/nz72jgKtgfkued9+szKP2KHFx9/jNq510HPj11L+Fppw 59ZOGAtRQq2kDaiUizxNLkgKpHVa6J4vNfENrklJD2ESRH8rJ8E4A2oZE6eBwUg6ABSg d61Q== X-Gm-Message-State: APjAAAXuv0ft7ROGAbLl18NkdahSN+HBSVxpXvjO1WHFhl1KBl5vrADt BA5J0FcDTc+UKc7tUNH1Om/xBujiFQUgYXiEgOY= X-Received: by 2002:a63:4621:: with SMTP id t33mr28149042pga.246.1557135614509; Mon, 06 May 2019 02:40:14 -0700 (PDT) MIME-Version: 1.0 References: <20190313222124.229371-1-rajatja@google.com> <20190417230155.5282-1-rajatja@google.com> <20190417230155.5282-3-rajatja@google.com> In-Reply-To: <20190417230155.5282-3-rajatja@google.com> From: Andy Shevchenko Date: Mon, 6 May 2019 12:40:03 +0300 Message-ID: Subject: Re: [PATCH v6 3/3] platform/x86: intel_pmc_core: Attach using APCI HID "INT33A1" To: Rajat Jain Cc: Rajneesh Bhardwaj , Vishwanath Somayaji , Darren Hart , Andy Shevchenko , Platform Driver , Linux Kernel Mailing List , Rafael J Wysocki , Srinivas Pandruvada , Furquan Shaikh , Evan Green , Rajat Jain Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 18, 2019 at 2:02 AM Rajat Jain wrote: > > Most modern platforms already have the ACPI device "INT33A1" that could > be used to attach to the driver. Switch the driver to using that and > thus make the intel_pmc_core.c a pure platform_driver. > > Some of the legacy platforms though, may still not have this ACPI device > in their ACPI tables. Thus for such platforms, move the code to manually > instantiate a platform_device into a new file of its own. This would > instantiate the intel_pmc_core platform device and thus attach to > the driver, if the ACPI device for the same ("INT33A1") is not present > in a system where it should be. This was discussed here: > https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1966991.html > Pushed to my review and testing queue, thanks! > Signed-off-by: Rajat Jain > --- > v6: Squash some of the changes of first patch into this patch to work > around the bisectability issue. > v5: Remove the gerrit id from commit log > v4: Rename file, remove dummy arg, 1 conditional per if statement, > simplify init / exit calls.. > v3: (first version of *this* patch -to go with rest of v3 patchset) > v2: (does not exist) > v1: (does not exist) > > drivers/platform/x86/Makefile | 2 +- > drivers/platform/x86/intel_pmc_core.c | 40 +++---------- > .../platform/x86/intel_pmc_core_plat_drv.c | 60 +++++++++++++++++++ > 3 files changed, 69 insertions(+), 33 deletions(-) > create mode 100644 drivers/platform/x86/intel_pmc_core_plat_drv.c > > diff --git a/drivers/platform/x86/Makefile b/drivers/platform/x86/Makefile > index 86cb76677bc8..7041a88c34c7 100644 > --- a/drivers/platform/x86/Makefile > +++ b/drivers/platform/x86/Makefile > @@ -89,7 +89,7 @@ obj-$(CONFIG_INTEL_BXTWC_PMIC_TMU) += intel_bxtwc_tmu.o > obj-$(CONFIG_INTEL_TELEMETRY) += intel_telemetry_core.o \ > intel_telemetry_pltdrv.o \ > intel_telemetry_debugfs.o > -obj-$(CONFIG_INTEL_PMC_CORE) += intel_pmc_core.o > +obj-$(CONFIG_INTEL_PMC_CORE) += intel_pmc_core.o intel_pmc_core_plat_drv.o > obj-$(CONFIG_PMC_ATOM) += pmc_atom.o > obj-$(CONFIG_MLX_PLATFORM) += mlx-platform.o > obj-$(CONFIG_INTEL_TURBO_MAX_3) += intel_turbo_max_3.o > diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c > index 1d902230ba61..f20d08ad39ea 100644 > --- a/drivers/platform/x86/intel_pmc_core.c > +++ b/drivers/platform/x86/intel_pmc_core.c > @@ -1023,47 +1023,23 @@ static const struct dev_pm_ops pmc_core_pm_ops = { > SET_LATE_SYSTEM_SLEEP_PM_OPS(pmc_core_suspend, pmc_core_resume) > }; > > +static const struct acpi_device_id pmc_core_acpi_ids[] = { > + {"INT33A1", 0}, /* _HID for Intel Power Engine, _CID PNP0D80*/ > + { } > +}; > +MODULE_DEVICE_TABLE(acpi, pmc_core_acpi_ids); > + > static struct platform_driver pmc_core_driver = { > .driver = { > .name = "intel_pmc_core", > + .acpi_match_table = ACPI_PTR(pmc_core_acpi_ids), > .pm = &pmc_core_pm_ops, > }, > .probe = pmc_core_probe, > .remove = pmc_core_remove, > }; > > -static struct platform_device pmc_core_device = { > - .name = "intel_pmc_core", > -}; > - > -static int __init pmc_core_init(void) > -{ > - int ret; > - > - if (!x86_match_cpu(intel_pmc_core_ids)) > - return -ENODEV; > - > - ret = platform_driver_register(&pmc_core_driver); > - if (ret) > - return ret; > - > - ret = platform_device_register(&pmc_core_device); > - if (ret) { > - platform_driver_unregister(&pmc_core_driver); > - return ret; > - } > - > - return 0; > -} > - > -static void __exit pmc_core_exit(void) > -{ > - platform_device_unregister(&pmc_core_device); > - platform_driver_unregister(&pmc_core_driver); > -} > - > -module_init(pmc_core_init) > -module_exit(pmc_core_exit) > +module_platform_driver(pmc_core_driver); > > MODULE_LICENSE("GPL v2"); > MODULE_DESCRIPTION("Intel PMC Core Driver"); > diff --git a/drivers/platform/x86/intel_pmc_core_plat_drv.c b/drivers/platform/x86/intel_pmc_core_plat_drv.c > new file mode 100644 > index 000000000000..20be3eaeb722 > --- /dev/null > +++ b/drivers/platform/x86/intel_pmc_core_plat_drv.c > @@ -0,0 +1,60 @@ > +// SPDX-License-Identifier: GPL-2.0 > + > +/* > + * Intel PMC Core platform init > + * Copyright (c) 2019, Google Inc. > + * Author - Rajat Jain > + * > + * This code instantiates platform devices for intel_pmc_core driver, only > + * on supported platforms that may not have the ACPI devices in the ACPI tables. > + * No new platforms should be added here, because we expect that new platforms > + * should all have the ACPI device, which is the preferred way of enumeration. > + */ > + > +#include > +#include > + > +#include > +#include > + > +static struct platform_device pmc_core_device = { > + .name = "intel_pmc_core", > +}; > + > +/* > + * intel_pmc_core_platform_ids is the list of platforms where we want to > + * instantiate the platform_device if not already instantiated. This is > + * different than intel_pmc_core_ids in intel_pmc_core.c which is the > + * list of platforms that the driver supports for pmc_core device. The > + * other list may grow, but this list should not. > + */ > +static const struct x86_cpu_id intel_pmc_core_platform_ids[] = { > + INTEL_CPU_FAM6(SKYLAKE_MOBILE, pmc_core_device), > + INTEL_CPU_FAM6(SKYLAKE_DESKTOP, pmc_core_device), > + INTEL_CPU_FAM6(KABYLAKE_MOBILE, pmc_core_device), > + INTEL_CPU_FAM6(KABYLAKE_DESKTOP, pmc_core_device), > + INTEL_CPU_FAM6(CANNONLAKE_MOBILE, pmc_core_device), > + INTEL_CPU_FAM6(ICELAKE_MOBILE, pmc_core_device), > + {} > +}; > +MODULE_DEVICE_TABLE(x86cpu, intel_pmc_core_platform_ids); > + > +static int __init pmc_core_platform_init(void) > +{ > + /* Skip creating the platform device if ACPI already has a device */ > + if (acpi_dev_present("INT33A1", NULL, -1)) > + return -ENODEV; > + > + if (!x86_match_cpu(intel_pmc_core_platform_ids)) > + return -ENODEV; > + > + return platform_device_register(&pmc_core_device); > +} > + > +static void __exit pmc_core_platform_exit(void) > +{ > + platform_device_unregister(&pmc_core_device); > +} > + > +module_init(pmc_core_platform_init); > +module_exit(pmc_core_platform_exit); > -- > 2.21.0.392.gf8f6787159e-goog > -- With Best Regards, Andy Shevchenko