Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190429150135.15070-1-hdegoede@redhat.com>
In-Reply-To: <20190429150135.15070-1-hdegoede@redhat.com>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Mon, 6 May 2019 15:38:50 +0300
Message-ID: <CAHp75VeE=88mCcgVx3Y3PQJPQ819Z7=3s=jRGz1y=t09phk=rA@mail.gmail.com>
Subject: Re: [PATCH] platform/x86: pmc_atom: Add Lex 3I380D industrial PC to
 critclk_systems DMI table
To:     Hans de Goede <hdegoede@redhat.com>,
        Stephen Boyd <sboyd@kernel.org>
Cc:     Darren Hart <dvhart@infradead.org>,
        Andy Shevchenko <andy@infradead.org>,
        Kai Heng Feng <kai.heng.feng@canonical.com>,
        Platform Driver <platform-driver-x86@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Semyon Verchenko <semverchenko@factor-ts.ru>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Apr 29, 2019 at 6:01 PM Hans de Goede <hdegoede@redhat.com> wrote:
>
> The Lex 3I380D industrial PC has 4 ethernet controllers on board
> which need pmc_plt_clk0 - 3 to function, add it to the critclk_systems
> DMI table, so that drivers/clk/x86/clk-pmc-atom.c will mark the clocks
> as CLK_CRITICAL and they will not get turned off.
>

Acked-by: Andy Shevchenko <andy.shevchenko@gmail.com>
supposedly to go via CLK tree.

P.S. If you want it through PDx86, I need immutable branch / tag from CLK.

> Fixes: 648e921888ad ("clk: x86: Stop marking clocks as CLK_IS_CRITICAL")
> Reported-and-tested-by: Semyon Verchenko <semverchenko@factor-ts.ru>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/platform/x86/pmc_atom.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/platform/x86/pmc_atom.c b/drivers/platform/x86/pmc_atom.c
> index 3a635ea09b8a..2910845b7cdd 100644
> --- a/drivers/platform/x86/pmc_atom.c
> +++ b/drivers/platform/x86/pmc_atom.c
> @@ -407,12 +407,21 @@ static int pmc_dbgfs_register(struct pmc_dev *pmc)
>   */
>  static const struct dmi_system_id critclk_systems[] = {
>         {
> +               /* pmc_plt_clk0 is used for an external HSIC USB HUB */
>                 .ident = "MPL CEC1x",
>                 .matches = {
>                         DMI_MATCH(DMI_SYS_VENDOR, "MPL AG"),
>                         DMI_MATCH(DMI_PRODUCT_NAME, "CEC10 Family"),
>                 },
>         },
> +       {
> +               /* pmc_plt_clk0 - 3 are used for the 4 ethernet controllers */
> +               .ident = "Lex 3I380D",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "Lex BayTrail"),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "3I380D"),
> +               },
> +       },
>         { /*sentinel*/ }
>  };
>
> --
> 2.21.0
>


-- 
With Best Regards,
Andy Shevchenko