Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2487666yba; Mon, 6 May 2019 06:57:20 -0700 (PDT) X-Google-Smtp-Source: APXvYqyU8TFcWs9CKhCBKfI2LJaThkFa+hMO5cCnhIw+b52JEHB914RuWut+zz8/brCx8EvSFKe8 X-Received: by 2002:a62:2703:: with SMTP id n3mr9225423pfn.199.1557151040262; Mon, 06 May 2019 06:57:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557151040; cv=none; d=google.com; s=arc-20160816; b=VxD1iXp4idq2Bu5m9vG4TIKEN68ud38ln0bl0bn5hnvmFVuFlq62hOgArMZA4ColBX cKretI/ZAh9cVxKHXzq/8wcUb/1ne2RiB5biCCO33BgcrHHckdswXEo9/Y+/m6TGrVqy u8bvj5pXKdfoCBzZ+yVb7JoJdrQc/LzogOrhPl+bb77sTKh80lRZXRQnwaGDcffFK2Jw hLKV0N9dJvyyG3r+60cnvnmW8BoItFONjTb5aY5GcH8TtOh0iJPdI2pgjNlQjS6C13ae EfV+tEesh8vXDTH6MT4MKKFWR5lWpl7Sq93t+Zlv0LuyDy8hllDHUIXSqXScvVMYtsJP Io4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to; bh=AeIK39LBacbza1qaLejxFxtATaASlQOH1gfmxpq6O5Y=; b=mXE3dii8GFAdR6AyXhEIlOQYOHbHFgdB/C+/6A2raT2rM25/R2208HGq/mnwyC7GyI mGajBE19+JlLhG6qYUyHAV5EgSROLKkMJPPo0kKopd7Fuf9gPCU7av+scCl0v3kovNEu djyE8GhHg4kSLqCpqr7Xg0Chg+4bNnUuDaQN9kVdIsgrFfPkqm+KaZv6W0rPgoC4iI2F iESzVJqF77kjpuiv2JY29rmMe9IQr4fGj/s3NHOn9lOVLNOo5hKKMhqYo0xK1gQLT0lO OBhHJ6VsTe07cgYwiu9xanDU28MqFKHZzACpvQ8S0Mzl65RDbOHR4RZry4EzTwZudYT4 F3bQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e3si14815692pgs.37.2019.05.06.06.57.02; Mon, 06 May 2019 06:57:20 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726381AbfEFNyH (ORCPT + 99 others); Mon, 6 May 2019 09:54:07 -0400 Received: from bilbo.ozlabs.org ([203.11.71.1]:38669 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726265AbfEFNyH (ORCPT ); Mon, 6 May 2019 09:54:07 -0400 Received: by ozlabs.org (Postfix, from userid 1034) id 44yPNY0bjTz9s7T; Mon, 6 May 2019 23:54:05 +1000 (AEST) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 6be6a8de1b55e719e3f95894910743719065d6a1 X-Patchwork-Hint: ignore In-Reply-To: <20190504070430.57008-1-weiyongjun1@huawei.com> To: Wei Yongjun , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Alastair D'Silva From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, kernel-janitors@vger.kernel.org, Wei Yongjun , linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] ocxl: Fix return value check in afu_ioctl() Message-Id: <44yPNY0bjTz9s7T@ozlabs.org> Date: Mon, 6 May 2019 23:54:05 +1000 (AEST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2019-05-04 at 07:04:30 UTC, Wei Yongjun wrote: > In case of error, the function eventfd_ctx_fdget() returns ERR_PTR() and > never returns NULL. The NULL test in the return value check should be > replaced with IS_ERR(). > > This issue was detected by using the Coccinelle software. > > Fixes: 060146614643 ("ocxl: move event_fd handling to frontend") > Signed-off-by: Wei Yongjun > Acked-by: Alastair D'Silva > Acked-by: Andrew Donnellan Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/6be6a8de1b55e719e3f9589491074371 cheers