Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2552299yba; Mon, 6 May 2019 07:55:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqyWYIrV5vA231p+ZkIbOnp3wY1bPLAt/c4oxIMCsMe9G1hnqTSLFPI7FNskmLxmgGatKOww X-Received: by 2002:a17:902:363:: with SMTP id 90mr25734113pld.131.1557154502698; Mon, 06 May 2019 07:55:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557154502; cv=none; d=google.com; s=arc-20160816; b=Thj+AlFqrK/2zf8Rd107h2qDou9AVvaF3dBgcetrcXpNTrzUh/XbTdzd+VwMY4Ep25 pKKm1FmkpvE/dzCUYY/RHfLKhuRyVOU6GVbGGVvVYvS65zq79EqwUhzyREf4DNqBnejg WOVzip/er6HwwmU1fChi3mqSrBybqU0ZA82LO8OIUbIwQn6vjG+6mbOpdD4gZFxGO14m TuY8rbY96e2mrO0bArfplKt+8yGCujW/D6XyUBSLh+sevXxhflI7sLh/7WbLs53HZYYb r4s/ldxZjqqkr6VnPF2OIpxxL0p9d5vnmBtnvkYkUTpE9qEsrYVYE2RM4OeTmCejDklC Vp0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=1FbQ6Ru81+ySF0itde6tDpMEjuaIwJiqOS6FkwEEFEE=; b=aZgiCwzDnXjo5KtL1vv/8j4lpiinVOJPGgmZDIIPiU23kQtiRWunnx24DKjsKXvq8N MgyX1zcaVzqYjD6klPS41fb/fqAp/OfePP6bAkL5FoXgaO+NRyci5WebyJHNilCCoMfS rttzQvaM1KhQWF4peXvOGZvhxrdYq+jHi0pcwQ2Fk64xaHUsPB6JDYfpc7fhuv1huO5p HluTAoPIXW8JYwmj/Gs+P9X1WzYo4NYFC9SBJKhijPMEBdp/3sy1lQUrojAtD57rpOaE tIrYts4sG1J0rEuO3l+rWb5i+Z5YDTapSU3V5nE4B6orxvyHz/CEOiBpteGpQauGYjLZ s1Rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=z2cR26MM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cg5si932661plb.47.2019.05.06.07.54.47; Mon, 06 May 2019 07:55:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=z2cR26MM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729240AbfEFOrL (ORCPT + 99 others); Mon, 6 May 2019 10:47:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:45864 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729000AbfEFOrI (ORCPT ); Mon, 6 May 2019 10:47:08 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4F7382053B; Mon, 6 May 2019 14:47:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557154027; bh=6OLcQgIjS7NVKbmeXUd0NWX6d9Ro1I2XL7AtRspSGts=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=z2cR26MMpEHiLRrSyPw+F+0hy3ZKAr1kr6KRjNU5xVXh+OX9Nn9ugz9dAxqZwr8iV w590LGCo1gOsfsgn6pprgra1GmM60o/IaEZIa2BlnODTdk4/okalAj9FzTsbfQ0PNZ 8fn6h8+nInwDdLE0L24sgSiRfM6UANU5RerF2Iwg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Mark Rutland , Laura Abbott , Will Deacon , Andrey Konovalov Subject: [PATCH 4.9 11/62] mm/kasan: Switch to using __pa_symbol and lm_alias Date: Mon, 6 May 2019 16:32:42 +0200 Message-Id: <20190506143052.072825443@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190506143051.102535767@linuxfoundation.org> References: <20190506143051.102535767@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Laura Abbott commit 5c6a84a3f4558a6115fef1b59343c7ae56b3abc3 upstream. __pa_symbol is the correct API to find the physical address of symbols. Switch to it to allow for debugging APIs to work correctly. Other functions such as p*d_populate may call __pa internally. Ensure that the address passed is in the linear region by calling lm_alias. Reviewed-by: Mark Rutland Tested-by: Mark Rutland Signed-off-by: Laura Abbott Signed-off-by: Will Deacon Signed-off-by: Andrey Konovalov Signed-off-by: Greg Kroah-Hartman --- mm/kasan/kasan_init.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) --- a/mm/kasan/kasan_init.c +++ b/mm/kasan/kasan_init.c @@ -15,6 +15,7 @@ #include #include #include +#include #include #include @@ -49,7 +50,7 @@ static void __init zero_pte_populate(pmd pte_t *pte = pte_offset_kernel(pmd, addr); pte_t zero_pte; - zero_pte = pfn_pte(PFN_DOWN(__pa(kasan_zero_page)), PAGE_KERNEL); + zero_pte = pfn_pte(PFN_DOWN(__pa_symbol(kasan_zero_page)), PAGE_KERNEL); zero_pte = pte_wrprotect(zero_pte); while (addr + PAGE_SIZE <= end) { @@ -69,7 +70,7 @@ static void __init zero_pmd_populate(pud next = pmd_addr_end(addr, end); if (IS_ALIGNED(addr, PMD_SIZE) && end - addr >= PMD_SIZE) { - pmd_populate_kernel(&init_mm, pmd, kasan_zero_pte); + pmd_populate_kernel(&init_mm, pmd, lm_alias(kasan_zero_pte)); continue; } @@ -92,9 +93,9 @@ static void __init zero_pud_populate(pgd if (IS_ALIGNED(addr, PUD_SIZE) && end - addr >= PUD_SIZE) { pmd_t *pmd; - pud_populate(&init_mm, pud, kasan_zero_pmd); + pud_populate(&init_mm, pud, lm_alias(kasan_zero_pmd)); pmd = pmd_offset(pud, addr); - pmd_populate_kernel(&init_mm, pmd, kasan_zero_pte); + pmd_populate_kernel(&init_mm, pmd, lm_alias(kasan_zero_pte)); continue; } @@ -135,11 +136,11 @@ void __init kasan_populate_zero_shadow(c * puds,pmds, so pgd_populate(), pud_populate() * is noops. */ - pgd_populate(&init_mm, pgd, kasan_zero_pud); + pgd_populate(&init_mm, pgd, lm_alias(kasan_zero_pud)); pud = pud_offset(pgd, addr); - pud_populate(&init_mm, pud, kasan_zero_pmd); + pud_populate(&init_mm, pud, lm_alias(kasan_zero_pmd)); pmd = pmd_offset(pud, addr); - pmd_populate_kernel(&init_mm, pmd, kasan_zero_pte); + pmd_populate_kernel(&init_mm, pmd, lm_alias(kasan_zero_pte)); continue; }