Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2554334yba; Mon, 6 May 2019 07:57:11 -0700 (PDT) X-Google-Smtp-Source: APXvYqz2ED2g5FXeunwnQgIAFUgjzo2vPJemXxPSOQ9oNWZQuVLbMK9f3qgsTh9p5Gl0i0O0GwPZ X-Received: by 2002:a63:c10d:: with SMTP id w13mr32092168pgf.311.1557154631850; Mon, 06 May 2019 07:57:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557154631; cv=none; d=google.com; s=arc-20160816; b=FHK7Oq65i435GxFl4s8oH3Dpa8/vvOexNe1cgl1t99jSY2qRBL85jkklnvS6GUyWTG mqo4lCK8Qlt4gGuY/VOtpQS9kxZ6LtX27Py4MNXv9aqO+WMAW8d8/Almil8elEnH/Y/Q TIEflJB7OQYVUVU42r4C/eM17Tu99lyCk7ALTeWqfoCE1BIXN/KkPSA4CXfnVchN96bM 8sYLiD1zBkxPNr8YBgz7mooo5elq4IB7SAEp4zk4uM0jkik9U84oqL97N3KYP1Eubx2R fOBjju60K/v4zc8JL/X16caKVqE5pl1pCxa30jIzD4l259asN1jhiG9g3df+zCcuEzhW ui7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TeYaOQHAZismgYFjJ4WcRrDrdmPmT5TP/gDnmJ88mnI=; b=lOLpdf3J+db6Tobi+VQX3zPd5TT66aOGIhcXu3enQG80W1sNQD0r5wr0YAIM8AtX9p LdWrlpyfSfriB+BQxIMbw8jMcrv5+iB4NMqQICVWZKoDAtbxSifbw3C6twHyJAylskUd X8QEerxHZBOfAdeFeEgFhvD2vjKOMdJbWTMe935rTMOEf2ABFZaDL7yOfHJe8Ug5IvAT l6GMN6XTG3t1bB4R2nYoON+fHox69qNV2mB3+ao85/OXJEGHk/0qVTCNtLdzyzyGsn7t r5XIV1/VPGyDGcq5AAwwj5y/PizPnfy9h3mCjS/yi/fBlMXLsjUyFDZIZ/MclgREen7t yE4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EPZYl51X; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d18si15380709pgi.335.2019.05.06.07.56.55; Mon, 06 May 2019 07:57:11 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EPZYl51X; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728706AbfEFOp1 (ORCPT + 99 others); Mon, 6 May 2019 10:45:27 -0400 Received: from mail.kernel.org ([198.145.29.99]:42262 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726160AbfEFOp0 (ORCPT ); Mon, 6 May 2019 10:45:26 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 64AFB20C01; Mon, 6 May 2019 14:45:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557153925; bh=VX+PH9WvdYe+f667jeOvjW4CpVmd7nBwhf1vYWuPd/8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EPZYl51XEqUsbWFBmP3B5WacLzcFikRGs5oUJJrM3T/ge8eSLae/JBijhYaoLhorM i47g0qObNSOQLgdbxt4f302z5VDTQxIOWR279ulH532ctEa2ukTI9jAJenso42/zn4 nMbCdt8DW8LDf1ocRRNW90RF0m+GjHHGwWMGze7U= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vasundhara Volam , Michael Chan , "David S. Miller" Subject: [PATCH 4.14 08/75] bnxt_en: Free short FW command HWRM memory in error path in bnxt_init_one() Date: Mon, 6 May 2019 16:32:16 +0200 Message-Id: <20190506143053.980658045@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190506143053.287515952@linuxfoundation.org> References: <20190506143053.287515952@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Vasundhara Volam [ Upstream commit f9099d611449836a51a65f40ea7dc9cb5f2f665e ] In the bnxt_init_one() error path, short FW command request memory is not freed. This patch fixes it. Fixes: e605db801bde ("bnxt_en: Support for Short Firmware Message") Signed-off-by: Vasundhara Volam Signed-off-by: Michael Chan Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -8241,6 +8241,7 @@ init_err_cleanup_tc: bnxt_clear_int_mode(bp); init_err_pci_clean: + bnxt_free_hwrm_short_cmd_req(bp); bnxt_free_hwrm_resources(bp); bnxt_cleanup_pci(bp);