Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2556106yba; Mon, 6 May 2019 07:59:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqzGwJdAKax/czL21OoeuZ6+GnlsdWCQmDxC3w1q3puWQ1/B82/RDFgiSk8RreeSChJaWh/x X-Received: by 2002:a17:902:4183:: with SMTP id f3mr24750184pld.63.1557154742128; Mon, 06 May 2019 07:59:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557154742; cv=none; d=google.com; s=arc-20160816; b=Yikvm6Kt6iLJqxlkkPsBbQSIuHdvSt6VkyIek1/RGALXHUUrzsrWB+UkU1C33DybgV TqEyVSiADX3KfOM9LcEC6xURlt5Vx0/O6IXSdn12l16wlZrfFy5ZlGuMcy0SZiJTQS8e EWsYE9WF5utrA2vij+30DvwUykt4lZmSWNKZiByBudjwPPYlr1p9m7tS9SRto5ep2rua oFrPl+cIC4NeOygfLUv+0WPR7X31CH5n04aY0Ou65afb9bMh4AK5v1TAS2H4k/K0ZJWU pZbfpbj23refC172BYAQAJkxChQWoycU19f/DFGbJgKCxOJfLh7fSDR0ED9UgsAK6OMJ YEYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bkvAzap5dy7NzsUCU2Y90AgETcc+80uJJlcRKITMDY8=; b=PtFpkW3VJrqFDOfQdkRv80Atmke8U2I0Kp1iAQY422pbKjW+Zo6f4zD2wBseJxkhq2 xKByECdqbLOCxsh/pKlFu5q8KzYIi0ON4HIs5bWdwD0AypXKZXlP1ekMRwIl4465qN3x gtuy8NMBlOXDuE1gZCpWLNeGP/gJdFi9Lb/m+iEvUx4qztXd+B9js0TSdhSuRtyNuipR zM9Rfp41yDBpDFAAicGzjujnRbAHPkVNm7PRftAAWfrdNrw2Rfxd4ZdY4l407rImxKei 7YY8oVdmqKoOtnuRccMLYo/zK0JYT2HIL0xFr5Hegy2xhQDQ8Lgcf4lt9MLynqSPE+nj TtPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KAqJ48Qm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t30si13747709pgk.496.2019.05.06.07.58.46; Mon, 06 May 2019 07:59:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=KAqJ48Qm; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728811AbfEFO4o (ORCPT + 99 others); Mon, 6 May 2019 10:56:44 -0400 Received: from mail.kernel.org ([198.145.29.99]:41454 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728466AbfEFOo5 (ORCPT ); Mon, 6 May 2019 10:44:57 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5F7C12087F; Mon, 6 May 2019 14:44:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557153896; bh=RlmniEJwBXOW+NjN3pyjmupFRydJ9KjlAVSH+e0+/Do=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KAqJ48Qm5OInN9+OP/4VUlhW68/37tAQz/IDAaGgatjPI4mFKQZw67HkV1bri1V30 eTaSny+mWKnNjQDsnF82g25wSe/KmLDa4V1fw8t46VNn7SXf2SZNO21ZnteP3WY2I6 sfPcfrnab+e0wgs7r00BXmanWRt7UkG40hHMA3XQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Aaro Koskinen , "David S. Miller" , Sasha Levin Subject: [PATCH 4.14 36/75] net: stmmac: ratelimit RX error logs Date: Mon, 6 May 2019 16:32:44 +0200 Message-Id: <20190506143056.491057244@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190506143053.287515952@linuxfoundation.org> References: <20190506143053.287515952@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 972c9be784e077bc56472c78243e0326e525b689 ] Ratelimit RX error logs. Signed-off-by: Aaro Koskinen Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index ecf3f8c1bc0e..0f85e540001f 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -3413,9 +3413,10 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue) * ignored */ if (frame_len > priv->dma_buf_sz) { - netdev_err(priv->dev, - "len %d larger than size (%d)\n", - frame_len, priv->dma_buf_sz); + if (net_ratelimit()) + netdev_err(priv->dev, + "len %d larger than size (%d)\n", + frame_len, priv->dma_buf_sz); priv->dev->stats.rx_length_errors++; break; } @@ -3473,9 +3474,10 @@ static int stmmac_rx(struct stmmac_priv *priv, int limit, u32 queue) } else { skb = rx_q->rx_skbuff[entry]; if (unlikely(!skb)) { - netdev_err(priv->dev, - "%s: Inconsistent Rx chain\n", - priv->dev->name); + if (net_ratelimit()) + netdev_err(priv->dev, + "%s: Inconsistent Rx chain\n", + priv->dev->name); priv->dev->stats.rx_dropped++; break; } -- 2.20.1