Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 6 May 2019 17:10:26 +0200
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Andrey Ryabinin <aryabinin@virtuozzo.com>
Cc:     linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Dmitry Vyukov <dvyukov@google.com>,
        Alexander Potapenko <glider@google.com>,
        Andrey Konovalov <andreyknvl@google.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH 4.9 09/62] kasan: turn on
 -fsanitize-address-use-after-scope
Message-ID: <20190506151026.GA12193@kroah.com>
References: <20190506143051.102535767@linuxfoundation.org>
 <20190506143051.888762392@linuxfoundation.org>
 <6636d7cf-03fe-e253-f981-e07d75858b33@virtuozzo.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6636d7cf-03fe-e253-f981-e07d75858b33@virtuozzo.com>
User-Agent: Mutt/1.11.4 (2019-03-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, May 06, 2019 at 05:55:54PM +0300, Andrey Ryabinin wrote:
> 
> 
> On 5/6/19 5:32 PM, Greg Kroah-Hartman wrote:
> > From: Andrey Ryabinin <aryabinin@virtuozzo.com>
> > 
> > commit c5caf21ab0cf884ef15b25af234f620e4a233139 upstream.
> > 
> > In the upcoming gcc7 release, the -fsanitize=kernel-address option at
> > first implied new -fsanitize-address-use-after-scope option.  This would
> > cause link errors on older kernels because they don't have two new
> > functions required for use-after-scope support.  Therefore, gcc7 changed
> > default to -fno-sanitize-address-use-after-scope.
> > 
> > Now the kernel has everything required for that feature since commit
> > 828347f8f9a5 ("kasan: support use-after-scope detection").  So, to make it
> > work, we just have to enable use-after-scope in CFLAGS.
> > 
> > Link: http://lkml.kernel.org/r/1481207977-28654-1-git-send-email-aryabinin@virtuozzo.com
> > Signed-off-by: Andrey Ryabinin <aryabinin@virtuozzo.com>
> > Acked-by: Dmitry Vyukov <dvyukov@google.com>
> > Cc: Alexander Potapenko <glider@google.com>
> > Cc: Andrey Konovalov <andreyknvl@google.com>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
> > Signed-off-by: Andrey Konovalov <andreyknvl@google.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > 
> > ---
> >  scripts/Makefile.kasan |    2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > --- a/scripts/Makefile.kasan
> > +++ b/scripts/Makefile.kasan
> > @@ -29,6 +29,8 @@ else
> >      endif
> >  endif
> >  
> > +CFLAGS_KASAN += $(call cc-option, -fsanitize-address-use-after-scope)
> > +
> >  CFLAGS_KASAN_NOSANITIZE := -fno-builtin
> >  
> >  endif
> > 
> > 
> 
> This shouldn't be in the -stable.

Why not?  Does no one use gcc7 with this kernel and kasan?

thanks,

greg k-h