Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp2871622yba; Mon, 6 May 2019 12:59:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqzfG1pQ/iBX+f8aJ8deEi7YSC3768QCl9Cvk6GIglgLuTaGGsGSYHbRCVLzbOMiZatY3MBv X-Received: by 2002:a62:5a42:: with SMTP id o63mr37475709pfb.170.1557172763014; Mon, 06 May 2019 12:59:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557172763; cv=none; d=google.com; s=arc-20160816; b=mudguWdPafxowloDX56mlfzn2/9LQe8nBsu9OVjseC/3Qb66PnSl5MK1ga4wBDQF3/ 6Y5fxFh5QCeQrImOR6qcjAJ/JMKPkAjHc0PSFnfj5kCywCsUlNmsXJKAE3DZdiA2GEqM Hm/Cz1jz9QKIH00HgiNUnhHlmBvmLEEFd2xESIYnpZggthuHXGuHhzYmVzhe7pXaxSms 2Qoq1tzp6SIdf6lYaGTh1UFhULOtUKKpEKWNo+UtbSJrH3SfTHu3JU+sVWjy4troBFZC b+JydGg/45jtUNTiLdMvnkhPmvHDarDq7P56hB4zC2XHez109pTtAdlCtBvK25YD2Gu4 QBlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=IapbnG17HnRAI+fgjIuaulp9CMBvFm3VLGbRmGWF4E0=; b=GqPdf5feX8BmL4jVKgErxoJhzynNvBoHd3GZ4uI6NCIxbpOrp42r7W2gMf4ITiMIGG z9DY61FuhJAzF2djEPHSi0Dow79QrosPOCGkN5lqBPJcRhZhHIwN8+2BjmR2GB0byXz5 vs9y7KzZDo2PCCZNsZ1+sDz0E7S3chIEy06DrlqgXiB7w6bLwjBe0X4iAmuye3wQUgWA 6z54qeMxmz71UZW8IeEchdwBec2u91ZQCxEUWakp7jW81SHwcJm3H5cYFybRMmo80i+e /pbn8wfn8ZP5EWXJzg4Q7zozcM/DyAYG2Q62K1qDXulobAqjHK3q2ynEjliwbwArvGhg CG/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=kh3j8pze; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q14si1701211pls.327.2019.05.06.12.59.07; Mon, 06 May 2019 12:59:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ziepe.ca header.s=google header.b=kh3j8pze; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726403AbfEFT5A (ORCPT + 99 others); Mon, 6 May 2019 15:57:00 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:44831 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726201AbfEFT5A (ORCPT ); Mon, 6 May 2019 15:57:00 -0400 Received: by mail-qt1-f193.google.com with SMTP id f24so5885095qtk.11 for ; Mon, 06 May 2019 12:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=IapbnG17HnRAI+fgjIuaulp9CMBvFm3VLGbRmGWF4E0=; b=kh3j8pzeyTDmGdBdKT2t6wK4qJrWUxjJXhSIbeCddOyLk5cEpXkW4F9N9u/+Cu+JYe CcD+9uc4Qg7Zmm+P86rKLNxNIuzFyN0OzWfKQtI2x4PixE0FH3kFcVFuPlLo/Ompqdu9 w7+GVG9UeA0IbgDDhWr88xyWm4uNLGrNLbYpVGiEWxcRPBo++VUOVJcu47sjlyVVwUeI /0fW1+foLI2m//cXq3yGitHMCceBcv6YhtnWyMBhfj3Qw3RiebMP5Bu1VTQl8/Uonzn0 1GwiYltb3AemZiK8e09/6Yi5+nA1kCdB43L1rD1DxX+XJ+3W+eo5S6qX5BUXHAcD2WAl qG1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=IapbnG17HnRAI+fgjIuaulp9CMBvFm3VLGbRmGWF4E0=; b=PQh54ZZcwTCAP/Fwl60FuRmDJl0TOFVrYzrmZEJuuTM8LWVy2UZaAp+mCJq/WB5FIK wFVj69yamsACVKi1CiDFZmYk8u8NpoI7OlgZNXdMB+7UXjWGE6xNKEAHXg3B8X3/woPB 5bewdKzrjsvTy/X8vE7NUvKi04r8XgLhTWHAX4kyBBALH7FbLSAtjBoh+ejzNmZhDq1w MoBtu9rk7F4G27IS2zFnt7XRL0Lst+tgQy7iHZvZnugmU0F5q1+KvnnhbPsUfNKEtpIM e827sYscdnArxH3yXwmufooMAiFkxum3b6sThfLwyw4ZxiSXrNkbhS58obB4kF80eKg7 pa2g== X-Gm-Message-State: APjAAAUibRP/Mg1BVXyePawEhcFkKbhtEZYmUgPdUyPdjLful/kWOiEt DiU6YctflzL6y4pHUoB5oL28Ug== X-Received: by 2002:a0c:9ac8:: with SMTP id k8mr22216670qvf.132.1557172619424; Mon, 06 May 2019 12:56:59 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-49-251.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.49.251]) by smtp.gmail.com with ESMTPSA id h7sm5794217qkk.27.2019.05.06.12.56.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 May 2019 12:56:58 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hNjjN-0007sr-Dg; Mon, 06 May 2019 16:56:57 -0300 Date: Mon, 6 May 2019 16:56:57 -0300 From: Jason Gunthorpe To: jglisse@redhat.com Cc: linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org, Leon Romanovsky , Doug Ledford , Artemy Kovalyov , Moni Shoua , Mike Marciniszyn , Kaike Wan , Dennis Dalessandro Subject: Re: [PATCH v4 0/1] Use HMM for ODP v4 Message-ID: <20190506195657.GA30261@ziepe.ca> References: <20190411181314.19465-1-jglisse@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190411181314.19465-1-jglisse@redhat.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 11, 2019 at 02:13:13PM -0400, jglisse@redhat.com wrote: > From: Jérôme Glisse > > Just fixed Kconfig and build when ODP was not enabled, other than that > this is the same as v3. Here is previous cover letter: > > Git tree with all prerequisite: > https://cgit.freedesktop.org/~glisse/linux/log/?h=rdma-odp-hmm-v4 > > This patchset convert RDMA ODP to use HMM underneath this is motivated > by stronger code sharing for same feature (share virtual memory SVM or > Share Virtual Address SVA) and also stronger integration with mm code to > achieve that. It depends on HMM patchset posted for inclusion in 5.2 [2] > and [3]. > > It has been tested with pingpong test with -o and others flags to test > different size/features associated with ODP. > > Moreover they are some features of HMM in the works like peer to peer > support, fast CPU page table snapshot, fast IOMMU mapping update ... > It will be easier for RDMA devices with ODP to leverage those if they > use HMM underneath. > > Quick summary of what HMM is: > HMM is a toolbox for device driver to implement software support for > Share Virtual Memory (SVM). Not only it provides helpers to mirror a > process address space on a device (hmm_mirror). It also provides > helper to allow to use device memory to back regular valid virtual > address of a process (any valid mmap that is not an mmap of a device > or a DAX mapping). They are two kinds of device memory. Private memory > that is not accessible to CPU because it does not have all the expected > properties (this is for all PCIE devices) or public memory which can > also be access by CPU without restriction (with OpenCAPI or CCIX or > similar cache-coherent and atomic inter-connect). > > Device driver can use each of HMM tools separatly. You do not have to > use all the tools it provides. > > For RDMA device i do not expect a need to use the device memory support > of HMM. This device memory support is geared toward accelerator like GPU. > > > You can find a branch [1] with all the prerequisite in. This patch is on > top of rdma-next with the HMM patchset [2] and mmu notifier patchset [3] > applied on top of it. > > [1] https://cgit.freedesktop.org/~glisse/linux/log/?h=rdma-odp-hmm-v4 > [2] https://lkml.org/lkml/2019/4/3/1032 > [3] https://lkml.org/lkml/2019/3/26/900 Jerome, please let me know if these dependent series are merged during the first week of the merge window. This patch has been tested and could go along next week if the dependencies are met. Thanks, Jason