Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [U-Boot] [v4 PATCH] RISCV: image: Add booti support
To:     Karsten Merker <merker@debian.org>
Cc:     Atish Patra <atish.patra@wdc.com>, linux-kernel@vger.kernel.org,
        Tom Rini <trini@konsulko.com>, Alexander Graf <agraf@suse.de>,
        Anup Patel <anup@brainfault.org>,
        Bin Meng <bmeng.cn@gmail.com>,
        Boris Brezillon <boris.brezillon@bootlin.com>,
        Joe Hershberger <joe.hershberger@ni.com>,
        Lukas Auer <lukas.auer@aisec.fraunhofer.de>,
        Marek Vasut <marek.vasut@gmail.com>,
        Michal Simek <michal.simek@xilinx.com>,
        Rick Chen <rick@andestech.com>, Simon Glass <sjg@chromium.org>,
        u-boot@lists.denx.de
References: <20190506181134.9575-1-atish.patra@wdc.com>
 <251ea152-6407-02e2-076c-7ee377f6181d@gmx.de>
 <20190506203956.ty6gkmhm4dlylld4@excalibur.cnev.de>
From:   Heinrich Schuchardt <xypron.glpk@gmx.de>
Message-ID: <d1c63af6-e1e0-4ec3-e97a-4c3e9ec11623@gmx.de>
Date:   Mon, 6 May 2019 23:10:57 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <20190506203956.ty6gkmhm4dlylld4@excalibur.cnev.de>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 5/6/19 10:39 PM, Karsten Merker wrote:
> On Mon, May 06, 2019 at 10:06:39PM +0200, Heinrich Schuchardt wrote:
>> On 5/6/19 8:11 PM, Atish Patra wrote:
>>> This patch adds booti support for RISC-V Linux kernel. The existing
>>> bootm method will also continue to work as it is.
> [...]
>>> +	"boot arm64/riscv Linux Image image from memory", booti_help_text
>>
>> %s/Image image/image/
>>
>> "arm64/riscv" is distracting. If I am on RISC-V I cannot boot an ARM64
>> image here. Remove the reference to the architecture, please.
>
> Hello,
>
> I'm not sure about the last point - ISTR (please correct me if my
> memory betrays me here) that an arm64 U-Boot can in principle be
> used to boot either an arm64 or an armv7 kernel, but the commands
> are different in those cases (booti for an arm64 "Image" format
> kernel and bootz for an armv7 "zImage" format kernel), so having
> the information which kernel format is supported by the
> respective commands appears useful to me.  If the arm64 kernel
> image format would have a distinctive name (like "zImage" on
> armv7 or "bzImage" on x86) that would be less problematic, but
> with the confusion potential of "boot a Linux Image" (as in the
> arm64/riscv-specific "Image" format) vs "boot a Linux image" (as
> in generally some form of kernel image), I think explicitly
> mentioning the supported architectures makes sense.

In this case you have to ensure that only the *supported* architectures
are mentioned. RISC-V is not supported on ARM64.

Best regards

Heinrich