Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 6 May 2019 17:27:09 -0400
From:   Tom Rini <trini@konsulko.com>
To:     Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc:     Karsten Merker <merker@debian.org>,
        Atish Patra <atish.patra@wdc.com>,
        linux-kernel@vger.kernel.org, Alexander Graf <agraf@suse.de>,
        Anup Patel <anup@brainfault.org>,
        Bin Meng <bmeng.cn@gmail.com>,
        Boris Brezillon <boris.brezillon@bootlin.com>,
        Joe Hershberger <joe.hershberger@ni.com>,
        Lukas Auer <lukas.auer@aisec.fraunhofer.de>,
        Marek Vasut <marek.vasut@gmail.com>,
        Michal Simek <michal.simek@xilinx.com>,
        Rick Chen <rick@andestech.com>, Simon Glass <sjg@chromium.org>,
        u-boot@lists.denx.de
Subject: Re: [U-Boot] [v4 PATCH] RISCV: image: Add booti support
Message-ID: <20190506212709.GD31207@bill-the-cat>
References: <20190506181134.9575-1-atish.patra@wdc.com>
 <251ea152-6407-02e2-076c-7ee377f6181d@gmx.de>
 <20190506203956.ty6gkmhm4dlylld4@excalibur.cnev.de>
 <d1c63af6-e1e0-4ec3-e97a-4c3e9ec11623@gmx.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="8MGw1ILlV46eIqUv"
Content-Disposition: inline
In-Reply-To: <d1c63af6-e1e0-4ec3-e97a-4c3e9ec11623@gmx.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--8MGw1ILlV46eIqUv
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 06, 2019 at 11:10:57PM +0200, Heinrich Schuchardt wrote:
> On 5/6/19 10:39 PM, Karsten Merker wrote:
> >On Mon, May 06, 2019 at 10:06:39PM +0200, Heinrich Schuchardt wrote:
> >>On 5/6/19 8:11 PM, Atish Patra wrote:
> >>>This patch adds booti support for RISC-V Linux kernel. The existing
> >>>bootm method will also continue to work as it is.
> >[...]
> >>>+	"boot arm64/riscv Linux Image image from memory", booti_help_text
> >>
> >>%s/Image image/image/
> >>
> >>"arm64/riscv" is distracting. If I am on RISC-V I cannot boot an ARM64
> >>image here. Remove the reference to the architecture, please.
> >
> >Hello,
> >
> >I'm not sure about the last point - ISTR (please correct me if my
> >memory betrays me here) that an arm64 U-Boot can in principle be
> >used to boot either an arm64 or an armv7 kernel, but the commands
> >are different in those cases (booti for an arm64 "Image" format
> >kernel and bootz for an armv7 "zImage" format kernel), so having
> >the information which kernel format is supported by the
> >respective commands appears useful to me.  If the arm64 kernel
> >image format would have a distinctive name (like "zImage" on
> >armv7 or "bzImage" on x86) that would be less problematic, but
> >with the confusion potential of "boot a Linux Image" (as in the
> >arm64/riscv-specific "Image" format) vs "boot a Linux image" (as
> >in generally some form of kernel image), I think explicitly
> >mentioning the supported architectures makes sense.
>=20
> In this case you have to ensure that only the *supported* architectures
> are mentioned. RISC-V is not supported on ARM64.

The help should be re-worded to be both architecture agnostic and clear
that it is for the Linux Kernel 'Image' format images.

--=20
Tom

--8MGw1ILlV46eIqUv
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJc0KatAAoJEIf59jXTHXZS06wQAMJiT+a5vv3S5ScRWpC2NcYp
Zr1k+ddMgy31YS8htCujzgmgKJkxK3ZjdLMiDbzeRC/4r6FZ/E2r8jeU8wRo+39c
wdiC60MqLuQ2Z33KpZyox1JRniBra0nmVZwdItoUG1SXFcC50DWryhGH8pTBMja4
5moE9rBAo2W/cTQ+rCnYK32IRfTu17hhhJxu3ufv/aNkS4ofvnad/fw7nz38vE+4
HxQeNSvo0O411C2ZUlFo/i97Okv7BFwf1I2orfQhKusfpNZxOFl0QPayhDf1/BRV
RpYf3U742omDpH4nX07WFRP6wsa8hTY+n6rHPagAP0/M3aj4/LqxowMuWlV+2rp7
YFx9cwuxO8OxgBpF5YFdUMed/79OXwIZmvCTxYoY7dLetsMXmj7yBV7gXSRthzFt
TMgPIQDMfGhSk+Xn6EWMvID41okr4aeseIcWs5OGVYZJcVfuDGxiNwU7OKqE1wco
WGbLKuL8e4wlH/JBI6ZHlTPxIDgOUyHODE+FFejLfRmaF4AvmQOw6RT/Tuc6Qzqm
DYFaALNELpL4CUr6/yV8TqCJ6YyBSjT3W9VSwrWh/e3HH7/sjtp6fGcWI3puQa18
M70ZdZZrhl05LqPsyLS4Qv/gFpcGiqa3bBU195fKOjK6pghsZ+5MXG+vtOCgHw6n
fUu6+6tNKfSw1n6iEJfz
=cbu5
-----END PGP SIGNATURE-----

--8MGw1ILlV46eIqUv--