Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 7 May 2019 11:52:44 +1000
From:   Sam Bobroff <sbobroff@linux.ibm.com>
To:     Alex Williamson <alex.williamson@redhat.com>
Cc:     Greg Kurz <groug@kaod.org>, Alexey Kardashevskiy <aik@ozlabs.ru>,
        linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] vfio-pci/nvlink2: Fix potential VMA leak
References: <155568823785.601037.2151744205292679252.stgit@bahia.lan>
 <20190506155845.70f3b01d@x1.home>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="k+w/mQv8wyuph6w0"
Content-Disposition: inline
In-Reply-To: <20190506155845.70f3b01d@x1.home>
User-Agent: Mutt/1.9.3 (2018-01-21)
Message-Id: <20190507014915.GA10274@tungsten.ozlabs.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--k+w/mQv8wyuph6w0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, May 06, 2019 at 03:58:45PM -0600, Alex Williamson wrote:
> On Fri, 19 Apr 2019 17:37:17 +0200
> Greg Kurz <groug@kaod.org> wrote:
>=20
> > If vfio_pci_register_dev_region() fails then we should rollback
> > previous changes, ie. unmap the ATSD registers.
> >=20
> > Signed-off-by: Greg Kurz <groug@kaod.org>
> > ---
>=20
> Applied to vfio next branch for v5.2 with Alexey's R-b.  Thanks!
>=20
> Alex

Should this have a fixes tag? e.g.:
Fixes: 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] subdri=
ver")

> >  drivers/vfio/pci/vfio_pci_nvlink2.c |    2 ++
> >  1 file changed, 2 insertions(+)
> >=20
> > diff --git a/drivers/vfio/pci/vfio_pci_nvlink2.c b/drivers/vfio/pci/vfi=
o_pci_nvlink2.c
> > index 32f695ffe128..50fe3c4f7feb 100644
> > --- a/drivers/vfio/pci/vfio_pci_nvlink2.c
> > +++ b/drivers/vfio/pci/vfio_pci_nvlink2.c
> > @@ -472,6 +472,8 @@ int vfio_pci_ibm_npu2_init(struct vfio_pci_device *=
vdev)
> >  	return 0;
> > =20
> >  free_exit:
> > +	if (data->base)
> > +		memunmap(data->base);
> >  	kfree(data);
> > =20
> >  	return ret;
> >=20
>=20

--k+w/mQv8wyuph6w0
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEELWWF8pdtWK5YQRohMX8w6AQl/iIFAlzQ5OsACgkQMX8w6AQl
/iLZ/Qf/a2uoZMkf/WjdRce1EAfSE6HjkKRrr1PS33DS2L9FeAqgQONGSri4KFnl
rLzZvsLzMYF44Ai2T4PPOvNAA1OAOZEpIt4J29AFThCIFBm59y1SPuAkiqUrKJfe
KW0L9OG4e9L7ea/wNutFJ/bCV/tqOyFazGxp1S0nlcofguQp39tfhtUq50DYptxP
1bOY91t9A4HtUU82vmT7hJ+OG7PpEhlh1UPqNr541RUwnMfVyjdSHB+NEbMAklun
tZtjMGmv3F9p/7cwHLIlIR1dMJhvqgJeMyxHPhx1clfn1Vt33ZzcBjTE52smto+K
WUkqeQWdXpl3m6Q0wmxGf+8i/qkVPA==
=H10W
-----END PGP SIGNATURE-----

--k+w/mQv8wyuph6w0--