Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3339788yba; Mon, 6 May 2019 22:48:38 -0700 (PDT) X-Google-Smtp-Source: APXvYqyhxfsFvwQMBfmmAs11PaXeiUwkATDxudlqjLiQrvrQLKegsuCFWSPSVaQ5MQYAmrAc8PZD X-Received: by 2002:a63:5608:: with SMTP id k8mr18670207pgb.393.1557208118073; Mon, 06 May 2019 22:48:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557208118; cv=none; d=google.com; s=arc-20160816; b=i3Aha+Gk5aEKCc8gcBBO2g2VJeUQNcKMX7WjT58xaLt0YyZWOUb4kRz7W0TsLOhmM3 8ahuimvbbyGP/sZOsEWC1GLVI5/C07wkyHeV1CuIkvYvyQbCslpyU2brKN9M2K9Fl1Zj ZoDqfevOoGnlzuwelMTGbtQx3hwTbO5xIe9kJuo0HAsk8Ned4ZTd/Bg4FbgI+Ups4BBY Y/qGMPOYZjtgEwdL70dBd5X1K+P3I8iT7+LCGVoJjwZGb1FFFwB7KfrL1RY82ytQzue7 HYSx52+Px1gdHqzUMzh9UhEWGrEHd5wA+534lleIGPxr8mT3uSG8nVx8xJh+00ozCGms M7wQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=5pb0dMOrOcrv2g9uTwEm4BWFuSXE7qUVRIl/5FOdPjk=; b=0BtI2IPv52BZyiwufThsAW6X6JVEdNUSVcf/VUaA5pCeUKx9uGYYl0jOI2vEZKal1J C68SPHP3zNj7b6r42gKjaCkP0bPrWIR9jtEV9UazZQpUWi++Txr6MviCtLGoD8EXHCem 8hYOl6gCaHwhDXudRt9OCYE4Wg3l1xUxV/uErcjur2zs5LTY3k2ZEzetHS7rIGZ1KPQ6 2oBqElDi1rF5vpET711Lsgm55tG5KffriyMy1NIzXCFxYICmrLDkX09SW07MrFqh/vLt 9QrOQJGpESmmDwJM0fv+L3lKigOcQjxF8JV4rO+UC1DRNN6A3ZEw+MlK72+WMRU22bOw 4BZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SDfCoIhY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d34si7399417pgd.558.2019.05.06.22.48.22; Mon, 06 May 2019 22:48:38 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=SDfCoIhY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727279AbfEGFrg (ORCPT + 99 others); Tue, 7 May 2019 01:47:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:60736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729283AbfEGFlO (ORCPT ); Tue, 7 May 2019 01:41:14 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CF903206A3; Tue, 7 May 2019 05:41:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1557207673; bh=/YVfN5m3TiLOc9QdPjsjom+hIeqD18FjHyZtXKACgTA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=SDfCoIhY3wSWuE8kzImDfBL5PudB0+9Orhv9Zcqn2vjwwqO7MSMdmm7/PVkfPgQBa XkBLGrlkr1OE53uRJQNG2JagxBrD7a5brWwITJajO3ul/5b8PCxKs+uKmQyRZ86UGx r3uL8HhDB7CNHaUo8ka6ICSuUsOaIYjnWiDLvrUk= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Ido Schimmel , Jiri Pirko , "David S . Miller" , Sasha Levin , netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 90/95] mlxsw: core: Do not use WQ_MEM_RECLAIM for EMAD workqueue Date: Tue, 7 May 2019 01:38:19 -0400 Message-Id: <20190507053826.31622-90-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190507053826.31622-1-sashal@kernel.org> References: <20190507053826.31622-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ido Schimmel [ Upstream commit a8c133b06183c529c51cd0d54eb57d6b7078370c ] The EMAD workqueue is used to handle retransmission of EMAD packets that contain configuration data for the device's firmware. Given the workers need to allocate these packets and that the code is not called as part of memory reclaim path, remove the WQ_MEM_RECLAIM flag. Fixes: d965465b60ba ("mlxsw: core: Fix possible deadlock") Signed-off-by: Ido Schimmel Acked-by: Jiri Pirko Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/mellanox/mlxsw/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c index cced009da869..070fd3f7fadf 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/core.c +++ b/drivers/net/ethernet/mellanox/mlxsw/core.c @@ -600,7 +600,7 @@ static int mlxsw_emad_init(struct mlxsw_core *mlxsw_core) if (!(mlxsw_core->bus->features & MLXSW_BUS_F_TXRX)) return 0; - emad_wq = alloc_workqueue("mlxsw_core_emad", WQ_MEM_RECLAIM, 0); + emad_wq = alloc_workqueue("mlxsw_core_emad", 0, 0); if (!emad_wq) return -ENOMEM; mlxsw_core->emad_wq = emad_wq; -- 2.20.1