Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3510761yba; Tue, 7 May 2019 02:24:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqyT/eJa17X50tSmiSkizyim2EKTz9LZRwc6qxOncMO1Qccs+hjwXqKgXTAmNORgx0JoY12W X-Received: by 2002:a62:4558:: with SMTP id s85mr40738249pfa.171.1557221055404; Tue, 07 May 2019 02:24:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557221055; cv=none; d=google.com; s=arc-20160816; b=FAzbxLZVw6xNKz0kV027Z1UsUtNCqJviA6mAkrPjK5oMEI5v4xSqTL7B8ggm2W17y8 ITcOV0EDdsD0CEnvc6jWJQ/TbVmEYfqIZqXSDFb3405Cjc3RC2CrcmtnoFoEiq/KjyNv J5Uv5LoXmJfywfOcKseHk3SapWW2SHwZVLq4096DG82FoCJVxRNrgX4jXoLJQ3WcVZ7P W6Z/LOnwmaSiOLWCcgedCPg3UnLKDlpi9u4N/G1p55IMSV6nOiI4xOaokYWuZb3GkvKr VcCnWbpLs8NIFYbQoW12+bz327yVx16O44tzvXJd6bbpsAkpO4vUGh7VfRRPyka4Hk66 RNMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=GWMFFy2F73uQioGzc/atPqbskzKfI+KjLLT2AD39XqM=; b=rkbynZrdUNpea8SBDMkaSBnN5uFoC7oEmUJNUCTScwkpXjpZmQsklaJS0ijdOYABrF 2Z1U/X5fIAy7ejIY6crPkw+/KZzrTpdT6EGlCTR//CvtZK2Id02A5+SI0c6cIiuMY522 z9fCB3leYtHAHNd0hc9bh9IiA/xrdHqEnRe/iLNKfbwr4+hlZK6VuX7mva6qPT/FyoH6 byoXZNQwftECIy6peCbK/Ksim2icCYoMZmcAgJN7KCNLmSCgTvHRg1tEC5Xai3Q01C+2 BccazZeK3jaKEDbr/gr2i0GB6XPGawGH0skown7BwRf6+e2E8Pnl3Cfr8LTJaIugpPUu esZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j98si19818146plb.32.2019.05.07.02.23.58; Tue, 07 May 2019 02:24:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726664AbfEGJXJ (ORCPT + 99 others); Tue, 7 May 2019 05:23:09 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:53644 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726349AbfEGJXJ (ORCPT ); Tue, 7 May 2019 05:23:09 -0400 Received: by mail-wm1-f67.google.com with SMTP id 198so1623040wme.3 for ; Tue, 07 May 2019 02:23:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=GWMFFy2F73uQioGzc/atPqbskzKfI+KjLLT2AD39XqM=; b=OX5vvZ87LB8cDTHYamz6ligqfmQhsZ90tAaUfhW/IEsC6KHMHK+E9vGdNRRy6BOkyX 6+cj0giqIw4AHdBAi8vmxMODUJn8lXbsDTJIH/fbvp54BZTW7/eJVi8hBs2V2a+/dRgz P4AZcCq8siWWa1i1ZdA0WHsf86YolUA/v7aAUzexizy/0jj+PSLWAog22NrW0arYjkmv kq83vOOTR/Ni78BW71QcFHgrj8o/uLFJZcXwHiHC/ena89R4f6NGoe5b5mOJdN3cflqT 2U9wPrMk67OSqdM6fU70ReShJTHFD+EqYPj2V2+Im6rhBoBLG/ppiYktnrAuaSEMarHA MqZQ== X-Gm-Message-State: APjAAAX4xe4fon1ydvgy6fwbyXBTZVA7zrRrnWyfAg9qAqUutqE9g6eS zIXPXC8DmtyXqyPCtlnGg35JsA== X-Received: by 2002:a1c:4c09:: with SMTP id z9mr19795673wmf.87.1557220987708; Tue, 07 May 2019 02:23:07 -0700 (PDT) Received: from linux.home (2a01cb05850ddf00045dd60e6368f84b.ipv6.abo.wanadoo.fr. [2a01:cb05:850d:df00:45d:d60e:6368:f84b]) by smtp.gmail.com with ESMTPSA id s3sm26161021wre.97.2019.05.07.02.23.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 07 May 2019 02:23:07 -0700 (PDT) Date: Tue, 7 May 2019 11:23:05 +0200 From: Guillaume Nault To: YueHaibing Cc: davem@davemloft.net, g.nault@alphalink.fr, jian.w.wen@oracle.com, edumazet@google.com, kafai@fb.com, xiyou.wangcong@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] l2tp: Fix possible NULL pointer dereference Message-ID: <20190507092304.GA12570@linux.home> References: <20190506144404.25220-1-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190506144404.25220-1-yuehaibing@huawei.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 06, 2019 at 10:44:04PM +0800, YueHaibing wrote: > If alloc_workqueue fails in l2tp_init, l2tp_net_ops > is unregistered on failure path. Then l2tp_exit_net > is called which will flush NULL workqueue, this patch > add a NULL check to fix it. > Thanks! Acked-by: Guillaume Nault