Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Leonard Crestez <leonard.crestez@nxp.com>
To:     =?Windows-1252?Q?Petr_=8Atetiar?= <ynezz@true.cz>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "David S. Miller" <davem@davemloft.net>
CC:     Matthias Brugger <matthias.bgg@gmail.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Frank Rowand <frowand.list@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH net-next v2 0/4] of_get_mac_address ERR_PTR fixes
Thread-Topic: [PATCH net-next v2 0/4] of_get_mac_address ERR_PTR fixes
Thread-Index: AQHVBFI0RuJU2cpMvEWgdGL840mRHg==
Date:   Tue, 7 May 2019 12:14:50 +0000
Message-ID: <AM0PR04MB6434E06E7C43A2C95EB81F42EE310@AM0PR04MB6434.eurprd04.prod.outlook.com>
References: <1557177887-30446-1-git-send-email-ynezz@true.cz>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: cd066af7-f27a-4e62-3648-08d6d2e59aaf
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2019 12:14:50.3172
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4689
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07.05.2019 00:25, Petr =8Atetiar wrote:=0A=
> Hi,=0A=
> =0A=
> this patch series is an attempt to fix the mess, I've somehow managed to=
=0A=
> introduce.=0A=
> =0A=
> First patch in this series is defacto v5 of the previous 05/10 patch in t=
he=0A=
> series, but since the v4 of this 05/10 patch wasn't picked up by the=0A=
> patchwork for some unknown reason, this patch wasn't applied with the oth=
er=0A=
> 9 patches in the series, so I'm resending it as a separate patch of this=
=0A=
> fixup series again.=0A=
> =0A=
> Second patch is a result of this rebase against net-next tree, where I wa=
s=0A=
> checking again all current users of of_get_mac_address and found out, tha=
t=0A=
> there's new one in DSA, so I've converted this user to the new ERR_PTR=0A=
> encoded error value as well.=0A=
> =0A=
> Third patch which was sent as v5 wasn't considered for merge, but I still=
=0A=
> think, that we need to check for possible NULL value, thus current IS_ERR=
=0A=
> check isn't sufficient and we need to use IS_ERR_OR_NULL instead.=0A=
> =0A=
> Fourth patch fixes warning reported by kbuild test robot.=0A=
> =0A=
> Cheers,=0A=
> =0A=
> Petr=0A=
> =0A=
> Petr =8Atetiar (4):=0A=
>    net: ethernet: support of_get_mac_address new ERR_PTR error=0A=
>    net: dsa: support of_get_mac_address new ERR_PTR error=0A=
>    staging: octeon-ethernet: Fix of_get_mac_address ERR_PTR check=0A=
>    net: usb: smsc: fix warning reported by kbuild test robot=0A=
=0A=
>   drivers/net/ethernet/freescale/fec_main.c             | 2 +-=0A=
=0A=
This fixes netboot on imx (probably all of them).=0A=
=0A=
Tested-by: Leonard Crestez <leonard.crestez@nxp.com>=0A=
=0A=
But shouldn't "support of_get_mac_address new ERR_PTR error" somehow be =0A=
reordered so that it's done before allowing non-null errors from =0A=
of_get_mac_address?=0A=
=0A=
Otherwise it will break bisect for many people.=0A=
=0A=
--=0A=
Regards,=0A=
Leonard=0A=