Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp3674668yba; Tue, 7 May 2019 05:22:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqyMBMliysTCu574QMl5rK77XhOMIiNsEgtVUCcrhdTvRILN9bm+zzSS8BC2fJCg8+1KFzvQ X-Received: by 2002:a62:5ec4:: with SMTP id s187mr36885876pfb.185.1557231778528; Tue, 07 May 2019 05:22:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557231778; cv=none; d=google.com; s=arc-20160816; b=1DrZ8KKTUbcwTjgqPeT5iWGWCzANUlek7NZRV+PuukpG3ELf91Y4pqYKcp9Gl5LDl7 yI1YMfQ5/eeB8Cjj5t9ou+DQYxWdJwCwX1X+ECmdnHAIEkj7MrXf8Eg+5ha+hqKqZhmh IJAsxWCVtnwK8ZJSleiPj1VbQRLQSw+cNMl6KH7m0H1nnsam/dlIFjibcfD5Xk/wXBPT GQCE9Fxe7b/wDEP+n8QTTOBMl2domfG1LpEKHuEnKD7vB3JhSsayRChP1l1ezv7jwG7e hyb2LZX3rH1FvdaKhzbEqNEmnrpEGxR/IkaqtgzF+yZ2Oz+3FgMXY3JYtl1OdEpJ3Ya2 KhqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=XBpHrK3x4JFxd3spf5zG50ETJ0+QB7RkIoJz/qx+uqg=; b=GJBGaF0Z4UT/I8Qsu1C5Kb5TPMOcjSLmbbQ8NfxrOMU4zIRtwNjoXiAyUimh3Q8ysJ xsnI/HdJ/IdLmE9rAOKutxmh3NiJy5l6Rx61PwfY4ZDuKuQRjvpePVMHF8YicqjAEGA2 aVb1f0EAkXJXMx/9nT8UynyrWp8YbYP87hD5/XVaD34Uctch3qFSrNnGVilexA0bj+O3 kuAgxB3AgnqcyG3RTU+kdqVp4FHg1we44Dpjbuyd+elAgu5TDQxzniMFSCGgTWbw/64G /I/b4saGwklQ44mnEAsx9bIYWPbyQo2+fZmcXY4u6wkOIBtkpo5+3TuUW/5Lr1wL4tMx hbnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=mTd1DFCI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c14si18846711pfn.40.2019.05.07.05.22.42; Tue, 07 May 2019 05:22:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=merlin.20170209 header.b=mTd1DFCI; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726605AbfEGMVs (ORCPT + 99 others); Tue, 7 May 2019 08:21:48 -0400 Received: from merlin.infradead.org ([205.233.59.134]:38728 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726329AbfEGMVs (ORCPT ); Tue, 7 May 2019 08:21:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=XBpHrK3x4JFxd3spf5zG50ETJ0+QB7RkIoJz/qx+uqg=; b=mTd1DFCIEzuPrvgXakuyjb47w p310AoKWHdWycrX+sLSHTp9MoUxhRGHDSVq7JUwZ0f2l08HqLoR38HovwbN1tApd+JeoND8dVA/4g yOXAYyy0GsOorIq/OdC2VDPyt2Ucvu0L3OP80D1r7hs6G9zLC1f7Zw8fK5U7Dw8rYwJ7IxPdv1XfY G4Auzr1T8r7mstosshXsYk7AvtkXfroxEFhCnTuITY6ssAjyxiFOaydf3xd0UtmovloPlHJ0hRJpb RAsBDTni5oxHv4DBDeomvAzWkhQr+PpC7LchkVuN928sGjzm/jUF3jFUujD/2zkb5NOL7T6KGQq8q Yl6zk1aCw==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=hirez.programming.kicks-ass.net) by merlin.infradead.org with esmtpsa (Exim 4.90_1 #2 (Red Hat Linux)) id 1hNz6M-000708-VD; Tue, 07 May 2019 12:21:43 +0000 Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 9593E2023ADB5; Tue, 7 May 2019 14:21:41 +0200 (CEST) Date: Tue, 7 May 2019 14:21:41 +0200 From: Peter Zijlstra To: Len Brown Cc: x86@kernel.org, linux-kernel@vger.kernel.org, Kan Liang , Len Brown Subject: Re: [PATCH 16/22] perf/x86/intel/uncore: Support multi-die/package Message-ID: <20190507122141.GM2623@hirez.programming.kicks-ass.net> References: <6f53f0e494d743c79e18f6e3a98085711e6ddd0c.1557177585.git.len.brown@intel.com> <1d7c4d47cfca91c11b0e078d86a8f7f7da6d862a.1557177585.git.len.brown@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1d7c4d47cfca91c11b0e078d86a8f7f7da6d862a.1557177585.git.len.brown@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 06, 2019 at 05:26:11PM -0400, Len Brown wrote: > @@ -1411,7 +1413,7 @@ static int __init intel_uncore_init(void) > if (boot_cpu_has(X86_FEATURE_HYPERVISOR)) > return -ENODEV; > > - max_packages = topology_max_packages(); > + max_packages = topology_max_packages() * topology_max_die_per_package(); That's max_dies.. > uncore_init = (struct intel_uncore_init_fun *)id->driver_data; > if (uncore_init->pci_init) { > -- > 2.18.0-rc0 >