Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4002233yba; Tue, 7 May 2019 10:27:13 -0700 (PDT) X-Google-Smtp-Source: APXvYqwcrqe/FqGkH4TqB0jrfDLI4ueY7GQMmtKaehz9IK+5q/LFWSM/QGUdPkyuZ+mNydCOhTp8 X-Received: by 2002:a63:d408:: with SMTP id a8mr40054881pgh.184.1557250033124; Tue, 07 May 2019 10:27:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557250033; cv=none; d=google.com; s=arc-20160816; b=tKmfFFnQMJMqD0KNY4XPlSewsdzoKsyfDW2lSCIdJb2MuiLqhF1+QyHxo53i8ratKX YQzuW7tq1UhzGLIcUKqK/u7Fg2PeLXBoDKvNQsltepxVvNCqr2/sC6IF5Udi45K1jubS 6BMHCewcAuM52OhPU2mikZFfDuWKLO9vRh8Y0ybG+tCOxGgw30QK3ita8RkrCUCXN8zv VBIm1IIAV1nJLk041dRN4OZP6UvfJw+SYxh759DngoVBKyVmywXI+oKFSu00N7gT1ni7 uwU8ZQ0v7ikJ/xkDsKKPrXLwcfFshb5IjpWDsSsxf8LYkbroBPmJ0QtaFyc3VbeDPLUt uwMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=vCR0By1Idq0+bTt7KxwBw1QnF+3AVLoKPV/roFDxjI8=; b=tKWOxhBS1rKOwhctW6NU/uEVxwSpCclEqjhv4DjkkkZ2mNAJkqBuahHtE5jNU2b1+c u425bxco3nrBKM3U1p/NyOW9ULN6168qUMBa68BX54ISvavKGRVqOYqUBkRnxw2cIQE1 My7tlI61iXRBWb5Iuj1eNAWL8Y9IWQmNHiuKUE2tr0Zd6Kjwg9HFHjnsmKuWRiSx9At5 AdG8wUg3V7dhebLFocIYV82tkwjU15puhEsseeJ+HK6GkiaPcvQV7Nn8sGuphDBAusvr 1YcP/WBJowmiV/2Gy/pzLbZD0240GseKlP+5+gt+TeTLE2lah2dMyCovXpV6ECumCiGH 52uw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g3si18874455pfi.97.2019.05.07.10.26.57; Tue, 07 May 2019 10:27:13 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727474AbfEGR0B (ORCPT + 99 others); Tue, 7 May 2019 13:26:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50166 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726335AbfEGR0A (ORCPT ); Tue, 7 May 2019 13:26:00 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 743FB36887; Tue, 7 May 2019 17:26:00 +0000 (UTC) Received: from x1.home (ovpn-117-92.phx2.redhat.com [10.3.117.92]) by smtp.corp.redhat.com (Postfix) with ESMTP id D766E171AD; Tue, 7 May 2019 17:25:59 +0000 (UTC) Date: Tue, 7 May 2019 11:25:59 -0600 From: Alex Williamson To: Greg Kurz Cc: Sam Bobroff , Alexey Kardashevskiy , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] vfio-pci/nvlink2: Fix potential VMA leak Message-ID: <20190507112559.2022645c@x1.home> In-Reply-To: <20190507090145.4be12c82@bahia.lan> References: <155568823785.601037.2151744205292679252.stgit@bahia.lan> <20190506155845.70f3b01d@x1.home> <20190507014915.GA10274@tungsten.ozlabs.ibm.com> <20190507090145.4be12c82@bahia.lan> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Tue, 07 May 2019 17:26:00 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 7 May 2019 09:01:45 +0200 Greg Kurz wrote: > On Tue, 7 May 2019 11:52:44 +1000 > Sam Bobroff wrote: > > > On Mon, May 06, 2019 at 03:58:45PM -0600, Alex Williamson wrote: > > > On Fri, 19 Apr 2019 17:37:17 +0200 > > > Greg Kurz wrote: > > > > > > > If vfio_pci_register_dev_region() fails then we should rollback > > > > previous changes, ie. unmap the ATSD registers. > > > > > > > > Signed-off-by: Greg Kurz > > > > --- > > > > > > Applied to vfio next branch for v5.2 with Alexey's R-b. Thanks! > > > > > > Alex > > > > Should this have a fixes tag? e.g.: > > Fixes: 7f92891778df ("vfio_pci: Add NVIDIA GV100GL [Tesla V100 SXM2] subdriver") > > > > Oops... you're right. > > Alex, can you add the above tag ? Added. Thanks, Alex