Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>
CC:     Kees Cook <keescook@chromium.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvme-pci: mark expected switch fall-through
Thread-Topic: [PATCH] nvme-pci: mark expected switch fall-through
Thread-Index: AQHVBOB79kdJ84ToAkqBJNoy4OB4Dw==
Date:   Tue, 7 May 2019 17:41:51 +0000
Message-ID: <SN6PR04MB4527B0A6917F74B5C241FD0F86310@SN6PR04MB4527.namprd04.prod.outlook.com>
References: <20190507142300.GA25717@embeddedor>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: d4afcc66-6e02-4829-e513-08d6d31349b6
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2019 17:41:51.3035
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR04MB4158
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Looks good.=0A=
=0A=
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>=0A=
=0A=
On 5/7/19 7:23 AM, Gustavo A. R. Silva wrote:=0A=
> In preparation to enabling -Wimplicit-fallthrough, mark switch=0A=
> cases where we are expecting to fall through.=0A=
>=0A=
> This patch fixes the following warning:=0A=
>=0A=
> drivers/nvme/host/pci.c: In function =91nvme_timeout=92:=0A=
> drivers/nvme/host/pci.c:1298:12: warning: this statement may fall through=
 [-Wimplicit-fallthrough=3D]=0A=
>    shutdown =3D true;=0A=
>    ~~~~~~~~~^~~~~~=0A=
> drivers/nvme/host/pci.c:1299:2: note: here=0A=
>   case NVME_CTRL_CONNECTING:=0A=
>   ^~~~=0A=
>=0A=
> Warning level 3 was used: -Wimplicit-fallthrough=3D3=0A=
>=0A=
> This patch is part of the ongoing efforts to enable=0A=
> -Wimplicit-fallthrough.=0A=
>=0A=
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>=0A=
> ---=0A=
>  drivers/nvme/host/pci.c | 1 +=0A=
>  1 file changed, 1 insertion(+)=0A=
>=0A=
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c=0A=
> index 3e4fb891a95a..a12f992868c9 100644=0A=
> --- a/drivers/nvme/host/pci.c=0A=
> +++ b/drivers/nvme/host/pci.c=0A=
> @@ -1296,6 +1296,7 @@ static enum blk_eh_timer_return nvme_timeout(struct=
 request *req, bool reserved)=0A=
>  	switch (dev->ctrl.state) {=0A=
>  	case NVME_CTRL_DELETING:=0A=
>  		shutdown =3D true;=0A=
> +		/* fall through */=0A=
>  	case NVME_CTRL_CONNECTING:=0A=
>  	case NVME_CTRL_RESETTING:=0A=
>  		dev_warn_ratelimited(dev->ctrl.device,=0A=
=0A=
=0A=