Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 07 May 2019 12:17:58 -0700 (PDT)
Message-Id: <20190507.121758.1374598572835036372.davem@davemloft.net>
To:     yuehaibing@huawei.com
Cc:     g.nault@alphalink.fr, jian.w.wen@oracle.com, edumazet@google.com,
        kafai@fb.com, xiyou.wangcong@gmail.com,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] l2tp: Fix possible NULL pointer dereference
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190506144404.25220-1-yuehaibing@huawei.com>
References: <20190506144404.25220-1-yuehaibing@huawei.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: YueHaibing <yuehaibing@huawei.com>
Date: Mon, 6 May 2019 22:44:04 +0800

> BUG: unable to handle kernel NULL pointer dereference at 0000000000000128
 . ..
> ---[ end trace 8322b2b8bf83f8e1
> 
> If alloc_workqueue fails in l2tp_init, l2tp_net_ops
> is unregistered on failure path. Then l2tp_exit_net
> is called which will flush NULL workqueue, this patch
> add a NULL check to fix it.
> 
> Fixes: 67e04c29ec0d ("l2tp: unregister l2tp_net_ops on failure path")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Applied and queued up for -stable, thanks.