Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4371693yba; Tue, 7 May 2019 17:26:48 -0700 (PDT) X-Google-Smtp-Source: APXvYqwE/DXtoyUOtrXEPPcmMtpADI6W/jCfJJuqA8vsnKlMa/gNu18j2hmaiv514d4Tw/WNhyNC X-Received: by 2002:a62:5a42:: with SMTP id o63mr46732143pfb.170.1557275208010; Tue, 07 May 2019 17:26:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557275208; cv=none; d=google.com; s=arc-20160816; b=LCwJvAOFtWPGc0rD6q9bRzxc5EBucmdXLvbv3UHqAWIUUxC7hMBRBubAMUsLBh0VIv Z66i9szBkJ3v8pFEdrnhJlTbt09pO0AbdjDSB5OoFgermMdpfaQkd0u2JCLBs1VToEHA RPpjXH2F8DbshLr51r5l0XqDQ+FPfBZo5kaeUX/qgE4qyCGr5c9ym6UnScjpe2aDwYVf XfOLWmLZDWCB34914HW4kxulbBr9OuMcpx/GDBgPRNc1JoISPbnIUEg4lhx+ydn12Klh HKE7bFTTgCvEdJHuPfKbQDvJrhGHhQosx+FG319dXnlpZhzYgdPWIZqU0kLOpbGblZnx +68w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:dlp-filter:cms-type :content-transfer-encoding:date:message-id:in-reply-to:cc:to:from :reply-to:subject:mime-version:dkim-signature:dkim-filter; bh=KOFXNp3YdVudGio3ms3L3EHkZOK4kF38DEZPb5dGSho=; b=RTt38d+NOImutCAcapnm2brvlwjlm92NiZW+kcqEy7PAMKuZWJJI8r9VuquvLDMbuR eHC1tEs4EvJ5eJjR3U55xRSS6ftvC+c9U+MTtIeL0BxMboNEj53Wnf92DAeNucuuyW8i 3ujn99AnaMubK1UwZ0u4swlXGUl2vrSh8FXF9BlJTa5mhoiWbLV5BQkJDYAlWJHuFgAz uU0GPBFLiyhy8VsEyaLOghPz7IhlosZvZkggOCzQV+8UjvqYsMtLsE/ksoBSe97l3Zh0 NqTEnCkvxI3jp9R3emYyavZfMl+V0Bhd+Syhvaa7hfE/GothSBHd2BUTTkMSEjsoOvGf Tmvw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=Z6LvqpeJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y36si2273868pgl.336.2019.05.07.17.26.31; Tue, 07 May 2019 17:26:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b=Z6LvqpeJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726381AbfEHAZm (ORCPT + 99 others); Tue, 7 May 2019 20:25:42 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:25883 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726276AbfEHAZm (ORCPT ); Tue, 7 May 2019 20:25:42 -0400 Received: from epcas2p2.samsung.com (unknown [182.195.41.54]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20190508002539epoutp04a0e0444b38295908abb1e71b8104acf5~cjX0tWckH0526805268epoutp044 for ; Wed, 8 May 2019 00:25:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20190508002539epoutp04a0e0444b38295908abb1e71b8104acf5~cjX0tWckH0526805268epoutp044 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1557275139; bh=KOFXNp3YdVudGio3ms3L3EHkZOK4kF38DEZPb5dGSho=; h=Subject:Reply-To:From:To:CC:In-Reply-To:Date:References:From; b=Z6LvqpeJZmgKLQxCECNLAWEaH0OJnQ5MueVJ4pMCPKCKH+Z//9UkYYxJi5QSUcWB0 FM6kmy6GWviz/6c1wAer/yBzdmVesdFdgntt4M33VCMYXjAvDicMDrRDDT569e8VSv gwbIzbWW30GxefxVlsCTAKJGJplqRV1z/2s6GVg0= Received: from epsmges2p2.samsung.com (unknown [182.195.40.189]) by epcas2p1.samsung.com (KnoxPortal) with ESMTP id 20190508002536epcas2p10feb8a852a695e6c6d95c267c9fc95e3~cjXxF55i61873218732epcas2p1F; Wed, 8 May 2019 00:25:36 +0000 (GMT) X-AuditID: b6c32a46-d63ff7000000106f-c7-5cd221fea1bf Received: from epcas2p3.samsung.com ( [182.195.41.55]) by epsmges2p2.samsung.com (Symantec Messaging Gateway) with SMTP id 5A.D4.04207.EF122DC5; Wed, 8 May 2019 09:25:34 +0900 (KST) Mime-Version: 1.0 Subject: Re: [PATCH v2 6/7] nvme-pci: add device coredump support Reply-To: minwoo.im@samsung.com From: Minwoo Im To: Keith Busch , Akinobu Mita , Minwoo Im CC: Jens Axboe , Sagi Grimberg , "linux-kernel@vger.kernel.org" , "linux-nvme@lists.infradead.org" , Keith Busch , Minwoo Im , Johannes Berg , Christoph Hellwig X-Priority: 3 X-Content-Kind-Code: NORMAL In-Reply-To: <20190507170733.GA6783@localhost.localdomain> X-Drm-Type: N,general X-Msg-Generator: Mail X-Msg-Type: PERSONAL X-Reply-Demand: N Message-ID: <20190508002534epcms2p3acacda8460fcfb7f2b978411b74bbbd5@epcms2p3> Date: Wed, 08 May 2019 09:25:34 +0900 X-CMS-MailID: 20190508002534epcms2p3acacda8460fcfb7f2b978411b74bbbd5 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFJsWRmVeSWpSXmKPExsWy7bCmue4/xUsxBq87TS1eHehgtPi/5xib xcrVR5ksPm74xGIx6dA1Rot7R78wWVzeNYfNYv6yp+wWvzq5LZ6dPsBsse71exYHbo+Jze/Y PXbOusvucf7eRhaPxXteMnlsWtXJ5rF5Sb3H7psNbB59W1YxevT3bmPx+LxJLoArKscmIzUx JbVIITUvOT8lMy/dVsk7ON453tTMwFDX0NLCXEkhLzE31VbJxSdA1y0zB+hiJYWyxJxSoFBA YnGxkr6dTVF+aUmqQkZ+cYmtUmpBSk6BoWGBXnFibnFpXrpecn6ulaGBgZEpUGVCTsbzXduY C16wVLzf6dHA+I65i5GTQ0LARGLd5W5GEFtIYAejxNY/2l2MHBy8AoISf3cIg4SFBRwlDq45 zAgSFhKQl/jxygAirCnxbvcZVhCbTUBdomHqKxYQW0QgX6J7yVamLkYuDmaBe0wSzx91M0Gs 4pWY0f6UBcKWlti+fCvYTE4BK4mF/0IhwqISN1e/ZYex3x+bzwhhi0i03jsLdbGgxIOfu8Fa JQQkJO69s4Mw6yW2rLAA2Soh0MIocePNWqhWfYnG5x/BtvIK+EpsXDwNzGYRUJWY8mMOVI2L xPkb09hAbGagD7e/ncMMMpMZ6MX1u/QhxitLHLnFAlHBJ9Fx+C87zE875j2B+k9Z4uOhQ1BH Skosv/SaDaLVQ2Lbf1+Qy4QEfjJK3Fv5hXECo8IsRCjPQrJ3FsLeBYzMqxjFUguKc9NTi40K jJCjdRMjON1que1gXHLO5xCjAAejEg/vhLyLMUKsiWXFlbmHGCU4mJVEeI32AYV4UxIrq1KL 8uOLSnNSiw8xmgK9P5FZSjQ5H5gL8kriDU2NzMwMLE0tTM2MLJTEeR9Kz40WEkhPLEnNTk0t SC2C6WPi4JRqYDxxQa2m3C3pzNmQ+C4jvrbv8U0CKWt3lFyouOc58+XSUrGEf+zF3ydZV2ys ETO6evATR4Mih5+OAHOwc/fHNvWQh+XXH+ZbO8csvsl59byuYtYG/ZhkN8Z9S8rMowqmvZzH 4PnuQ9ic59IBRzoDPCey6fJYr8r+zNBo3Fdwk/dLlXBa8RcFJZbijERDLeai4kQAdmyF8c0D AAA= DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20190507171318epcas5p129bb73b39447d62a7d266ed461687488 References: <20190507170733.GA6783@localhost.localdomain> <1557248314-4238-1-git-send-email-akinobu.mita@gmail.com> <1557248314-4238-7-git-send-email-akinobu.mita@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > This is a bit of a mine field. The shutdown_lock is held when reclaiming > requests that didn't see a response. If you're holding it here and your > telemetry log page times out, we're going to deadlock. And since the > controller is probably in a buggered state when you try to retrieve one, > I would guess an unrecoverable timeout is the most likely outcome. Akinobu, I actually agree with Keith's one. In my experience, there was always internal error inside device when timeout occurs in nvme driver which means the following command might not be completed due to lack of response from device.