Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp4749570yba; Wed, 8 May 2019 02:02:07 -0700 (PDT) X-Google-Smtp-Source: APXvYqxOLlJwQ+MNY5Hx1NqVGiaJfar5JkNiIm/5SbN4/SuNJqDTJIKfReAcywwQ9p9ekt/unJwi X-Received: by 2002:a17:902:1e3:: with SMTP id b90mr26233631plb.182.1557306127135; Wed, 08 May 2019 02:02:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557306127; cv=none; d=google.com; s=arc-20160816; b=pydAx2XNQ7VPJ8VDgYeLdeSJ5PdtPzHfQaIJqrdwgj+vM5VKJlJQJ11aUjMbqHlcZI gz8zcMu5+z2yR0OcZJG8BRERGb+eR7WV50NdH6kImfMEBqkiDJg658ttbsxgVHukGBtO Qf/6/lEMsXBxE82ZaOYksrYcJYlRX81zTjmcaXYpD251NoYKjKp8THuZl722uUOIkn/W /yt5s5BeSSnKpSjmUTCMLavNeWd8SMIs7iNVYr5LcvsZIozOtKhqUZonOdvzo3yqchLY 0hu1vrMyxBqyvQUv1osrvrKwzO9DeBvZHjNSroau5W98gFn44xZQsezWhxwHJic4N7Wa nIUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=rX6ucNl5H/QLYT5MirDdIdADtlybrhpXP2ffdTKqLlA=; b=ltuHilrKZ1haqkM829hDASD59IibsbV6JG1yP2wwjqeJN7wm2LGdIsoYwKROdhVwWV 34WfNaNVrX3Ln96SPAcIK58hikgN8eFhB2Bzp9LKrBtIqlHZ5inxs6VaNg+uxZKskdUJ unz0jatQPmspYCj4qfJSUt2kmo+WxQmKZuZpDN60Bdjj2ZQY/p+fn/f/LmGRalYIA3WI AXQpM9nX9ShH+LX9tnqIXwpnMJpkifh9PIHIjdwoBe9tbLQYmtdnR39sDxjO6OyKqAXc KIFHH7IeyEM/5EaGU4YQ49JJXVEe1tZoSgZ+0eQEH61WMI2tvSP5eDcYtE4MJIvDQPzC 3Cfg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HoIdT6ev; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x28si17053867pff.104.2019.05.08.02.01.49; Wed, 08 May 2019 02:02:07 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HoIdT6ev; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726869AbfEHIko (ORCPT + 99 others); Wed, 8 May 2019 04:40:44 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:38564 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726387AbfEHIkn (ORCPT ); Wed, 8 May 2019 04:40:43 -0400 Received: by mail-pg1-f194.google.com with SMTP id j26so9744636pgl.5; Wed, 08 May 2019 01:40:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rX6ucNl5H/QLYT5MirDdIdADtlybrhpXP2ffdTKqLlA=; b=HoIdT6evN4j/sBXYzP0MOsSz0/32FftHywFEyONPKeqbcOqjCzyxnfQDAjCXTFSS6G ao6dBjp/AXmt2K54mASLesuSjTbnztNkHfeC5CMGR3YI27PUU43V5TzjqqzCUYGt/4oJ orrTcPd7cqMiJtB54BkbMbjOB4sm+UccQ3wAupd8MKq4wdHl0vla2WD0U7xo7wG5LkPg JvR9UM/TfYorWS78Wlyk4c8CEEsOU+Y4BznxJVHuJV+K1xG1L8JmaFQpJPWduKlkBa/i IN78iCIfeHAglip8C8RmgCyzxN7Tp8y2TDqWjLZ0cfXHeh4j6qRHIfZEPSrlZgyLcHvB zaSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rX6ucNl5H/QLYT5MirDdIdADtlybrhpXP2ffdTKqLlA=; b=tEkPKQ/ulZ6t4CFWc2BocTCVbmMkoWkTtn38rixSBuWETjrm2F9XSMdPfsxGS0tvhR 2Uyuh1f60RDv3/0GqaMFhAlob50/GgiHSXVz+I3qmrXxxfz2uEwD5Tux4l4bYvZ1UtRj buGd7UJabh7CIHoWfmJ3hQ67QRq9VsROGkJbbGxbM8rcVCSBLRBrFdbQ5dPRcHsTF1fc ZFEiIBgISiS2g82O8GsyyE17a4LFKCqi2JyUoqg7jNe5fwnNAx2KQ2swmOlL3jJ4TJ3n AoZqWXtvL71YAH7K8/SjUCC2oCPNKeGfKyPqAhdaWzp22xWGkmYpsvI3kvZ8f8r5ZX+Z ve0g== X-Gm-Message-State: APjAAAVaLEaCLBxidJxllU/zOFh/nltEgtF7iUG1vnGBvo4kQ551iiu8 ZDqNNA29YjkAkeTIObXmbNR0W+EkAgXJuxiQ2yo= X-Received: by 2002:a63:dd58:: with SMTP id g24mr45029848pgj.161.1557304842196; Wed, 08 May 2019 01:40:42 -0700 (PDT) MIME-Version: 1.0 References: <20190508082319.GA8817@hjy-HP-Notebook> In-Reply-To: <20190508082319.GA8817@hjy-HP-Notebook> From: Andy Shevchenko Date: Wed, 8 May 2019 11:40:30 +0300 Message-ID: Subject: Re: [PATCH] fix double fetch in wmi_ioctl. To: JingYi Hou Cc: Darren Hart , Andy Shevchenko , Platform Driver , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 8, 2019 at 11:23 AM JingYi Hou wrote: > There is a double fetch problem in function wmi_ioctl. > After second fetch overwrite the length to avoid this. > buf->length is not used now,but it may in the future. > It is good to get it fixed up. So, there is no issue right now. Patch is not needed then. Thanks! -- With Best Regards, Andy Shevchenko