Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751617AbVKIXoN (ORCPT ); Wed, 9 Nov 2005 18:44:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751618AbVKIXoN (ORCPT ); Wed, 9 Nov 2005 18:44:13 -0500 Received: from fairlite.demon.co.uk ([80.176.228.186]:39613 "EHLO windows.demon.co.uk") by vger.kernel.org with ESMTP id S1751616AbVKIXoM (ORCPT ); Wed, 9 Nov 2005 18:44:12 -0500 Subject: Re: [PATCH] AGP performance fixes From: Alan Hourihane To: Benjamin Herrenschmidt Cc: Linux Kernel Mailing List , Dave Jones In-Reply-To: <1131578955.24637.116.camel@gaston> References: <200511092002.jA9K25J8025643@hera.kernel.org> <1131578955.24637.116.camel@gaston> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Wed, 09 Nov 2005 23:44:08 +0000 Message-Id: <1131579848.5973.113.camel@jetpack.demon.co.uk> Mime-Version: 1.0 X-Mailer: Evolution 2.4.0 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1205 Lines: 31 On Thu, 2005-11-10 at 10:29 +1100, Benjamin Herrenschmidt wrote: > On Wed, 2005-11-09 at 12:02 -0800, Linux Kernel Mailing List wrote: > > tree 048db8e12c2b31ec2b88c3154da4c6a77b80028c > > parent 329f7dba5f7dc3bc9a30ad00cf373d2e83115aa1 > > author Alan Hourihane Mon, 07 Nov 2005 15:35:34 -0800 > > committer Dave Jones Wed, 09 Nov 2005 05:43:54 -0800 > > > > [PATCH] AGP performance fixes > > > > AGP allocation/deallocation is suffering major performance issues due to > > the nature of global_flush_tlb() being called on every change_page_attr() > > call. > > .../... > > *** Warning: ".global_flush_tlb" [drivers/char/agp/agpgart.ko] undefined! > > Am I supposed to define something new for uninorth-agp ? Is this yet another > x86-only (or worse, some x86 chipsets only concept going global ? change global_flush_tlb() to flush_agp_mappings() and you should be fine. Linus has a fix for this. Alan. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/