Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751087AbVKJALr (ORCPT ); Wed, 9 Nov 2005 19:11:47 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751090AbVKJALr (ORCPT ); Wed, 9 Nov 2005 19:11:47 -0500 Received: from holomorphy.com ([66.93.40.71]:46028 "EHLO holomorphy.com") by vger.kernel.org with ESMTP id S1751087AbVKJALr (ORCPT ); Wed, 9 Nov 2005 19:11:47 -0500 Date: Wed, 9 Nov 2005 16:10:57 -0800 From: William Lee Irwin III To: Adam Litke Cc: akpm@osdl.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, David Gibson , hugh@veritas.com, rohit.seth@intel.com, kenneth.w.chen@intel.com Subject: Re: [PATCH 1/4] Hugetlb: Remove duplicate i_size check Message-ID: <20051110001057.GK29402@holomorphy.com> References: <1131578925.28383.9.camel@localhost.localdomain> <1131579410.28383.19.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1131579410.28383.19.camel@localhost.localdomain> Organization: The Domain of Holomorphy User-Agent: Mutt/1.5.9i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 882 Lines: 21 On Wed, 2005-10-26 at 12:00 +1000, David Gibson wrote: >> - The check against i_size was duplicated: once in >> find_lock_huge_page() and again in hugetlb_fault() after taking the >> page_table_lock. We only really need the locked one, so remove the >> other. On Wed, Nov 09, 2005 at 05:36:49PM -0600, Adam Litke wrote: > Original post by David Gibson > Version 2: Wed 9 Nov 2005 > Split this cleanup out into a standalone patch > Signed-off-by: David Gibson > Signed-off-by: Adam Litke Innocuous enough. Acked-by: William Irwin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/