Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 8 May 2019 12:56:28 +0200
From:   Heiko Carstens <heiko.carstens@de.ibm.com>
To:     Prarit Bhargava <prarit@redhat.com>
Cc:     linux-kernel@vger.kernel.org, Jessica Yu <jeyu@kernel.org>,
        David Arcari <darcari@redhat.com>
Subject: Re: [PATCH v2] modules: Only return -EEXIST for modules that have
 finished loading
References: <20190507145413.16297-1-prarit@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190507145413.16297-1-prarit@redhat.com>
Message-Id: <20190508105628.GC4102@osiris>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Prarit,

On Tue, May 07, 2019 at 10:54:13AM -0400, Prarit Bhargava wrote:
> Heiko, it would still be good to get a test of this patch from you.  I
> tested this here at Red Hat on some System Z machines.  Without the
> modification made here in v2, the systems failed to boot ~10% of the time.
> After the modification I do not see any boot failures.  I also was
> able to reproduce the boot issue with the acpi_cpufreq driver on a very
> large & fast x86 system which had closer to 100% failure rate without
> the changes in v2.  After the modification in v2 the system has rebooted
> all weekend without any issues.

I gave it a try on a machine that failed quite reliably with your
first patch (the one that was in linux-next and caused problems on
s390) - it now comes up without any issues. Also a machine with 80
CPUs (+SMT2 -> 160 CPUs) comes up without problems.

So everything seems to work. Thanks!