Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: serial: Add Milbeaut serial control
To:     Colin Ian King <colin.king@canonical.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>, linux-serial@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <246f81ba-0ed1-d5bc-1a48-bcf0fb2cc05e@canonical.com>
From:   "Sugaya, Taichi" <sugaya.taichi@socionext.com>
Message-ID: <d19f16aa-1066-9a51-a743-4483a1b2ac46@socionext.com>
Date:   Wed, 8 May 2019 21:55:33 +0900
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <246f81ba-0ed1-d5bc-1a48-bcf0fb2cc05e@canonical.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

Thank you for pointing out.

On 2019/05/02 20:47, Colin Ian King wrote:
> Hi,
> 
> Static analysis with Coverity has picked up an issue in commit:
> 
> commit ba44dc04300441b47618f9933bf36e75a280e5fe
> Author: Sugaya Taichi <sugaya.taichi@socionext.com>
> Date:   Mon Apr 15 20:31:40 2019 +0900
> 
>      serial: Add Milbeaut serial control
> 
> In function mlb_usio_rx_chars() the u8 status is being bit-wise AND'd
> with MLB_USIO_SSR_BRK (which is 1UL << 8) and hence the result is always
> false, which looks incorrect to me.  Is this intentional?
>

No. It is always false so should be dropped.
I will send a fixes patch.

Thanks,
Sugaya Taichi

> Colin
>