Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5092364yba; Wed, 8 May 2019 07:47:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqww1tmHVQYfu1DOq2mL947f/hGXjHMR456ASeBz0tUHLJN823TfVms3OVTJeVQTXYUIVJWA X-Received: by 2002:aa7:8b88:: with SMTP id r8mr48596435pfd.174.1557326828651; Wed, 08 May 2019 07:47:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557326828; cv=none; d=google.com; s=arc-20160816; b=GXrAVzhwkz9a8cPMzBEAtL6tRqoYAUmcbTP6WczvWhJtSw+cYg+b/Y7yu6BHBpogdS kqiFcN/qlCCJAcLBGONchvjE4JAXDg+H7Ce/JtQ/jo30jgrqAm/QerCzeasyQQWnKjuH d64ACBrpWNhDqyYfnAOymT0LqAD7WMyDLnlYj5ZYkQCJ7EewSLMzz4+vFKfusiWaK4M9 1CyKa6yD+uB8Zyvz00/xMjEnlk31o4GE5VOwk7vlsSnlmPiH7cGO2jkr64M9U8rSvba5 l/uEfvWRpn+SWYquI5fgfkpBkxjCtRorgFrhpyozYR/npUu/YYh+J97sgqy9VB6iMxGg lF2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=L0vV4CXgxZrxMQI39HyAbLAuE39R1lIDGlJLQVLUiF4=; b=W0eQiwvFMsotgdyfWwblX3ys4+3m+s/iinMp9Kl4Y3xLhYP7+vYUB73hslLmW4YyVT 2QqQxeHI+mQtOMMIAnTsclyyecSKx/SIbMYnBgdoVqcPBNMJc7S++oQ1nOGaFxmn9yGt 9A7YyXpCS4FFE3SRe6MFwcqlW3hQXw3+gdDzMqkZasRIKK/E7QtvkQK0VyLJwiZnZbqZ KKDTpWY/plg4O5UqLF8E2R20KtJBRfm/PtUtp02gL/yIwgSUhwzhXZmMTFwB/xs9Cpee 3x3RvndQVQKNxnfBXbHZDjV+eQG7Rt/Jx5Y23gcwr7s7N15k6dWThdXHAAmAdugfD5kV 0Uhw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=C8cY6XrZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f64si24827736plb.180.2019.05.08.07.46.53; Wed, 08 May 2019 07:47:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=C8cY6XrZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727824AbfEHNqO (ORCPT + 99 others); Wed, 8 May 2019 09:46:14 -0400 Received: from mail-pl1-f194.google.com ([209.85.214.194]:35410 "EHLO mail-pl1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725910AbfEHNqO (ORCPT ); Wed, 8 May 2019 09:46:14 -0400 Received: by mail-pl1-f194.google.com with SMTP id w24so9972920plp.2; Wed, 08 May 2019 06:46:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=L0vV4CXgxZrxMQI39HyAbLAuE39R1lIDGlJLQVLUiF4=; b=C8cY6XrZEN+XwJeq8JGQToBjLffxQEdVeDyR1/+FCVSPVbhn2S1gSCRDQW9BpzMksx nzXiYSBE8JQr45neyIp2zmUemrmjW2NYN6FlAkunL5lrZvlnj3g2cwjzX1Bj+nGhYe20 MyDXWWttDreiuqfIUSCbXThlNW4wYNCJSq2s+P/IHoHnmOhwKo2OzFePhtv1Clmysa3A 5Lq0h2UK7CWeTCVPZQwpFHzwYdRWyVLUg48xJYOb1/ZQXXxEoGuqJXgzU58IVNmk8o0i cbnY1nPbsq6REpWJzSwvCQXGkYq2qMSdf/qOQSMQK4oHtzCpMfIkTvob9XZGwhGH/ehI n70w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=L0vV4CXgxZrxMQI39HyAbLAuE39R1lIDGlJLQVLUiF4=; b=AvKKwQvINESdbUuKGeZoG7HTXVElUlQjxTYDCLZ1OrOW7Qlo0sJIGZ4qWvxETvhHXc xrfrK4S+Qg+KzLoyukiAkS8LqDn7B0zLAgGZbAc5IFQLGCZg3c73u9A/DXN25EdCjJtL uT3WGvuVPvqvNVcmw3RoBRSGGxQ8mZqgOMPwP6AKNIRh8LR3oQ09p2QSuBFbGRL0Ty/Z B7c3B1PK/C2A43AsPyV0yIBrIJ+bBHvudWxzSMiiqhpntnAQI4bSO0/cxIFlsREYfeaz Fpds68pkW+scQwYHrsYktVZ8SQOZRN8r2ZISjPZzyPugj0wBo8hPyc2Vnm/YWd0y6Gy1 G86A== X-Gm-Message-State: APjAAAUwAlwv27kWhBCEm6zc4gDKqG80CeV+A01Y04TyEXw1kXy34vt0 u3HrblqhdCcCnG2IhkKDAuIOHcixUByRR5NIeFCez21OQH0= X-Received: by 2002:a17:902:758b:: with SMTP id j11mr48233418pll.87.1557323173098; Wed, 08 May 2019 06:46:13 -0700 (PDT) MIME-Version: 1.0 References: <7acd57fe-604a-a96a-4ca2-a25bc88d6405@gmail.com> <9a4351a5-ab04-2ebb-9961-1c50dda9800d@gmail.com> In-Reply-To: <9a4351a5-ab04-2ebb-9961-1c50dda9800d@gmail.com> From: Andy Shevchenko Date: Wed, 8 May 2019 16:46:02 +0300 Message-ID: Subject: Re: [PATCH v3 07/11] platform/x86: asus-wmi: Organize code into sections To: Yurii Pavlovskyi Cc: Corentin Chary , Darren Hart , Andy Shevchenko , Daniel Drake , acpi4asus-user , Platform Driver , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 19, 2019 at 1:12 PM Yurii Pavlovskyi wrote: > > The driver has grown pretty big and will grow more, which makes it hard to > navigate and understand. Add uniform comments to the code and ensure that > it is sorted into logical sections. It does slightly more than described. Please, split out to the separate patch(es) what is not suit to above description. -- With Best Regards, Andy Shevchenko