Received: by 2002:a25:4158:0:0:0:0:0 with SMTP id o85csp5353232yba; Wed, 8 May 2019 11:52:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqxWr8nJsejymYXGhLuMNnqbX8hTBl256NhBbtBHXB5sba8cRi4oUSZP9KfQ4eOzhC0cbmy3 X-Received: by 2002:a17:902:aa91:: with SMTP id d17mr5609722plr.251.1557341522247; Wed, 08 May 2019 11:52:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1557341522; cv=none; d=google.com; s=arc-20160816; b=GB7/0d3DcB7bMm8NaprsrO7tGdf4L7m33rcoGdsHpdUnCMk4MJY7mHRxd4GYp+kOTQ hcKAno+GHnTowD/IGE0Go/ir3TTCOnvd2yyVtdmtNhFnRfudOTQgV9DKr0NKmscS86tf jZ7pOcwTA2HlMpmDR/NSld+8A5cp7KoUyvAEuSK5c9o/rKZB1GwtlDDFm1sZGqMI+gFb gvCnZC46YGgqn79FZDpwOfqBG44OREttUon/8wg9cld8x2AnNvAzANGnkqBmbSuWOsoH lK+9lEtZQa6yy4MMpzJi4b8ILkrg+WVezyGM8iyYqqVfDRvVI0UZxqbHGKndn56vRLH1 kFpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=vhHKTz8mMoSCnbDCtBRD8sjKIRg9nf6n5gxFy6aVPmk=; b=ljaCMw3eSTphQU2C8B7pzleem6SgHFmLCSGdCxnKtEwHDdzE7mZeEfpHFyRIKKMlD/ lPfYoDlApY850sCtw/NcbOOhdxoJ6EIozmVc4rxBF1Fd5iuRu4WsYzH/xRCTcW23YxcI 8QLN57je8Btc+xtnYAeGBy9etjOyVPacYiGJgeWotnQgc1RWOfSQPPceHbaZmvBFmn6X fF5vLvGMTfURJeCQvxLgGmi0yZJGaOScGGO07CBa65qC9tr/xnfm37j2TGCaabtSjv/Q MZsi4VPVmjB049ihWExofVayQGhwCruXdjaHWMHqJ+m55s+uJp2If/wvk1WL4zFZCtUN 7dPQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kudzu-us.20150623.gappssmtp.com header.s=20150623 header.b=mnbXHvPT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h27si6239320pgm.297.2019.05.08.11.51.45; Wed, 08 May 2019 11:52:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kudzu-us.20150623.gappssmtp.com header.s=20150623 header.b=mnbXHvPT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727446AbfEHR46 (ORCPT + 99 others); Wed, 8 May 2019 13:56:58 -0400 Received: from mail-it1-f194.google.com ([209.85.166.194]:36661 "EHLO mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727020AbfEHR46 (ORCPT ); Wed, 8 May 2019 13:56:58 -0400 Received: by mail-it1-f194.google.com with SMTP id o190so5402186itc.1 for ; Wed, 08 May 2019 10:56:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kudzu-us.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vhHKTz8mMoSCnbDCtBRD8sjKIRg9nf6n5gxFy6aVPmk=; b=mnbXHvPTJVuUQuoWXvkL+9wvd75xxvsse7tZ/Ecxz+gwOxUmAPh3CLNfyI7m1r0A2y SyN3/X7R+K+RYjnC0dVycmKkkHsI/y88ffDNRp1lnvATqX7PE2pIM54euZmg/7WhaQVa fU1tHBKxNmRZR/+l7hC9n6iXNa+O4/T+c+36xD8yf82EFy4Lh6C7Jx+t33CwfBtid1jA TM2iTtelB+hslen66V73HX2/+1PDbqv6c9PQ5LJswTBWBVXE9ofrIQ1Wzp2Mtcl/Y+4w SgLgAp1xWh8iUne/CWL9LPP/8MpnlKDImNfmG4IqUcjWAzn4vM+Z39SAJ+WyVwfJVD02 pfEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vhHKTz8mMoSCnbDCtBRD8sjKIRg9nf6n5gxFy6aVPmk=; b=YPmYWi9IUcDVn+LA0SkqcinsFHbOcLNhI2G7fxFOR9Pg0N2JBnoqnmegDj5vEvFCey +HCqKfs/1XE8ZNam3z9uKX05NWX6UcROqFJ6jOQYQtGw3j26L/31IzFjEQqgRiOkpZpb kih3K0tFPaR/EBVgUsHk7bEC1daf2fXfOVMUMbWCRtMxpbzFn56PgkClmcsis3dnKKYa 7dny7X+qn0ZFdry8WZs+nIJ34GH7m2eUPMJ6PlT6Bnkpmvnh7unN5T1A6CvnOgD+pfoG 10I5mKAmONAW5ejInPgiTbf0VaBSsJMBzmUuNba3uPtgXbS/rRiN/+Rj98b3yA4PtKTM krCg== X-Gm-Message-State: APjAAAVPaCexqeDQKEmBrqlwXTftbrK78vnaMHXNFk3TwYgYKN7X6JTR LQrMxe453wngMBGLQ+ZZ5GcOFKmIaF/Q0Ep+pWItjB1DvZf/sd8Q X-Received: by 2002:a24:9d0d:: with SMTP id f13mr4995215itd.162.1557338217593; Wed, 08 May 2019 10:56:57 -0700 (PDT) MIME-Version: 1.0 References: <20190409140347.GA11524@lst.de> <20190508175219.GA32030@lst.de> In-Reply-To: <20190508175219.GA32030@lst.de> From: Jon Mason Date: Wed, 8 May 2019 18:56:46 +0100 Message-ID: Subject: Re: status of the calgary iommu driver To: Christoph Hellwig Cc: Muli Ben-Yehuda , x86@kernel.org, iommu@lists.linux-foundation.org, linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, May 8, 2019 at 6:52 PM Christoph Hellwig wrote: > > On Wed, May 08, 2019 at 06:42:39PM +0100, Jon Mason wrote: > > These systems were plentiful for 2-4 years after the original series > > made it in. After that, the Intel and AMD IOMMUs should were shipped > > and were superior to this chip. So, even in systems where these might > > be present, the AMD/Intel ones should be used (unknown if they were > > shipped on the same ones, as both Muli and I have left IBM). > > > > You thinking about removing the code? > > I'm wondering if we could remove it. I've been done lots of > maintainance on various dma mapping and iommu drivers, and the calgary > one seems like it didn't get a whole lot of love, and I've not seen > any recent users, so I mostly wonder if I should bother at all. I do have a system. So, it could be tested. However given the age of the HW, I would say it is not worth the effort to update and it would be best to remove it from the kernel. I can send a patch to do this, unless you would prefer to do it (or already have something handy). Thanks, Jon